From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3DF3EA0C53 for ; Mon, 22 Nov 2021 10:36:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2D8F641159; Mon, 22 Nov 2021 10:36:36 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 9223040395; Mon, 22 Nov 2021 10:36:32 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10175"; a="215467949" X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="215467949" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2021 01:36:31 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,254,1631602800"; d="scan'208";a="456222717" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga003.jf.intel.com with ESMTP; 22 Nov 2021 01:36:30 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 22 Nov 2021 01:36:30 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 22 Nov 2021 01:36:30 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 22 Nov 2021 01:36:30 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a5eAre16wT4VYhxDz+EZkbYPrhTFW/OEmYfQUXLzkCAmQtLsdKabSxT1+YbLXN/VGmTVMN+qXoQwHPHm1e4brnxmt77jDOjo2K1gC7pwmYzBgxG40aCkOuiwYH3u7JOweLFwwY6N9V6ObZw6GunS5bwOs+USRpHJ3cbAqekeQhZ1djH0RZCx0eW4B+/UUr8JA8euBygP7x9SX680/QfrKSsb1IQXk9ehSqqKGX3frVW2+E2mP8nQswnz1qqOnzXyU/H2XlkP+zJpjOJoYp1pWXE84Ikv0EDfcKhjsU+AquyP9PtqxSSqSWWDwHUck3dAKFd+hVtdDbzpVINnVMrzaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jmWeHDRQAGMbDiMiLcbsOR42QvZiVKxOryH7xI6Uwzs=; b=Bxcrv2ilqwZXBBXLMB+I6kkVUsZo8kelVzQJv6owuuL/0krTfTouwS9CL5njp69jwpQVmeEKja2OXnGotqkxMWfFVOn96Wo/CpvWc1SUIsYNAH97BW7kxFU1i0h9fTxLdELV8RfbTHxP453kLBJ5C3GYU8zU9PoIerQH5CSj62ojbdGNwpWBWoTNw7t8jM1RNnDOVweI+TmvX2cGJvmtAwuHumTHnfGifCKhPTh8AiMNV7AUefl3Vfzfd/PIIlwfi56PdwOo7zLlRu0+k5sSCKLkS5xJeG1TW2fBiixXzoXEQkVYAE8wsc4ZbYBShEgtJcD09aPeqxDu5xLySao5sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jmWeHDRQAGMbDiMiLcbsOR42QvZiVKxOryH7xI6Uwzs=; b=b2uYdQgCt7fvxydDrgVOFUhsZMWXfvosQB3IzWWTHyuy3Z/+F5fHq1g9tBoc/1Zv7zLhd6OjyD+toLC7DQMTpNYCbyEDPksgf1t0p//V7mY+ZVeuqRrdK8ar3KSG3WbqxI6YVnRCsYh07kqH1uFr5prYcgzGLjxlWBdd6GoxAes= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4824.namprd11.prod.outlook.com (2603:10b6:510:38::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Mon, 22 Nov 2021 09:36:29 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bc5f:31a7:10ad:443c%5]) with mapi id 15.20.4690.028; Mon, 22 Nov 2021 09:36:29 +0000 Message-ID: Date: Mon, 22 Nov 2021 09:36:23 +0000 Subject: Re: [dpdk-dev] [PATCH v2] net/failsafe: link_update request crashing at boot Content-Language: en-US To: , CC: , References: <20211021115139.2634-1-vipul.ashri@oracle.com> <20211021214215.1633-1-vipul.ashri@oracle.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211021214215.1633-1-vipul.ashri@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2P250CA0027.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::32) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2P250CA0027.EURP250.PROD.OUTLOOK.COM (2603:10a6:10:231::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend Transport; Mon, 22 Nov 2021 09:36:28 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d8f62c4e-a02e-44fe-4d2b-08d9ad9b8fa3 X-MS-TrafficTypeDiagnostic: PH0PR11MB4824: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GKGqsP2Ugd6VRHJZJaL6IISWL0x6xcmOSBT6w25n1ZP1kMl8dsOkeP6zW7SjPVrww0PWGSLBtTRfvx9ZS5hCBRL8IKK+NorgYe+lpg8sfrLRQUELD/Q4/TTeMvjD8Q2EWiWRqLXou7Tj0INf0WF0N9JjDrdqU6lPtMAtEN7J5YPcmRJuxxfAaVHpWA6RVulfDP8V/7a6/aRN7X47p7aWPROyOsNMgOne4NksRaALcXJ92GUKFL5jEuucI98Ry9QY153J4gXLIpWqMIP85ia4F0zZF4tlxiSC9cH0HZ0dt3nlsuHjySs/TsQh3OgGGFKFxDgmWBUWcpcQ8XTmkt2ntA5RTprDrLtHnAhz1G3rhrPjXYcNsX+VTJ5OC5hV3JKBQLjpluTdMj3JJD2xZAH2ZwYU0ty5SsTvY77Qvf89EN6A5RFeTN+T3alrejN/fn4GJTDLMSq88UvD58hs+rH8Ul+0xD9QcMmiG6GFFAkBt75MmLvr/gbVizag4h+4Toubg8hQQsFc/d4CWZm3S0tkjEOucycQ5fmYuWtUT6O7okKafyO9eZ5pBggiYDpTTIC6cMA2aw/1o6XtkdloUukyOdXf7W4+UyO2DBaHUYhvyn4E0EGDfF3OMy/KGpKLmC74kr6+93/oTql6/usUh1HvxZMsxBDmq4g+aOVr/vajtrrEnK+NXBtBvF33PzsLTKMrakIIS8xphqsoTj6fwW2kHw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(956004)(82960400001)(4326008)(16576012)(2906002)(316002)(36756003)(31686004)(6666004)(44832011)(83380400001)(4744005)(2616005)(31696002)(8676002)(66476007)(66556008)(508600001)(53546011)(26005)(8936002)(186003)(86362001)(5660300002)(66946007)(6486002)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QXVsL25uR3BYNmxuQjBacmE4TWc3K29pMG15WFMxYmpZQUw2N25rcDBMdzEv?= =?utf-8?B?UXFneVJNdit3dXZCZ2g3dFNXN3BQL1pQQTBUWXpUdVVFQ1lTZGhhUzdQWG5t?= =?utf-8?B?K2dTcDlzczYxNDBmVFNlcHBMNVN5Rzg1eUJ5K0t4TFc0bDhXY1I3aW5NTEo3?= =?utf-8?B?RzVVby96RThqYkJoYTFMc1lhVGROaXdqTEw2YTlsRk5NMUhHMC9GWTVta2l5?= =?utf-8?B?eUZkUG43TkptSS81M2d2ZXpiYWFPdlRJMS9JeEhMRytFNW50aW43NlNUL2RJ?= =?utf-8?B?WlI3dTNaNUw0bUpBalNpbHdZNVlGL2FvWUFjaEhxTmYya2Y4eWpvbnhlZHQ0?= =?utf-8?B?eWNqMjBEc1g2TkhsVUtIU24xNXFZSkJFc3I2VUVlZzRZTFgxMHJPWDJaQmJI?= =?utf-8?B?ZHlibkZjc3lWbGZBYWxGelBCTENpK1F3aFJlY1piRkpxMDdVOGs3Zzd6UUNx?= =?utf-8?B?WUk3cmU5Y1BPbmFkVjF2alpUVEdVZU9iNkRET3NVWVlxS0kwMWNTSWhnYm5L?= =?utf-8?B?TmZOajl0a2w3OTF2a1NEcVlWRzh2dEtaM0drRVlnSWVET2ZzZzl0Sjk5SGRj?= =?utf-8?B?T1lWS25aUG84Q1ZnN0R3RStvTHlnbGp0OWFLekRZTVAzdDQ1SlBmYjNzY2M1?= =?utf-8?B?MFpDSVRRWUhZclJYUjRHSGdTYm1FK01odWxVUG9QWWhKMTJLZW11c3p5Q0dO?= =?utf-8?B?ZG1obnJHeklaQ1FqLytyTXBPK0h3cEphWkdidUVmaGpuWHBUQlgxVVAyRncy?= =?utf-8?B?MFRDamxtWC9aNWhTaElHN3diWndoRmNyREM4eXcyUGZoeWdFWkE5Z25hcHND?= =?utf-8?B?UUo0Z3J3emFlamtFNUhDSmdPdWZzazZmc3kzcWZ1c1psUlFNcEFOdVcyaDh5?= =?utf-8?B?cmhIZHNkTkJSUFVmMzVGbVhNeXV4clhVYnhmSDVwUXdYYjNSTktkYlcvbmVB?= =?utf-8?B?dS84bTlsQlJYOTAxNW9iTWxhK1VVT2ExaTVNelNUS3pzK0VEQ0ZVeHVnYVpD?= =?utf-8?B?QkpSU2ZVSzB0cjN5RFhGdEJsWm83Y0VRWHdOeTFoaHg3Q0xqRTd1NHhYYVlk?= =?utf-8?B?QS90TnZMY3g3QS9DSElSRXlGV3lJcFUzUG1KUUt6R09EbkdlYUEwZlVoWFhW?= =?utf-8?B?WmJBeFRxa2JNU3Nlb21Mc2J3MmdNcUpvUmxjYWFheTFJUzVxM3dYcmpXRnc1?= =?utf-8?B?YnJTTGV6d29sQWY0aE1zL1dKcVJKbE1JbXFvSlZZWkhlc1EwUlVGTEpjSmRL?= =?utf-8?B?WUltTGJ2OEFUUVc2YStkU0tOZzRvbEVyVGtxSVJVRFprVzdYTG5qMk8yRkJj?= =?utf-8?B?clhzOFZ6RGRZRk1wRCtUZTlmN2JxSVRGNEdpaDZTUldSMktiek5Xb2NmYkpW?= =?utf-8?B?QWVJSTlGeEFmQWxya1NwcVJMbkMrVHRqZ0ROeUdvOENZU1Z2WUx5b1ZsWHpG?= =?utf-8?B?K3NCdTdTRVQwdExlZFpCM0FCYU9uVE5iMjAzQXZGcGlsbHJEbU4zK2JFRlpa?= =?utf-8?B?VVR0ZjJnbUljcjZJWVEzODhSQjV4RUF4amkwejF0WGhrS1h3Q2J0MjRwQ0hE?= =?utf-8?B?SW1QNGVERWp1UVMwUW5PZnQvNTczOXMxS2wvdC9ia3d4M3I5WnpNTklUejVK?= =?utf-8?B?ZE9LU3hsck1ZT1RYelorRjNvdkFTU0tZYWxLQThZK1BIU21vS0o2MXFROW90?= =?utf-8?B?cGpBQWlnZXJXc1IvWVpGTW90VTJ5elQzUVBJTVFiTThkS2hyRWExMU1nZmgy?= =?utf-8?B?RTRZNzNUSVRvZW5qU3JTOHJLY2hmVnNGcFkxZFFMekNPZTF5RWFYMG16TlU5?= =?utf-8?B?TkNHTUxWSElDMmdFNDNoT21uMzlqRlN4dlNHNjR2czJFMkJtRWlvMEd0SWhm?= =?utf-8?B?c3gvcWNjYmljbnZxZUVNenk3TnhWM2FpTHpRcSswV01XZisvQ0xrUWNRMVhs?= =?utf-8?B?Y241eUZKT0FGVTAvcTZ3Z2k4Y2xvbU5NOWxpdWFoRytFZGF4Y1pPQzRMTkdE?= =?utf-8?B?czViVDZnVXFuUmZMcVppS2M3V1VrQ2YreXF6ZDlmeFlodVMzZFVpalAvdHQz?= =?utf-8?B?UEp2cExaVlErQ0V6L0Q3MXBxMk1jckEvMWNWYktxUi9XbDBUMC9WeWpFS0ZG?= =?utf-8?B?L1IzTXlXUnkvMTNTZ1RvTXBFMXkvajZMSGdyS2xpMkN1LzlVdlppU2svM2Vu?= =?utf-8?Q?gB0/mypBDhSVWYFteuBpYhU=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: d8f62c4e-a02e-44fe-4d2b-08d9ad9b8fa3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2021 09:36:29.3524 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nBfbOJdhbZicZGy4LO40lFHPPEhJyizrWAXIhYhW7Mx8oahefLEW4IkNRv/b1Tn4vsxp4SJsv785phb6/kEocQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4824 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 10/21/2021 10:42 PM, vipul.ashri@oracle.com wrote: > From: Vipul Ashri > > failsafe crashed while sending early link_update request during > boot time initialization. > Based on debugging we found failsafe device was good but sub- > devices were progressing towards initialization and SUBOPS macro > where expanding macro gives [partial_dev]->dev_ops->link_update() > execution of which triggered crash because dev_ops==0. similar > crash seen at failsafe_eth_dev_close() > > Failsafe driver need a separate check for subdevices similar to > "RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);" which is > called to almost every eth_dev function. > > Fixes: a46f8d5 ("net/failsafe: add fail-safe PMD") > Cc: stable@dpdk.org > Signed-off-by: Vipul Ashri Hi Gaetan, Can you please review this patch? Thanks, ferruh