From: Kevin Traynor <ktraynor@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>, stable@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [dpdk-stable] [PATCH 18.11 1/1] net/mlx: fix overlinking with meson and glue dlopen
Date: Fri, 11 Dec 2020 09:45:00 +0000 [thread overview]
Message-ID: <fea25b9b-9f64-9510-fce7-3c032411e156@redhat.com> (raw)
In-Reply-To: <20201210212136.2636082-1-thomas@monjalon.net>
On 10/12/2020 21:21, Thomas Monjalon wrote:
> [ upstream commit e21492a5175af31ae568fa5fabef1f4b22706962 ]
>
> If enable_driver_mlx_glue=true, the PMD and application should not
> be linked with ibverbs, but the glue library is.
> Unfortunately the ibverbs dependency was exported in the
> variable ext_deps, so there were overlinking.
>
> It is fixed by not exporting the dependency in ext_deps,
> and recreating a limited dependency object for cflags only.
>
> Fixes: 1dd7c7e38c19 ("net/mlx4: support meson build")
> Fixes: 96d7c62a70c7 ("net/mlx5: support meson build")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> buildtools/meson.build | 2 ++
> drivers/net/mlx4/meson.build | 8 +++++++-
> drivers/net/mlx5/meson.build | 9 ++++++++-
> 3 files changed, 17 insertions(+), 2 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2020-12-11 9:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 21:21 Thomas Monjalon
2020-12-11 9:45 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fea25b9b-9f64-9510-fce7-3c032411e156@redhat.com \
--to=ktraynor@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=matan@nvidia.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=shahafs@nvidia.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).