From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9EBF543739
for <public@inbox.dpdk.org>; Tue, 19 Dec 2023 13:30:29 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 90F5B42DFD;
Tue, 19 Dec 2023 13:30:29 +0100 (CET)
Received: from frasgout.his.huawei.com (frasgout.his.huawei.com
[185.176.79.56])
by mails.dpdk.org (Postfix) with ESMTP id B3DEB40283;
Tue, 19 Dec 2023 13:30:26 +0100 (CET)
Received: from mail.maildlp.com (unknown [172.18.186.231])
by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SvbbT0pbmz6J9qC;
Tue, 19 Dec 2023 20:29:09 +0800 (CST)
Received: from frapeml100008.china.huawei.com (unknown [7.182.85.131])
by mail.maildlp.com (Postfix) with ESMTPS id 89FC2140B71;
Tue, 19 Dec 2023 20:30:10 +0800 (CST)
Received: from frapeml500007.china.huawei.com (7.182.85.172) by
frapeml100008.china.huawei.com (7.182.85.131) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.35; Tue, 19 Dec 2023 13:30:06 +0100
Received: from frapeml500007.china.huawei.com ([7.182.85.172]) by
frapeml500007.china.huawei.com ([7.182.85.172]) with mapi id 15.01.2507.035;
Tue, 19 Dec 2023 13:30:06 +0100
From: Konstantin Ananyev <konstantin.ananyev@huawei.com>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>, Sivaprasad Tummala
<sivaprasad.tummala@amd.com>, "david.hunt@intel.com" <david.hunt@intel.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>, "jerinj@marvell.com"
<jerinj@marvell.com>, "radu.nicolau@intel.com" <radu.nicolau@intel.com>,
"gakhil@marvell.com" <gakhil@marvell.com>, "cristian.dumitrescu@intel.com"
<cristian.dumitrescu@intel.com>, "ferruh.yigit@amd.com"
<ferruh.yigit@amd.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: RE: [PATCH v2 1/6] examples/l3fwd: fix lcore ID restriction
Thread-Topic: [PATCH v2 1/6] examples/l3fwd: fix lcore ID restriction
Thread-Index: AQHaMiuEVTKpsBDLF0CQ9pPlPVi3J7CwguIwgAAGihA=
Date: Tue, 19 Dec 2023 12:30:06 +0000
Message-ID: <ffb423304869478a8182092a4d03f8b4@huawei.com>
References: <20231218074905.42749-1-sivaprasad.tummala@amd.com>
<20231219032826.4814-1-sivaprasad.tummala@amd.com>
<20231219032826.4814-2-sivaprasad.tummala@amd.com>
<0897bc70dd984126a02c3f5046495c1c@huawei.com>
In-Reply-To: <0897bc70dd984126a02c3f5046495c1c@huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [10.206.138.42]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
>=20
> > Currently the config option allows lcore IDs up to 255,
> > irrespective of RTE_MAX_LCORES and needs to be fixed.
> >
> > The patch allows config options based on DPDK config.
> >
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
> > examples/l3fwd/main.c | 19 +++++++++++--------
> > 1 file changed, 11 insertions(+), 8 deletions(-)
> >
> > diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c
> > index 3bf28aec0c..ed116da09c 100644
> > --- a/examples/l3fwd/main.c
> > +++ b/examples/l3fwd/main.c
> > @@ -99,7 +99,7 @@ struct parm_cfg parm_config;
> > struct lcore_params {
> > uint16_t port_id;
> > uint8_t queue_id;
Actually one comment:=20
As lcore_id becomes uint16_t it might be worth to do the same queue_id,
they usually are very much related.=20
> > - uint8_t lcore_id;
> > + uint16_t lcore_id;
> > } __rte_cache_aligned;
> >
> > static struct lcore_params lcore_params_array[MAX_LCORE_PARAMS];
> > @@ -292,8 +292,8 @@ setup_l3fwd_lookup_tables(void)
> > static int
> > check_lcore_params(void)
> > {
> > - uint8_t queue, lcore;
> > - uint16_t i;
> > + uint8_t queue;
> > + uint16_t i, lcore;
> > int socketid;
> >
> > for (i =3D 0; i < nb_lcore_params; ++i) {
> > @@ -304,12 +304,12 @@ check_lcore_params(void)
> > }
> > lcore =3D lcore_params[i].lcore_id;
> > if (!rte_lcore_is_enabled(lcore)) {
> > - printf("error: lcore %hhu is not enabled in lcore mask\n", lcore);
> > + printf("error: lcore %hu is not enabled in lcore mask\n", lcore);
> > return -1;
> > }
> > if ((socketid =3D rte_lcore_to_socket_id(lcore) !=3D 0) &&
> > (numa_on =3D=3D 0)) {
> > - printf("warning: lcore %hhu is on socket %d with numa off \n",
> > + printf("warning: lcore %hu is on socket %d with numa off\n",
> > lcore, socketid);
> > }
> > }
> > @@ -359,7 +359,7 @@ static int
> > init_lcore_rx_queues(void)
> > {
> > uint16_t i, nb_rx_queue;
> > - uint8_t lcore;
> > + uint16_t lcore;
> >
> > for (i =3D 0; i < nb_lcore_params; ++i) {
> > lcore =3D lcore_params[i].lcore_id;
> > @@ -500,6 +500,8 @@ parse_config(const char *q_arg)
> > char *str_fld[_NUM_FLD];
> > int i;
> > unsigned size;
> > + unsigned int max_fld[_NUM_FLD] =3D {RTE_MAX_ETHPORTS,
> > + 255, RTE_MAX_LCORE};
> >
> > nb_lcore_params =3D 0;
> >
> > @@ -518,7 +520,8 @@ parse_config(const char *q_arg)
> > for (i =3D 0; i < _NUM_FLD; i++){
> > errno =3D 0;
> > int_fld[i] =3D strtoul(str_fld[i], &end, 0);
> > - if (errno !=3D 0 || end =3D=3D str_fld[i] || int_fld[i] > 255)
> > + if (errno !=3D 0 || end =3D=3D str_fld[i] || int_fld[i] >
> > + max_fld[i])
> > return -1;
> > }
> > if (nb_lcore_params >=3D MAX_LCORE_PARAMS) {
> > @@ -531,7 +534,7 @@ parse_config(const char *q_arg)
> > lcore_params_array[nb_lcore_params].queue_id =3D
> > (uint8_t)int_fld[FLD_QUEUE];
> > lcore_params_array[nb_lcore_params].lcore_id =3D
> > - (uint8_t)int_fld[FLD_LCORE];
> > + (uint16_t)int_fld[FLD_LCORE];
> > ++nb_lcore_params;
> > }
> > lcore_params =3D lcore_params_array;
> > --
>=20
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
>=20
>=20
> > 2.25.1