From: Andy Green <andy@warmcat.com>
To: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4 18/18] app/test-bbdev: strcpy ok for allocated string
Date: Sat, 12 May 2018 09:39:38 +0800 [thread overview]
Message-ID: <ffd16a01-a9ad-c7e0-5694-51775125af44@warmcat.com> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8976CD08DBE@IRSMSX108.ger.corp.intel.com>
On 05/11/2018 09:02 PM, De Lara Guarch, Pablo wrote:
>
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Andy Green
>> Sent: Friday, May 11, 2018 2:47 AM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH v4 18/18] app/test-bbdev: strcpy ok for allocated
>> string
>>
>> Signed-off-by: Andy Green <andy@warmcat.com>
>> ---
>> app/test-bbdev/test_bbdev_vector.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/app/test-bbdev/test_bbdev_vector.c b/app/test-
>> bbdev/test_bbdev_vector.c
>> index c574f2135..4a3ddcffe 100644
>> --- a/app/test-bbdev/test_bbdev_vector.c
>> +++ b/app/test-bbdev/test_bbdev_vector.c
>> @@ -914,7 +914,8 @@ test_bbdev_vector_read(const char *filename,
>> }
>>
>> entry = entry_extended;
>> - strncat(entry, line, strlen(line));
>> + /* entry has been allocated accordingly */
>> + strcpy(&entry[strlen(entry)], line);
>
> If memset is removed in the previous patch, then we'll need to use strlcpy
> here, to ensure NULL termination.
No... the destination has been allocated dynamically so there is no case
where the source length can exceed the destination.
I think for that reason it's OK to remove the memset() here, because for
the same reason it will always exactly fill the dynamically sized string
anyway.
-Andy
> Missing fixes line and CC stable:
>
> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
> Cc: stable@dpdk.org
>
next prev parent reply other threads:[~2018-05-12 1:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <152600304856.53146.9681482138854493833.stgit@localhost.localdomain>
[not found] ` <152600313083.53146.365116365602153188.stgit@localhost.localdomain>
2018-05-11 8:17 ` [dpdk-stable] [dpdk-dev] [PATCH v4 03/18] bus/pci: replace strncpy dangerous code De Lara Guarch, Pablo
[not found] ` <152600313586.53146.7523419645550338762.stgit@localhost.localdomain>
2018-05-11 8:26 ` [dpdk-stable] [dpdk-dev] [PATCH v4 04/18] bus/dpaa: solve inconsistent struct alignment De Lara Guarch, Pablo
[not found] ` <152600312580.53146.1090136345409468008.stgit@localhost.localdomain>
2018-05-11 8:58 ` [dpdk-stable] [dpdk-dev] [PATCH v4 02/18] net/nfp: solve buffer overflow De Lara Guarch, Pablo
2018-05-11 10:13 ` De Lara Guarch, Pablo
[not found] ` <152600315600.53146.7909626180486080315.stgit@localhost.localdomain>
2018-05-11 10:36 ` [dpdk-stable] [dpdk-dev] [PATCH v4 08/18] net/nfp: don't memcpy out of source range De Lara Guarch, Pablo
[not found] ` <152600316103.53146.10955338688055072616.stgit@localhost.localdomain>
2018-05-11 10:43 ` [dpdk-stable] [dpdk-dev] [PATCH v4 09/18] net/qede: strncpy length constant and NUL De Lara Guarch, Pablo
2018-05-11 10:48 ` Andy Green
2018-05-11 12:48 ` De Lara Guarch, Pablo
2018-05-11 13:38 ` Andy Green
2018-05-11 15:14 ` De Lara Guarch, Pablo
2018-05-11 17:13 ` Shaikh, Shahed
[not found] ` <152600316606.53146.14953519058439248573.stgit@localhost.localdomain>
2018-05-11 10:47 ` [dpdk-stable] [dpdk-dev] [PATCH v4 10/18] net/qede: solve broken strncpy De Lara Guarch, Pablo
[not found] ` <152600317109.53146.6555330710274289069.stgit@localhost.localdomain>
2018-05-11 10:51 ` [dpdk-stable] [dpdk-dev] [PATCH v4 11/18] net/sfc: correct strncpy length De Lara Guarch, Pablo
2018-05-12 1:21 ` Andy Green
[not found] ` <152600317613.53146.6276891139126316271.stgit@localhost.localdomain>
2018-05-11 10:55 ` [dpdk-stable] [dpdk-dev] [PATCH v4 12/18] net/sfc: solve strncpy size and NUL De Lara Guarch, Pablo
2018-05-12 1:24 ` Andy Green
[not found] ` <152600318620.53146.6364478443735658822.stgit@localhost.localdomain>
2018-05-11 10:58 ` [dpdk-stable] [dpdk-dev] [PATCH v4 14/18] net/vdev_netvsc: 3 x strncpy misuse De Lara Guarch, Pablo
[not found] ` <152600319626.53146.13225564187658388686.stgit@localhost.localdomain>
2018-05-11 12:26 ` [dpdk-stable] [dpdk-dev] [PATCH v4 16/18] app/proc-info: sprintf overrun bug De Lara Guarch, Pablo
2018-05-12 1:33 ` Andy Green
[not found] ` <152600320129.53146.5983894189916318956.stgit@localhost.localdomain>
2018-05-11 12:55 ` [dpdk-stable] [dpdk-dev] [PATCH v4 17/18] app/test-bbdev: strcpy ok for allocated string De Lara Guarch, Pablo
[not found] ` <152600320633.53146.1883908043976158624.stgit@localhost.localdomain>
2018-05-11 13:02 ` [dpdk-stable] [dpdk-dev] [PATCH v4 18/18] " De Lara Guarch, Pablo
2018-05-12 1:39 ` Andy Green [this message]
[not found] ` <152600318116.53146.3348256529816730536.stgit@localhost.localdomain>
2018-05-11 15:39 ` [dpdk-stable] [dpdk-dev] [PATCH v4 13/18] net/vdev_netvsc: readlink inputs cannot be aliased De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ffd16a01-a9ad-c7e0-5694-51775125af44@warmcat.com \
--to=andy@warmcat.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).