From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9EA4A0350 for ; Tue, 21 Dec 2021 07:42:00 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBF5A40E2D; Tue, 21 Dec 2021 07:42:00 +0100 (CET) Received: from out203-205-221-231.mail.qq.com (out203-205-221-231.mail.qq.com [203.205.221.231]) by mails.dpdk.org (Postfix) with ESMTP id 75FA84003C; Tue, 21 Dec 2021 07:41:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1640068905; bh=n0ypQtVbfbyDeDAGaXV+X8IPvwwkBMgxCErlhf1wLfQ=; h=From:To:Cc:Subject:Date; b=piB1tuE2yoX8a10llh8QlWlvOD7iqwcN7NcSUfrumQZQDBTjxFhWeBnRe7BV8V/wv CPJESVNerYh5ig1+yZo05LLwoH2tu8eXsx162/p4vwOlseLJdP8eiv6c9Py+VmMwdG lqe+Zj2BwVJAZlZ8XUdTiHu/jCO7FatqsePstcU4= Received: from localhost.localdomain ([47.100.249.77]) by newxmesmtplogicsvrsza8.qq.com (NewEsmtp) with SMTP id A62B6C3A; Tue, 21 Dec 2021 14:41:34 +0800 X-QQ-mid: xmsmtpt1640068894tnrps07hv Message-ID: X-QQ-XMAILINFO: Odf6WZwpq0Z+Q9TYlpmTSu9b2NGaKF/64Ccnfro9f2oJTgYkx96eu3Tw8uc0Ez 5oeUmXrha3OzrSqKaH5qoivoiF0hS7jNvH008d+RvgwNqb7aeYQ+eiRWjsmVc7tZ8xHhJiBMRQc1 WFkjzW+5eadpDKTE8fpjoGC3/C1GnsEuyA6ZntjPRwI7tipcMz4f1v/q488C7Y0eLiRJ4u7dmGbn WA5G0RQBXzk2Lqig5xUYV2RHJP0zrl+zExqKuR2UO+C/he3qb8QUzQo7cWAmn6lrYFvpljQ6LI+o whOmHHQcc5DbaCgq/uPwFeJVEr6GthxZIDSLhx/ap5UyL811NPDX8mUETGHiJYzWCUz2HGyQaBFT eXI+sifVGcgIGRAajCnXP9dLzJq5YYitWqokMqS6say4yEZdSWXD/F/Kpj4EYVmSAzf789gm6F82 QCD2XOqZOmWrriGIqFacSWTiebaGOfAWMuUEzOJdHEqgiD5KI0DUoYjq+l/n6VK11M/JVW1dUbmA kex42mf/0KPaRLca/YFJzjyZ5Wvbn/Fkg23UElYpX2/V1CvzM9QFG+R1anxHiT+vkP/Sys9TL3lB TkwwJuwuvXd37ima768aCiiOhhMQj2G9gXsEtzGTyawuu76EZRiVFkq5JY9F+ziKomxcM+2O6jxu a4l0Hd+3pqyU6PfpG8wZk9QwPEBFEp/mDmSDalz9C2MwHv5VCLnxmxm1RdelhXh0d7+sn1Kyemy7 q58RuWBUZAv/YQ5zawb6bOkQh/krxdvRST4Z6NlWUlwjmmrP+MBu6lF9Q3fJAP4Th+lm+i1TcEai DB3aRxW3v5k+Hq6VsXErzEjVUC6klXqU+Xb2l9m0ppzo9JC3GZJP0taEV+CdIr6WLQVcdyRKsUFr ge9Oek9LsSuEIT1aIL4JJL8G7ZWNM5MQ== From: Weiguo Li To: andrew.rybchenko@oktetlabs.ru Cc: ivan.ilchenko@oktetlabs.ru, dev@dpdk.org, stable@dpdk.org Subject: [PATCH] net/sfc: fix the argument to sizeof for unit cache Date: Tue, 21 Dec 2021 14:41:22 +0800 X-OQ-MSGID: <20211221064122.885599-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The size of unit cache should be sizeof(**cache) instead of sizeof(*cache). Memory reallocation is inadequate by sizeof(*cache) for the platform whose size of pointer is 32-bits. Found by coccinelle (see https://coccinelle.gitlabpages.inria.fr/website) script. Fixes: 63abf8d29225 ("net/sfc: support SW stats groups") Cc: stable@dpdk.org Signed-off-by: Weiguo Li --- drivers/net/sfc/sfc_sw_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_sw_stats.c b/drivers/net/sfc/sfc_sw_stats.c index 70259660c0..81f5aa3cc4 100644 --- a/drivers/net/sfc/sfc_sw_stats.c +++ b/drivers/net/sfc/sfc_sw_stats.c @@ -777,7 +777,7 @@ sfc_sw_xstats_configure(struct sfc_adapter *sa) memset(*reset_vals, 0, nb_supported * sizeof(**reset_vals)); - *cache = rte_realloc(*cache, cache_count * sizeof(*cache), 0); + *cache = rte_realloc(*cache, cache_count * sizeof(**cache), 0); if (*cache == NULL) { rc = ENOMEM; goto fail_cache; -- 2.25.1