From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 7E10A2952 for ; Fri, 4 May 2018 18:53:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2018 09:53:10 -0700 Message-Id: <0590c7$1iob7v@orsmga001.jf.intel.com> Date: 04 May 2018 09:53:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,363,1520924400"; d="scan'208";a="53226751" Received: from unknown (HELO localhost.localdomain) ([10.240.176.250]) by orsmga001.jf.intel.com with ESMTP; 04 May 2018 09:53:09 -0700 Content-Type: multipart/alternative; boundary="===============6284072778044560084==" MIME-Version: 1.0 From: sys_stv@intel.com To: test-report@dpdk.org CC: ophirmu@mellanox.com Subject: [dpdk-test-report] |FAILURE| pw38690 [PATCH] net/tap: remove queue specific offload support Re: [PATCH] [PATCH] net/tap: remove queue specific offload > support > > On 4/23/2018 10:17 AM Ophir Munk wrote: > > Hi Ferruh > > A quick feedback to your patch on top of next-net/master: the IP and TCP > offloaded checksums are turned incorrect. > > Hi Ophir > > Thanks for testing. > This patch removes queue specific offloads for tap but nothing touched on > port offloads and in below test you are already using single queue. > > This may mean something is wrong in tap for port offloading configuration. > > Tap does csum calculation in Tx path [1] which does not even checks the > offloading flags but mbuf->ol_flags. Any chance that mbuf->ol_flags is not > set correct? Can you able to make exact same setup work without this > patch? > > > [1] > if (txq->csum && > ((mbuf->ol_flags & (PKT_TX_IP_CKSUM | PKT_TX_IPV4) || > (mbuf->ol_flags & PKT_TX_L4_MASK) == PKT_TX_UDP_CKSUM || > (mbuf->ol_flags & PKT_TX_L4_MASK) == PKT_TX_TCP_CKSUM))) { > /* Support only packets with all data in the same seg */ > if (mbuf->nb_segs > 1) > break; > /* To change checksums work on a copy of data. */ > rte_memcpy(m_copy rte_pktmbuf_mtod(mbuf void *) > rte_pktmbuf_data_len(mbuf)); > tap_tx_offload(m_copy mbuf->ol_flags > mbuf->l2_len mbuf->l3_len); > iovecs[1].iov_base = m_copy; > } > > > > > > Detailed description > > ================ > > A traffic generator is sending to a dpdk device one TCP packet and expects > to receive it back after the IP and TCP checksums have been calculated by > TAP. > > > > Testpmd parameters > > ================= > > testpmd -c 0x0f -n 4 --vdev="net_tap0 iface=net_vsc0 remote=ens2" -w > > 0000:00:00.0 -- --burst=64 --mbcache=512 --portmask 0x1 -i --txd=256 > > --rxd=256 --rxq=1 --txq=1 --coremask 0x008 --forward-mode=csum > > --eth-peer=0 00:15:5d:10:66:02 > > > > Testpmd CLI commands > > =================== > > testpmd> port stop all > > testpmd> csum set ip hw 0 > > testpmd> csum set tcp hw 0 > > testpmd> port start all > > testpmd> start > > > > On Traffic generator side > > ===================== > > A traffic generator (scapy) is sending 1261 bytes of a TCP packet > > > > Monitoring the traffic: > > > > tcpdump -i -envvv & > > > > The tcpdump output shows the sent packet followed by the received > packet. > > Please note the received packet has incorrect IP & TCP checksums (both > > are 0) > > > > 11:51:03.058623 00:15:5d:10:66:02 > f4:52:14:7a:59:81 ethertype IPv4 > (0x0800) length 1261: (tos 0x0 ttl 64 id 1 offset 0 flags [none] proto TCP > (6) length 1247) > > 127.0.0.1.1 > 127.0.0.1.1: Flags [S] cksum 0xdba5 (correct) seq > > 0:1207 win 8192 length 1207 > > > > 11:51:03.058836 f4:52:14:7a:59:81 > 00:15:5d:10:66:02 ethertype IPv4 > (0x0800) length 1261: (tos 0x0 ttl 64 id 1 offset 0 flags [none] proto TCP > (6) length 1247 bad cksum 0 (->7816)!) > > 127.0.0.1.1 > 127.0.0.1.1: Flags [S] cksum 0x0000 (incorrect -> > > 0xdba5) seq 0:1207 win 8192 length 1207 > > > > Regards > > Ophir > > > >> -----Original Message----- > >> RE: [PATCH] [PATCH] net/tap: remove queue specific > >> offload support > >> > >> Hi Ferruh > >> I was able to apply your patch with Thomas help: > >> 1. git am --reject > >> 2. 3. git am --continue > >> > >> Regards > >> Ophir > >> > >>> -----Original Message----- > >>> RE: [PATCH] [PATCH] net/tap: remove queue specific > >>> offload support > >>> > >>> Hi Ferruh > >>> I am not able to apply your patch on next-net/master branch. > >>> I am failing to apply it both on latest commit or just before > >>> 22-Mar-18 (commit's date). > >>> > >>> $ git am > >>> dpdk-dev-net-tap-remove-queue-specific-offload-support.patch > >>> Applying: net/tap: remove queue specific offload support > >>> error: patch failed: drivers/net/tap/rte_eth_tap.c:269 > >>> error: drivers/net/tap/rte_eth_tap.c: patch does not apply Patch > >>> failed at > >>> 0001 net/tap: remove queue specific offload support > >>> > >>> Please advise. > >>> > >>> Once this error is fixed I can verify your patch with high priority > >>> and send you my feedback. > >>> > >>> Regards > >>> Ophir > >>> > >>>> -----Original Message----- > >>>> Re: [PATCH] [PATCH] net/tap: remove queue specific > >>>> offload support > >>>> > >>>> On 4/18/2018 10:40 AM Ophir Munk wrote: > >>>>> Hi Ferruh > >>>>> Sorry for the delayed response. > >>>>> > >>>>> I would like to verify the correctness of this patch by running > >>>>> several > >>>> internal tests. > >>>>> Is a reply by Monday OK with you? > >>>> > >>>> Monday can be late to include patch into rc1 any chance to do earlier? > >>>> > >>>>> > >>>>> Regards > >>>>> Ophir > >>>>> > >>>>>> -----Original Message----- > >>>>>> X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 May 2018 16:53:13 -0000 --===============6284072778044560084== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 VGVzdC1MYWJlbDogSW50ZWwtY29tcGlsYXRpb24KVGVzdC1TdGF0dXM6IEZBSUxVUkUKaHR0cDov L2RwZGsub3JnL3BhdGNoLzM4NjkwCgpfYXBwbHkgcGF0Y2ggZmlsZSBmYWlsdXJlXwoKU3VibWl0 dGVyOiBPcGhpciBNdW5rIDxvcGhpcm11QG1lbGxhbm94LmNvbT4KRGF0ZTogTW9uLCAyMyBBcHIg MjAxOCAxMTozMjo1NiArMDAwMApEUERLIGdpdCBiYXNlbGluZTogUmVwbzpkcGRrLW5leHQtZXZl bnRkZXYsIEJyYW5jaDptYXN0ZXIsIENvbW1pdElEOmZjZGU4NGI1Zjg1YjNjMWE1ZDU1NjQyOTlm ZDQ5YzU4Y2EyMDM3MGQKICAgICAgICAgICAgICAgICAgIFJlcG86ZHBkay1uZXh0LWNyeXB0bywg QnJhbmNoOm1hc3RlciwgQ29tbWl0SUQ6N2JhYWM3NzU5NDVjZTI2ZjQ3NDAxNTg2NTY5NjVmMDk1 ZGM0ZGJkYQogICAgICAgICAgICAgICAgICAgUmVwbzpkcGRrLW5leHQtbmV0LCBCcmFuY2g6bWFz dGVyLCBDb21taXRJRDoyOWY0YWI4NDRjZGI2MWQ3MjQxZjcyNDFmZTg2MDc3OTUxNmI5MDEyCiAg ICAgICAgICAgICAgICAgICBSZXBvOmRwZGstbmV4dC12aXJ0aW8sIEJyYW5jaDptYXN0ZXIsIENv bW1pdElEOjAzN2MwOTk2YmM5MjczNDJmMTU3NDI2NzM5ZTBjYjYzZjJkYjg2ODkKICAgICAgICAg ICAgICAgICAgIFJlcG86ZHBkaywgQnJhbmNoOm1hc3RlciwgQ29tbWl0SUQ6ZWU3M2Y5OGVmNDgx ZjYxZWFiMmY3Mjg5ZjAzM2M2ZjkxMTNlZWU4YQogICAgICAgICAgICAgICAgICAgCkFwcGx5IHBh dGNoIGZpbGUgZmFpbGVkOgpSZXBvOiBkcGRrCjM4NjkwOgooU3RyaXBwaW5nIHRyYWlsaW5nIENS cyBmcm9tIHBhdGNoOyB1c2UgLS1iaW5hcnkgdG8gZGlzYWJsZS4pCnBhdGNoaW5nIGZpbGUgZHJp dmVycy9uZXQvdGFwL3J0ZV9ldGhfdGFwLmMKSHVuayAjMSBGQUlMRUQgYXQgMTEwOC4KMSBvdXQg b2YgMSBodW5rIEZBSUxFRCAtLSBzYXZpbmcgcmVqZWN0cyB0byBmaWxlIGRyaXZlcnMvbmV0L3Rh cC9ydGVfZXRoX3RhcC5jLnJlagoKUmVwbzogZHBkay1uZXh0LWNyeXB0bwozODY5MDoKKFN0cmlw cGluZyB0cmFpbGluZyBDUnMgZnJvbSBwYXRjaDsgdXNlIC0tYmluYXJ5IHRvIGRpc2FibGUuKQpw YXRjaGluZyBmaWxlIGRyaXZlcnMvbmV0L3RhcC9ydGVfZXRoX3RhcC5jCkh1bmsgIzEgRkFJTEVE IGF0IDExMDguCjEgb3V0IG9mIDEgaHVuayBGQUlMRUQgLS0gc2F2aW5nIHJlamVjdHMgdG8gZmls ZSBkcml2ZXJzL25ldC90YXAvcnRlX2V0aF90YXAuYy5yZWoKClJlcG86IGRwZGstbmV4dC1uZXQK Mzg2OTA6CihTdHJpcHBpbmcgdHJhaWxpbmcgQ1JzIGZyb20gcGF0Y2g7IHVzZSAtLWJpbmFyeSB0 byBkaXNhYmxlLikKcGF0Y2hpbmcgZmlsZSBkcml2ZXJzL25ldC90YXAvcnRlX2V0aF90YXAuYwpI dW5rICMxIEZBSUxFRCBhdCAxMTA4LgoxIG91dCBvZiAxIGh1bmsgRkFJTEVEIC0tIHNhdmluZyBy ZWplY3RzIHRvIGZpbGUgZHJpdmVycy9uZXQvdGFwL3J0ZV9ldGhfdGFwLmMucmVqCgpSZXBvOiBk cGRrLW5leHQtdmlydGlvCjM4NjkwOgooU3RyaXBwaW5nIHRyYWlsaW5nIENScyBmcm9tIHBhdGNo OyB1c2UgLS1iaW5hcnkgdG8gZGlzYWJsZS4pCnBhdGNoaW5nIGZpbGUgZHJpdmVycy9uZXQvdGFw L3J0ZV9ldGhfdGFwLmMKSHVuayAjMSBGQUlMRUQgYXQgMTEwOC4KMSBvdXQgb2YgMSBodW5rIEZB SUxFRCAtLSBzYXZpbmcgcmVqZWN0cyB0byBmaWxlIGRyaXZlcnMvbmV0L3RhcC9ydGVfZXRoX3Rh cC5jLnJlagoKUmVwbzogZHBkay1uZXh0LWV2ZW50ZGV2CjM4NjkwOgooU3RyaXBwaW5nIHRyYWls aW5nIENScyBmcm9tIHBhdGNoOyB1c2UgLS1iaW5hcnkgdG8gZGlzYWJsZS4pCnBhdGNoaW5nIGZp bGUgZHJpdmVycy9uZXQvdGFwL3J0ZV9ldGhfdGFwLmMKSHVuayAjMSBGQUlMRUQgYXQgMTEwOC4K MSBvdXQgb2YgMSBodW5rIEZBSUxFRCAtLSBzYXZpbmcgcmVqZWN0cyB0byBmaWxlIGRyaXZlcnMv bmV0L3RhcC9ydGVfZXRoX3RhcC5jLnJlagoKCkRQREsgU1RWIHRlYW0K --===============6284072778044560084==--