[dpdk-test-report] [PatchWork]|ERROR| pw15098 net/mlx5: Fix possible NULL deref in RX path

[dpdk-test-report] [PatchWork]|ERROR| pw15098 net/mlx5: Fix possible NULL deref in RX path

[sys_stv]

[-- Attachment #1: Type: text/plain, Size: 3539 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 15098
http://www.dpdk.org/dev/patchwork/patch/15098/
Submitter: Sagi Grimberg <sagi@grimberg.me>
Date: Tue, 2 Aug 2016 13:47:55 +0300
DPDK git baseline: b0a1419a88efebac3a1d52987b7e634848f9c85e

Check patch error:
15098: 
ERROR: patch seems to be corrupt (line wrapped?)
#67: FILE: :1586:
**pkts, uint16_t pkts_n)

WARNING: suspect code indent for conditional statements (16, 23)
#90: FILE: drivers/net/mlx5/mlx5_rxtx.c:1574:
                 if (unlikely(rep == NULL)) {
+                       ++rxq->stats.rx_nombuf;

ERROR: code indent should use tabs where possible
#91: FILE: drivers/net/mlx5/mlx5_rxtx.c:1575:
+                       ++rxq->stats.rx_nombuf;$

WARNING: please, no spaces at the start of a line
#91: FILE: drivers/net/mlx5/mlx5_rxtx.c:1575:
+                       ++rxq->stats.rx_nombuf;$

ERROR: code indent should use tabs where possible
#92: FILE: drivers/net/mlx5/mlx5_rxtx.c:1576:
+                       if (!pkt) {$

WARNING: please, no spaces at the start of a line
#92: FILE: drivers/net/mlx5/mlx5_rxtx.c:1576:
+                       if (!pkt) {$

WARNING: suspect code indent for conditional statements (23, 31)
#92: FILE: drivers/net/mlx5/mlx5_rxtx.c:1576:
+                       if (!pkt) {
+                               /*

ERROR: code indent should use tabs where possible
#93: FILE: drivers/net/mlx5/mlx5_rxtx.c:1577:
+                               /*$

ERROR: code indent should use tabs where possible
#94: FILE: drivers/net/mlx5/mlx5_rxtx.c:1578:
+                                * no buffers before we even started,$

WARNING: networking block comments don't use an empty /* line, use /* Comment...
#94: FILE: drivers/net/mlx5/mlx5_rxtx.c:1578:
+                               /*
+                                * no buffers before we even started,

ERROR: code indent should use tabs where possible
#95: FILE: drivers/net/mlx5/mlx5_rxtx.c:1579:
+                                * bail out silently.$

ERROR: code indent should use tabs where possible
#96: FILE: drivers/net/mlx5/mlx5_rxtx.c:1580:
+                                */$

ERROR: code indent should use tabs where possible
#97: FILE: drivers/net/mlx5/mlx5_rxtx.c:1581:
+                               break;$

WARNING: please, no spaces at the start of a line
#97: FILE: drivers/net/mlx5/mlx5_rxtx.c:1581:
+                               break;$

ERROR: code indent should use tabs where possible
#98: FILE: drivers/net/mlx5/mlx5_rxtx.c:1582:
+                       }$

WARNING: please, no spaces at the start of a line
#98: FILE: drivers/net/mlx5/mlx5_rxtx.c:1582:
+                       }$

ERROR: Missing Signed-off-by: line(s)

total: 10 errors, 7 warnings, 22 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

/home/patchWorkOrg/patches/dpdk-dev-net-mlx5-Fix-possible-NULL-deref-in-RX-path.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team