[dpdk-test-report] [PatchWork]|ERROR| pw15337-15339 crypto/zuc: add driver for ZUC library

[sys_stv@intel.com]

[-- Attachment #1: Type: text/plain, Size: 2612 bytes --]


Test-Label: Intel Niantic on Fedora
Test-Status: ERROR

Patchwork ID: 15337-15339
http://www.dpdk.org/dev/patchwork/patch/15339/
Submitter: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Fri, 26 Aug 2016 04:09:13 +0100
DPDK git baseline: e22856313fff2db12d8e132dad446bbf74cf29a5

Check patch error:
15337: 
WARNING: line over 80 characters
#339: FILE: drivers/crypto/zuc/rte_zuc_pmd.c:139:
+		memcpy(sess->pKey_cipher, xform->cipher.key.data, ZUC_IV_KEY_LENGTH);

WARNING: line over 80 characters
#348: FILE: drivers/crypto/zuc/rte_zuc_pmd.c:148:
+		memcpy(sess->pKey_hash, xform->auth.key.data, ZUC_IV_KEY_LENGTH);

WARNING: line over 80 characters
#400: FILE: drivers/crypto/zuc/rte_zuc_pmd.c:200:
+		if (unlikely(ops[i]->sym->cipher.iv.length != ZUC_IV_KEY_LENGTH)) {

WARNING: line over 80 characters
#448: FILE: drivers/crypto/zuc/rte_zuc_pmd.c:248:
+		if (unlikely(ops[i]->sym->auth.aad.length != ZUC_IV_KEY_LENGTH)) {

WARNING: line over 80 characters
#454: FILE: drivers/crypto/zuc/rte_zuc_pmd.c:254:
+		if (unlikely(ops[i]->sym->auth.digest.length != ZUC_DIGEST_LENGTH)) {

WARNING: line over 80 characters
#482: FILE: drivers/crypto/zuc/rte_zuc_pmd.c:282:
+				ops[i]->status = RTE_CRYPTO_OP_STATUS_AUTH_FAILED;

WARNING: quoted string split across lines
#735: FILE: drivers/crypto/zuc/rte_zuc_pmd.c:535:
+	RTE_LOG(INFO, PMD, "Closing ZUC crypto device %s"
+			" on numa socket %u
",

WARNING: quoted string split across lines
#957: FILE: drivers/crypto/zuc/rte_zuc_pmd_ops.c:203:
+			ZUC_LOG_INFO("Reusing existing ring %s"
+					" for processed packets",

WARNING: quoted string split across lines
#963: FILE: drivers/crypto/zuc/rte_zuc_pmd_ops.c:209:
+		ZUC_LOG_ERR("Unable to reuse existing ring %s"
+				" for processed packets",

ERROR: return is not a function, parentheses are not required
#988: FILE: drivers/crypto/zuc/rte_zuc_pmd_ops.c:234:
+		return (-ENOMEM);

total: 1 errors, 9 warnings, 1200 lines checked

/home/patchWorkOrg/patches/dpdk-dev-1-3-crypto-zuc-add-driver-for-ZUC-library.patch has style problems, please review.

If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.


Compilation:
OS: fedora
Nic: niantic
GCC: gcc_x86-64, 4.8.3
ICC:16.0.2
i686-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-combined: compile pass
i686-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-gcc: compile pass
x86_64-native-linuxapp-icc: compile pass
x86_64-native-linuxapp-gcc-debug: compile pass
x86_64-native-linuxapp-gcc-shared: compile pass
x86_64-native-linuxapp-clang: compile pass



DPDK STV team