[dpdk-test-report] |WARNING| [PATCH 5/7] test/eventdev: unit and functional tests

[checkpatch@dpdk.org]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17051

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#131: FILE: app/test/test_eventdev_func.c:70:
+	/*
+	* len = 14 + 46

WARNING:LONG_LINE: line over 90 characters
#192: FILE: app/test/test_eventdev_func.c:131:
+		printf("%d: Eventdev %s not found - quitting.
", __LINE__, eventdev_name);

WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#351: FILE: app/test/test_eventdev_func.c:290:
+	unsigned i;

ERROR:SPACING: space required before the open parenthesis '('
#352: FILE: app/test/test_eventdev_func.c:291:
+	for(i = 0; i < RTE_DIM(MAGIC_SEQN); i++) {

ERROR:SPACING: space required before the open parenthesis '('
#398: FILE: app/test/test_eventdev_func.c:337:
+	if(ev.mbuf->seqn != MAGIC_SEQN[1]) {

ERROR:SPACING: space required before the open parenthesis '('
#411: FILE: app/test/test_eventdev_func.c:350:
+	if(ev2.mbuf->seqn != MAGIC_SEQN[0]) {

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#537: FILE: app/test/test_eventdev_func.c:476:
+	 * iter 512 (the 513th pkt) is the first refused NEW packet */

ERROR:SPACING: space required before the open parenthesis '('
#547: FILE: app/test/test_eventdev_func.c:486:
+		if(i == THRES-1) {

ERROR:SPACING: space required before the open parenthesis '('
#548: FILE: app/test/test_eventdev_func.c:487:
+			if(err != -ENOSPC) {

WARNING:LONG_LINE: line over 90 characters
#549: FILE: app/test/test_eventdev_func.c:488:
+				printf("%d: overload trip didn't cause NEW pkt enq fail
", __LINE__);

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#552: FILE: app/test/test_eventdev_func.c:491:
+			}
+			else {

WARNING:LONG_LINE_COMMENT: line over 90 characters
#553: FILE: app/test/test_eventdev_func.c:492:
+				//printf("iter %d -ENOSPC returned for new enq as expected.
", i);

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#574: FILE: app/test/test_eventdev_func.c:513:
+		 * when enqueue is attempted in overload mode */

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#608: FILE: app/test/test_eventdev_func.c:547:
+	 * iter 512 (the 513th pkt) is the first refused NEW packet */

ERROR:SPACING: space required before the open parenthesis '('
#618: FILE: app/test/test_eventdev_func.c:557:
+		if(i == THRES-1) {

ERROR:SPACING: space required before the open parenthesis '('
#619: FILE: app/test/test_eventdev_func.c:558:
+			if(err != -ENOSPC) {

WARNING:LONG_LINE: line over 90 characters
#620: FILE: app/test/test_eventdev_func.c:559:
+				printf("%d: overload trip didn't cause NEW pkt enq fail
", __LINE__);

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#623: FILE: app/test/test_eventdev_func.c:562:
+			}
+			else {

WARNING:LONG_LINE_COMMENT: line over 90 characters
#624: FILE: app/test/test_eventdev_func.c:563:
+				//printf("iter %d -ENOSPC returned for new enq as expected.
", i);

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#651: FILE: app/test/test_eventdev_func.c:590:
+		 * when enqueue is attempted in overload mode */

WARNING:LONG_LINE_STRING: line over 90 characters
#656: FILE: app/test/test_eventdev_func.c:595:
+			printf("%d: warning failed to deq (iter = %d), ret %d. Dumping stats
",

ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#805: FILE: app/test/test_eventdev_func.c:744:
+			printf("%d: error generating pkt
" , __LINE__);
 			                                    ^

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(flows)
#910: FILE: app/test/test_eventdev_func.c:849:
+#define PKT_NUM (sizeof(flows) / sizeof(flows[0]))

ERROR:SPACING: space required before the open parenthesis '('
#974: FILE: app/test/test_eventdev_func.c:913:
+	for(i = 0; i < 4; i++) {

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(flows1)
#997: FILE: app/test/test_eventdev_func.c:936:
+#define PKT_NUM1 (sizeof(flows1) / sizeof(flows1[0]))

ERROR:SPACING: space required before the open parenthesis '('
#1105: FILE: app/test/test_eventdev_func.c:1044:
+			if(err != 1) {

ERROR:SPACING: space required before the open parenthesis '('
#1168: FILE: app/test/test_eventdev_func.c:1107:
+	for(i = 0; i < 8; i++) {

WARNING:LONG_LINE: line over 90 characters
#1211: FILE: app/test/test_eventdev_func.c:1150:
+				printf("%d: 
No schedules for seconds, deadlock
", __LINE__);

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1211: FILE: app/test/test_eventdev_func.c:1150:
+				printf("%d: 
No schedules for seconds, deadlock
", __LINE__);

WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#1319: FILE: app/test/test_eventdev_func.c:1258:
+		printf("### Not enough cores for worker loopback test. 
");

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1323: FILE: app/test/test_eventdev_func.c:1262:
+	 * in the static eventdev_func_mempool variable. It is re-used on re-runs */

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1432: FILE: app/test/test_eventdev_unit.c:97:
+		return 0;
+	} else {

WARNING:TYPO_SPELLING: 'aquisition' may be misspelled - perhaps 'acquisition'?
#1864: FILE: app/test/test_eventdev_unit.c:529:
+		/* device aquisition and config */

total: 13 errors, 20 warnings, 1825 lines checked