* [dpdk-test-report] |WARNING| [PATCH 7/7] examples/eventdev_pipeline: adding example
[not found] <1479319207-130646-8-git-send-email-harry.van.haaren@intel.com>
@ 2016-11-16 18:01 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-11-16 18:01 UTC (permalink / raw)
To: test-report; +Cc: Harry van Haaren
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17053
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#44:
as a reference application and for general testing. The application requires
WARNING:TYPO_SPELLING: 'overriden' may be misspelled - perhaps 'overridden'?
#111: FILE: examples/eventdev_pipeline/Makefile:35:
+# Default target, can be overriden by command line or environment
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#190: FILE: examples/eventdev_pipeline/main.c:59:
+ unsigned num_ports;
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#204: FILE: examples/eventdev_pipeline/main.c:73:
+static volatile int done = 0;
ERROR:INITIALISED_STATIC: do not initialise statics to 0
#205: FILE: examples/eventdev_pipeline/main.c:74:
+static int quiet = 0;
ERROR:SPACING: space required before the open brace '{'
#227: FILE: examples/eventdev_pipeline/main.c:96:
+ if (n == 0){
ERROR:SPACING: space required before the open parenthesis '('
#250: FILE: examples/eventdev_pipeline/main.c:119:
+ while(now + 750 > rte_rdtsc()) {}
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#250: FILE: examples/eventdev_pipeline/main.c:119:
+ while(now + 750 > rte_rdtsc()) {}
WARNING:BRACES: braces {} are not necessary for single statement blocks
#250: FILE: examples/eventdev_pipeline/main.c:119:
+ while(now + 750 > rte_rdtsc()) {}
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#307: FILE: examples/eventdev_pipeline/main.c:176:
+ unsigned i;
ERROR:SPACING: space required before the open brace '{'
#326: FILE: examples/eventdev_pipeline/main.c:195:
+ if (n == 0){
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#369: FILE: examples/eventdev_pipeline/main.c:238:
+ unsigned i;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#379: FILE: examples/eventdev_pipeline/main.c:248:
+ unsigned num_ports = data->num_ports;
ERROR:POINTER_LOCATION: "foo** bar" should be "foo **bar"
#467: FILE: examples/eventdev_pipeline/main.c:336:
+parse_app_args(int argc, char** argv)
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#480: FILE: examples/eventdev_pipeline/main.c:349:
+ switch (c) {
+ case 'w':
[...]
+ case 'n':
[...]
+ case 'f':
[...]
+ case 'p':
[...]
+ case 'o':
[...]
+ case 'q':
[...]
+ default:
ERROR:SPACING: space prohibited before that close parenthesis ')'
#485: FILE: examples/eventdev_pipeline/main.c:354:
+ num_packets = (unsigned long )atol(optarg);
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#557: FILE: examples/eventdev_pipeline/main.c:426:
+ (unsigned)port,
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#569: FILE: examples/eventdev_pipeline/main.c:438:
+init_ports(unsigned num_ports)
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#601: FILE: examples/eventdev_pipeline/main.c:470:
+ unsigned i;
WARNING:LONG_LINE: line over 90 characters
#667: FILE: examples/eventdev_pipeline/main.c:536:
+ ret = rte_event_port_setup(id, worker_data[i].event_port_id, &port_config);
ERROR:SPACING: space required before the open parenthesis '('
#722: FILE: examples/eventdev_pipeline/main.c:591:
+ if(sig == SIGTSTP) {
ERROR:SPACING: space required before the open parenthesis '('
#727: FILE: examples/eventdev_pipeline/main.c:596:
+ if(sig == SIGINT)
ERROR:SPACING: space prohibited before that ',' (ctx:WxW)
#734: FILE: examples/eventdev_pipeline/main.c:603:
+ signal(SIGINT , sighndlr);
^
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#740: FILE: examples/eventdev_pipeline/main.c:609:
+ unsigned nworkers = 0;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#741: FILE: examples/eventdev_pipeline/main.c:610:
+ unsigned num_ports;
WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#776: FILE: examples/eventdev_pipeline/main.c:645:
+ const unsigned cores_needed = num_workers +
WARNING:LONG_LINE: line over 90 characters
#820: FILE: examples/eventdev_pipeline/main.c:689:
+ err = rte_eal_remote_launch(worker, &worker_data[nworkers], lcore_id);
total: 12 errors, 15 warnings, 767 lines checked
^ permalink raw reply [flat|nested] only message in thread