From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| [PATCH 01/56] net/sfc: libefx-based PMD stub sufficient to build and init
Date: Mon, 21 Nov 2016 16:02:38 +0100 (CET) [thread overview]
Message-ID: <20161121150238.BB63A6893@dpdk.org> (raw)
In-Reply-To: <1479740470-6723-2-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17111
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#824: FILE: drivers/net/sfc/efx/sfc_kvargs.c:53:
+ return EINVAL;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#989: FILE: drivers/net/sfc/efx/sfc_log.h:40:
+ RTE_FMT("sfc_efx " PCI_PRI_FMT " #%" PRIu8 ": " \
ERROR:SPACING: space required after that ',' (ctx:VxB)
#990: FILE: drivers/net/sfc/efx/sfc_log.h:41:
+ RTE_FMT_HEAD(__VA_ARGS__,) "
", \
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#996: FILE: drivers/net/sfc/efx/sfc_log.h:47:
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
^
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sa' - possible side-effects?
#1011: FILE: drivers/net/sfc/efx/sfc_log.h:62:
+#define sfc_log_init(sa, ...) \
+ do { \
+ if (sa->debug_init) \
+ SFC_LOG(sa, INFO, \
+ RTE_FMT("%s(): " \
+ RTE_FMT_HEAD(__VA_ARGS__,), \
+ __func__, \
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'sa' may be better as '(sa)' to avoid precedence issues
#1011: FILE: drivers/net/sfc/efx/sfc_log.h:62:
+#define sfc_log_init(sa, ...) \
+ do { \
+ if (sa->debug_init) \
+ SFC_LOG(sa, INFO, \
+ RTE_FMT("%s(): " \
+ RTE_FMT_HEAD(__VA_ARGS__,), \
+ __func__, \
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
+ } while (0)
ERROR:SPACING: space required after that ',' (ctx:VxB)
#1016: FILE: drivers/net/sfc/efx/sfc_log.h:67:
+ RTE_FMT_HEAD(__VA_ARGS__,), \
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#1018: FILE: drivers/net/sfc/efx/sfc_log.h:69:
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
^
total: 4 errors, 1 warnings, 795 lines checked
parent reply other threads:[~2016-11-21 15:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1479740470-6723-2-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121150238.BB63A6893@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).