From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BB63A6893; Mon, 21 Nov 2016 16:02:38 +0100 (CET)
In-Reply-To: <1479740470-6723-2-git-send-email-arybchenko@solarflare.com>
References: <1479740470-6723-2-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20161121150238.BB63A6893@dpdk.org>
Date: Mon, 21 Nov 2016 16:02:38 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| [PATCH 01/56] net/sfc: libefx-based
	PMD stub sufficient to build and init
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Nov 2016 15:02:39 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17111

_coding style issues_


WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#824: FILE: drivers/net/sfc/efx/sfc_kvargs.c:53:
+		return EINVAL;

CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#989: FILE: drivers/net/sfc/efx/sfc_log.h:40:
+			RTE_FMT("sfc_efx " PCI_PRI_FMT " #%" PRIu8 ": "	\

ERROR:SPACING: space required after that ',' (ctx:VxB)
#990: FILE: drivers/net/sfc/efx/sfc_log.h:41:
+				RTE_FMT_HEAD(__VA_ARGS__,) "
",	\
 				                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#996: FILE: drivers/net/sfc/efx/sfc_log.h:47:
+				RTE_FMT_TAIL(__VA_ARGS__,)));		\
 				                        ^

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sa' - possible side-effects?
#1011: FILE: drivers/net/sfc/efx/sfc_log.h:62:
+#define	sfc_log_init(sa, ...) \
+	do {								\
+		if (sa->debug_init)					\
+			SFC_LOG(sa, INFO,				\
+				RTE_FMT("%s(): "			\
+					RTE_FMT_HEAD(__VA_ARGS__,),	\
+					__func__,			\
+					RTE_FMT_TAIL(__VA_ARGS__,)));	\
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'sa' may be better as '(sa)' to avoid precedence issues
#1011: FILE: drivers/net/sfc/efx/sfc_log.h:62:
+#define	sfc_log_init(sa, ...) \
+	do {								\
+		if (sa->debug_init)					\
+			SFC_LOG(sa, INFO,				\
+				RTE_FMT("%s(): "			\
+					RTE_FMT_HEAD(__VA_ARGS__,),	\
+					__func__,			\
+					RTE_FMT_TAIL(__VA_ARGS__,)));	\
+	} while (0)

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1016: FILE: drivers/net/sfc/efx/sfc_log.h:67:
+					RTE_FMT_HEAD(__VA_ARGS__,),	\
 					                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#1018: FILE: drivers/net/sfc/efx/sfc_log.h:69:
+					RTE_FMT_TAIL(__VA_ARGS__,)));	\
 					                        ^

total: 4 errors, 1 warnings, 795 lines checked