* [dpdk-test-report] |WARNING| [PATCH 01/56] net/sfc: libefx-based PMD stub sufficient to build and init
[not found] <1479740470-6723-2-git-send-email-arybchenko@solarflare.com>
@ 2016-11-21 15:02 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-11-21 15:02 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17111
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL)
#824: FILE: drivers/net/sfc/efx/sfc_kvargs.c:53:
+ return EINVAL;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#989: FILE: drivers/net/sfc/efx/sfc_log.h:40:
+ RTE_FMT("sfc_efx " PCI_PRI_FMT " #%" PRIu8 ": " \
ERROR:SPACING: space required after that ',' (ctx:VxB)
#990: FILE: drivers/net/sfc/efx/sfc_log.h:41:
+ RTE_FMT_HEAD(__VA_ARGS__,) "
", \
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#996: FILE: drivers/net/sfc/efx/sfc_log.h:47:
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
^
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sa' - possible side-effects?
#1011: FILE: drivers/net/sfc/efx/sfc_log.h:62:
+#define sfc_log_init(sa, ...) \
+ do { \
+ if (sa->debug_init) \
+ SFC_LOG(sa, INFO, \
+ RTE_FMT("%s(): " \
+ RTE_FMT_HEAD(__VA_ARGS__,), \
+ __func__, \
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
+ } while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'sa' may be better as '(sa)' to avoid precedence issues
#1011: FILE: drivers/net/sfc/efx/sfc_log.h:62:
+#define sfc_log_init(sa, ...) \
+ do { \
+ if (sa->debug_init) \
+ SFC_LOG(sa, INFO, \
+ RTE_FMT("%s(): " \
+ RTE_FMT_HEAD(__VA_ARGS__,), \
+ __func__, \
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
+ } while (0)
ERROR:SPACING: space required after that ',' (ctx:VxB)
#1016: FILE: drivers/net/sfc/efx/sfc_log.h:67:
+ RTE_FMT_HEAD(__VA_ARGS__,), \
^
ERROR:SPACING: space required after that ',' (ctx:VxB)
#1018: FILE: drivers/net/sfc/efx/sfc_log.h:69:
+ RTE_FMT_TAIL(__VA_ARGS__,))); \
^
total: 4 errors, 1 warnings, 795 lines checked
^ permalink raw reply [flat|nested] only message in thread