* [dpdk-test-report] |WARNING| [PATCH 11/56] net/sfc: import libefx SFN8xxx family support
[not found] <1479740470-6723-12-git-send-email-arybchenko@solarflare.com>
@ 2016-11-21 15:02 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-11-21 15:02 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17112
_coding style issues_
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#238: FILE: drivers/net/sfc/efx/base/efx_nic.c:84:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#242: FILE: drivers/net/sfc/efx/base/efx_nic.c:88:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#246: FILE: drivers/net/sfc/efx/base/efx_nic.c:92:
+ return (0);
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#445: FILE: drivers/net/sfc/efx/base/medford_impl.h:58:
+extern __checkReturn efx_rc_t
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#508: FILE: drivers/net/sfc/efx/base/medford_nic.c:48:
+ memset(payload, 0, sizeof (payload));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#545: FILE: drivers/net/sfc/efx/base/medford_nic.c:85:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#552: FILE: drivers/net/sfc/efx/base/medford_nic.c:92:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#565: FILE: drivers/net/sfc/efx/base/medford_nic.c:105:
+ if ((rc = efx_mcdi_get_port_modes(enp, &port_modes,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#572: FILE: drivers/net/sfc/efx/base/medford_nic.c:112:
+ if ((rc = ef10_nic_get_port_mode_bandwidth(current_mode,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#579: FILE: drivers/net/sfc/efx/base/medford_nic.c:119:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#584: FILE: drivers/net/sfc/efx/base/medford_nic.c:124:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip
#591: FILE: drivers/net/sfc/efx/base/medford_nic.c:131:
+ efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#592: FILE: drivers/net/sfc/efx/base/medford_nic.c:132:
+ efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#596: FILE: drivers/net/sfc/efx/base/medford_nic.c:136:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#612: FILE: drivers/net/sfc/efx/base/medford_nic.c:152:
+ if ((rc = efx_mcdi_get_port_assignment(enp, &port)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#621: FILE: drivers/net/sfc/efx/base/medford_nic.c:161:
+ if ((rc = ef10_external_port_mapping(enp, port,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#631: FILE: drivers/net/sfc/efx/base/medford_nic.c:171:
+ if ((rc = efx_mcdi_get_function_info(enp, &pf, &vf)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#678: FILE: drivers/net/sfc/efx/base/medford_nic.c:218:
+ if ((rc = efx_mcdi_get_phy_cfg(enp)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#682: FILE: drivers/net/sfc/efx/base/medford_nic.c:222:
+ if ((rc = ef10_phy_get_link(enp, &els)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#730: FILE: drivers/net/sfc/efx/base/medford_nic.c:270:
+ if ((rc = efx_mcdi_get_clock(enp, &sysclk, &dpcpu_clk)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#742: FILE: drivers/net/sfc/efx/base/medford_nic.c:282:
+ if ((rc = ef10_get_datapath_caps(enp)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#749: FILE: drivers/net/sfc/efx/base/medford_nic.c:289:
+ if ((rc = efx_mcdi_get_rxdp_config(enp, &end_padding)) != 0) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#790: FILE: drivers/net/sfc/efx/base/medford_nic.c:330:
+ if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0)
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#795: FILE: drivers/net/sfc/efx/base/medford_nic.c:335:
+ if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#824: FILE: drivers/net/sfc/efx/base/medford_nic.c:364:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#855: FILE: drivers/net/sfc/efx/base/medford_nic.c:395:
+ return (rc);
total: 21 errors, 1 warnings, 4 checks, 694 lines checked
^ permalink raw reply [flat|nested] only message in thread