From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| [PATCH 13/56] net/sfc: import libefx built-in selftest support
Date: Mon, 21 Nov 2016 16:02:42 +0100 (CET) [thread overview]
Message-ID: <20161121150242.978AD6CB3@dpdk.org> (raw)
In-Reply-To: <1479740470-6723-14-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17113
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#90: FILE: drivers/net/sfc/efx/base/ef10_impl.h:350:
+extern __checkReturn efx_rc_t
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#136: FILE: drivers/net/sfc/efx/base/ef10_phy.c:401:
+ if ((rc = efx_mcdi_bist_enable_offline(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#139: FILE: drivers/net/sfc/efx/base/ef10_phy.c:404:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#144: FILE: drivers/net/sfc/efx/base/ef10_phy.c:409:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#154: FILE: drivers/net/sfc/efx/base/ef10_phy.c:419:
+ if ((rc = efx_mcdi_bist_start(enp, type)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#157: FILE: drivers/net/sfc/efx/base/ef10_phy.c:422:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#162: FILE: drivers/net/sfc/efx/base/ef10_phy.c:427:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#176: FILE: drivers/net/sfc/efx/base/ef10_phy.c:441:
+ efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
CHECK:SPACING: No space is necessary after a cast
#186: FILE: drivers/net/sfc/efx/base/ef10_phy.c:451:
+ (void) memset(payload, 0, sizeof (payload));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#186: FILE: drivers/net/sfc/efx/base/ef10_phy.c:451:
+ (void) memset(payload, 0, sizeof (payload));
CHECK:SPACING: No space is necessary after a cast
#206: FILE: drivers/net/sfc/efx/base/ef10_phy.c:471:
+ (void) memset(valuesp, '
parent reply other threads:[~2016-11-21 15:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1479740470-6723-14-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121150242.978AD6CB3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).