From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| [PATCH 12/56] net/sfc: import libefx diagnostics support
Date: Mon, 21 Nov 2016 16:02:48 +0100 (CET) [thread overview]
Message-ID: <20161121150248.DCA64D4A6@dpdk.org> (raw)
In-Reply-To: <1479740470-6723-13-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17115
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#89: FILE: drivers/net/sfc/efx/base/ef10_impl.h:197:
+extern __checkReturn efx_rc_t
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#123: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1785:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#128: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1790:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#302: FILE: drivers/net/sfc/efx/base/efx_nic.c:632:
+ if ((rc = enop->eno_register_test(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#305: FILE: drivers/net/sfc/efx/base/efx_nic.c:635:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#310: FILE: drivers/net/sfc/efx/base/efx_nic.c:640:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#348: FILE: drivers/net/sfc/efx/base/efx_nic.c:678:
+ if (memcmp(®, &buf, sizeof (reg))) {
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#363: FILE: drivers/net/sfc/efx/base/efx_nic.c:693:
+ if (memcmp(®, &buf, sizeof (reg))) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#377: FILE: drivers/net/sfc/efx/base/efx_nic.c:707:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#387: FILE: drivers/net/sfc/efx/base/efx_nic.c:717:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#426: FILE: drivers/net/sfc/efx/base/efx_nic.c:756:
+ if (memcmp(®, &buf, sizeof (reg))) {
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#438: FILE: drivers/net/sfc/efx/base/efx_nic.c:768:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#443: FILE: drivers/net/sfc/efx/base/efx_nic.c:773:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#472: FILE: drivers/net/sfc/efx/base/efx_sram.c:214:
+ for (index = 0; index < sizeof (efx_qword_t); index++)
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#525: FILE: drivers/net/sfc/efx/base/efx_sram.c:267:
+ for (index = 0; index < sizeof (efx_qword_t); index++) {
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#547: FILE: drivers/net/sfc/efx/base/efx_sram.c:289:
+ EFX_CLEAR_QWORD_BIT(*eqp, (offset / sizeof (efx_qword_t)) % 64);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#550: FILE: drivers/net/sfc/efx/base/efx_sram.c:292:
+ EFX_SET_QWORD_BIT(*eqp, (offset / sizeof (efx_qword_t)) % 64);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#580: FILE: drivers/net/sfc/efx/base/efx_sram.c:322:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#586: FILE: drivers/net/sfc/efx/base/efx_sram.c:328:
+ return (siena_sram_test(enp, func));
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#731: FILE: drivers/net/sfc/efx/base/siena_nic.c:455:
+ if ((rc = efx_nic_test_registers(enp, __siena_registers,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#735: FILE: drivers/net/sfc/efx/base/siena_nic.c:459:
+ if ((rc = efx_nic_test_tables(enp, __siena_tables,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#740: FILE: drivers/net/sfc/efx/base/siena_nic.c:464:
+ if ((rc = efx_nic_test_tables(enp, __siena_tables,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#745: FILE: drivers/net/sfc/efx/base/siena_nic.c:469:
+ if ((rc = efx_nic_test_tables(enp, __siena_tables,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#749: FILE: drivers/net/sfc/efx/base/siena_nic.c:473:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#760: FILE: drivers/net/sfc/efx/base/siena_nic.c:484:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#862: FILE: drivers/net/sfc/efx/base/siena_sram.c:162:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#873: FILE: drivers/net/sfc/efx/base/siena_sram.c:173:
+ return (rc);
total: 19 errors, 7 warnings, 1 checks, 744 lines checked
parent reply other threads:[~2016-11-21 15:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1479740470-6723-13-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121150248.DCA64D4A6@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).