From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id DCA64D4A6; Mon, 21 Nov 2016 16:02:48 +0100 (CET) In-Reply-To: <1479740470-6723-13-git-send-email-arybchenko@solarflare.com> References: <1479740470-6723-13-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161121150248.DCA64D4A6@dpdk.org> Date: Mon, 21 Nov 2016 16:02:48 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH 12/56] net/sfc: import libefx diagnostics support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 15:02:49 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17115 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #89: FILE: drivers/net/sfc/efx/base/ef10_impl.h:197: +extern __checkReturn efx_rc_t ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #123: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1785: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #128: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1790: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #302: FILE: drivers/net/sfc/efx/base/efx_nic.c:632: + if ((rc = enop->eno_register_test(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #305: FILE: drivers/net/sfc/efx/base/efx_nic.c:635: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #310: FILE: drivers/net/sfc/efx/base/efx_nic.c:640: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #348: FILE: drivers/net/sfc/efx/base/efx_nic.c:678: + if (memcmp(®, &buf, sizeof (reg))) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #363: FILE: drivers/net/sfc/efx/base/efx_nic.c:693: + if (memcmp(®, &buf, sizeof (reg))) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #377: FILE: drivers/net/sfc/efx/base/efx_nic.c:707: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #387: FILE: drivers/net/sfc/efx/base/efx_nic.c:717: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #426: FILE: drivers/net/sfc/efx/base/efx_nic.c:756: + if (memcmp(®, &buf, sizeof (reg))) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #438: FILE: drivers/net/sfc/efx/base/efx_nic.c:768: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #443: FILE: drivers/net/sfc/efx/base/efx_nic.c:773: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #472: FILE: drivers/net/sfc/efx/base/efx_sram.c:214: + for (index = 0; index < sizeof (efx_qword_t); index++) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #525: FILE: drivers/net/sfc/efx/base/efx_sram.c:267: + for (index = 0; index < sizeof (efx_qword_t); index++) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #547: FILE: drivers/net/sfc/efx/base/efx_sram.c:289: + EFX_CLEAR_QWORD_BIT(*eqp, (offset / sizeof (efx_qword_t)) % 64); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #550: FILE: drivers/net/sfc/efx/base/efx_sram.c:292: + EFX_SET_QWORD_BIT(*eqp, (offset / sizeof (efx_qword_t)) % 64); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #580: FILE: drivers/net/sfc/efx/base/efx_sram.c:322: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #586: FILE: drivers/net/sfc/efx/base/efx_sram.c:328: + return (siena_sram_test(enp, func)); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #731: FILE: drivers/net/sfc/efx/base/siena_nic.c:455: + if ((rc = efx_nic_test_registers(enp, __siena_registers, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #735: FILE: drivers/net/sfc/efx/base/siena_nic.c:459: + if ((rc = efx_nic_test_tables(enp, __siena_tables, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #740: FILE: drivers/net/sfc/efx/base/siena_nic.c:464: + if ((rc = efx_nic_test_tables(enp, __siena_tables, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #745: FILE: drivers/net/sfc/efx/base/siena_nic.c:469: + if ((rc = efx_nic_test_tables(enp, __siena_tables, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #749: FILE: drivers/net/sfc/efx/base/siena_nic.c:473: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #760: FILE: drivers/net/sfc/efx/base/siena_nic.c:484: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #862: FILE: drivers/net/sfc/efx/base/siena_sram.c:162: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #873: FILE: drivers/net/sfc/efx/base/siena_sram.c:173: + return (rc); total: 19 errors, 7 warnings, 1 checks, 744 lines checked