From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| [PATCH 23/56] net/sfc: import libefx monitors statistics support
Date: Mon, 21 Nov 2016 16:02:58 +0100 (CET) [thread overview]
Message-ID: <20161121150258.A115DD4D8@dpdk.org> (raw)
In-Reply-To: <1479740470-6723-24-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17121
_coding style issues_
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#101: FILE: drivers/net/sfc/efx/base/ef10_ev.c:1097:
+ if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#124: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1386:
+ if ((rc = mcdi_mon_cfg_build(enp)) != 0) {
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#271: FILE: drivers/net/sfc/efx/base/efx.h:729:
+extern __checkReturn efx_rc_t
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#372: FILE: drivers/net/sfc/efx/base/efx_ev.c:1135:
+ if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0)
CHECK:BRACES: braces {} should be used on all arms of this statement
#372: FILE: drivers/net/sfc/efx/base/efx_ev.c:1135:
+ if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0)
[...]
+ else if (rc == ENOTSUP) {
[...]
+ } else
[...]
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#505: FILE: drivers/net/sfc/efx/base/efx_mon.c:199:
+ return (__mon_stat_name[id]);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mon
#516: FILE: drivers/net/sfc/efx/base/efx_mon.c:210:
+ efx_mon_t *emp = &(enp->en_mon);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#522: FILE: drivers/net/sfc/efx/base/efx_mon.c:216:
+ return (emop->emo_stats_update(enp, esmp, values));
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#539: FILE: drivers/net/sfc/efx/base/siena_nic.c:225:
+ if ((rc = mcdi_mon_cfg_build(enp)) != 0)
total: 6 errors, 0 warnings, 3 checks, 439 lines checked
parent reply other threads:[~2016-11-21 15:02 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1479740470-6723-24-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161121150258.A115DD4D8@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).