From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id A115DD4D8; Mon, 21 Nov 2016 16:02:58 +0100 (CET)
In-Reply-To: <1479740470-6723-24-git-send-email-arybchenko@solarflare.com>
References: <1479740470-6723-24-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20161121150258.A115DD4D8@dpdk.org>
Date: Mon, 21 Nov 2016 16:02:58 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| [PATCH 23/56] net/sfc: import libefx
	monitors statistics support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Nov 2016 15:02:59 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17121

_coding style issues_


ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#101: FILE: drivers/net/sfc/efx/base/ef10_ev.c:1097:
+		if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0) {

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#124: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1386:
+	if ((rc = mcdi_mon_cfg_build(enp)) != 0) {

CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#271: FILE: drivers/net/sfc/efx/base/efx.h:729:
+extern	__checkReturn			efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#372: FILE: drivers/net/sfc/efx/base/efx_ev.c:1135:
+		if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0)

CHECK:BRACES: braces {} should be used on all arms of this statement
#372: FILE: drivers/net/sfc/efx/base/efx_ev.c:1135:
+		if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0)
[...]
+		else if (rc == ENOTSUP) {
[...]
+		} else
[...]

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#505: FILE: drivers/net/sfc/efx/base/efx_mon.c:199:
+	return (__mon_stat_name[id]);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mon
#516: FILE: drivers/net/sfc/efx/base/efx_mon.c:210:
+	efx_mon_t *emp = &(enp->en_mon);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#522: FILE: drivers/net/sfc/efx/base/efx_mon.c:216:
+	return (emop->emo_stats_update(enp, esmp, values));

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#539: FILE: drivers/net/sfc/efx/base/siena_nic.c:225:
+	if ((rc = mcdi_mon_cfg_build(enp)) != 0)

total: 6 errors, 0 warnings, 3 checks, 439 lines checked