* [dpdk-test-report] |WARNING| [PATCH 22/56] net/sfc: import libefx loopback control support
[not found] <1479740470-6723-23-git-send-email-arybchenko@solarflare.com>
@ 2016-11-21 15:12 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-11-21 15:12 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17134
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#95: FILE: drivers/net/sfc/efx/base/ef10_impl.h:264:
+extern __checkReturn efx_rc_t
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#132: FILE: drivers/net/sfc/efx/base/ef10_mac.c:454:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#144: FILE: drivers/net/sfc/efx/base/ef10_mac.c:466:
+ if ((rc = epop->epo_reconfigure(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#147: FILE: drivers/net/sfc/efx/base/ef10_mac.c:469:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#155: FILE: drivers/net/sfc/efx/base/ef10_mac.c:477:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#172: FILE: drivers/net/sfc/efx/base/ef10_nic.c:1381:
+ if ((rc = efx_mcdi_get_loopback_modes(enp)) != 0)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#545: FILE: drivers/net/sfc/efx/base/efx_nic.c:886:
+ efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
CHECK:SPACING: No space is necessary after a cast
#553: FILE: drivers/net/sfc/efx/base/efx_nic.c:894:
+ (void) memset(payload, 0, sizeof (payload));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#553: FILE: drivers/net/sfc/efx/base/efx_nic.c:894:
+ (void) memset(payload, 0, sizeof (payload));
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#613: FILE: drivers/net/sfc/efx/base/efx_nic.c:954:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#620: FILE: drivers/net/sfc/efx/base/efx_nic.c:961:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#644: FILE: drivers/net/sfc/efx/base/efx_port.c:136:
+ efx_port_t *epp = &(enp->en_port);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#645: FILE: drivers/net/sfc/efx/base/efx_port.c:137:
+ efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#663: FILE: drivers/net/sfc/efx/base/efx_port.c:155:
+ return (0);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#665: FILE: drivers/net/sfc/efx/base/efx_port.c:157:
+ if ((rc = emop->emo_loopback_set(enp, link_mode, loopback_type)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#668: FILE: drivers/net/sfc/efx/base/efx_port.c:160:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#675: FILE: drivers/net/sfc/efx/base/efx_port.c:167:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#730: FILE: drivers/net/sfc/efx/base/efx_port.c:222:
+ return (__efx_loopback_type_name[type]);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#787: FILE: drivers/net/sfc/efx/base/siena_mac.c:205:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#799: FILE: drivers/net/sfc/efx/base/siena_mac.c:217:
+ if ((rc = epop->epo_reconfigure(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#802: FILE: drivers/net/sfc/efx/base/siena_mac.c:220:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#810: FILE: drivers/net/sfc/efx/base/siena_mac.c:228:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#827: FILE: drivers/net/sfc/efx/base/siena_nic.c:220:
+ if ((rc = efx_mcdi_get_loopback_modes(enp)) != 0)
total: 15 errors, 1 warnings, 7 checks, 737 lines checked
^ permalink raw reply [flat|nested] only message in thread