From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 0C5BFD4BC; Mon, 21 Nov 2016 16:14:38 +0100 (CET) In-Reply-To: <1479740470-6723-27-git-send-email-arybchenko@solarflare.com> References: <1479740470-6723-27-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161121151438.0C5BFD4BC@dpdk.org> Date: Mon, 21 Nov 2016 16:14:38 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH 26/56] net/sfc: import libefx NVRAM support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Nov 2016 15:14:38 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17140 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #95: FILE: drivers/net/sfc/efx/base/ef10_impl.h:344: +extern __checkReturn efx_rc_t ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #408: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:85: + return (tag); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #418: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:95: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #423: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:100: + return ((size_t)length); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #431: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:108: + return (NULL); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #441: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:118: + return (NULL); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #451: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:128: + (1 + 1 + (((length) + sizeof (uint32_t) - 1) / sizeof (uint32_t))) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #451: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:128: + (1 + 1 + (((length) + sizeof (uint32_t) - 1) / sizeof (uint32_t))) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #471: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:148: + if ((rc = tlv_validate_state(cursor)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #484: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:161: + if ((rc = tlv_validate_state(cursor)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #487: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:164: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #496: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:173: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #507: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:184: + if ((rc = tlv_validate_state(cursor)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #510: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:187: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #515: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:192: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #532: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:209: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #567: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:244: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #578: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:255: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #594: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:271: + return (tlv_validate_state(cursor)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #605: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:282: + limit = (uint32_t *)(block + size - sizeof (uint32_t)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #620: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:297: + limit = (uint32_t *)(block + size - sizeof (uint32_t)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #622: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:299: + return (tlv_init_cursor(cursor, (uint32_t *)block, limit, current)); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #634: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:311: + if ((rc = tlv_find(cursor, TLV_TAG_END)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #641: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:318: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #646: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:323: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #655: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:332: + if ((rc = tlv_validate_state(cursor)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #658: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:335: + if ((rc = tlv_require_end(cursor)) != 0) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #662: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:339: + return (cursor->end + 1 - cursor->block) * sizeof (uint32_t); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #669: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:346: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #695: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:372: + return (last_segment_end); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #715: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:392: + ptr[(len - 1) / sizeof (uint32_t)] = 0; WARNING:SPACING: space prohibited between function name and open parenthesis '(' #717: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:394: + ptr += P2ROUNDUP(len, sizeof (uint32_t)) / sizeof (*ptr); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #717: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:394: + ptr += P2ROUNDUP(len, sizeof (uint32_t)) / sizeof (*ptr); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #720: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:397: + return (ptr); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #735: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:412: + if ((rc = tlv_validate_state(cursor)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #738: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:415: + if ((rc = tlv_require_end(cursor)) != 0) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #756: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:433: + (last_segment_end + 1 - cursor->current) * sizeof (uint32_t)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #764: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:441: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #775: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:452: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #786: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:463: + if ((rc = tlv_validate_state(cursor)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #796: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:473: + if ((rc = tlv_require_end(cursor)) != 0) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #803: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:480: + (last_segment_end + 1 - cursor->current) * sizeof (uint32_t)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #805: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:482: + memset(last_segment_end + 1 - delta, 0, delta * sizeof (uint32_t)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #809: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:486: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #818: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:495: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #836: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:513: + if ((rc = tlv_validate_state(cursor)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #851: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:528: + if ((rc = tlv_require_end(cursor)) != 0) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #868: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:545: + (last_segment_end + 1 - pos) * sizeof (uint32_t)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #880: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:557: + (last_segment_end + 1 - pos) * sizeof (uint32_t)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #884: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:561: + delta * sizeof (uint32_t)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #893: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:570: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #906: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:583: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #929: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:606: + return (csum); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #948: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:625: + memcpy(&partition.tlv_cursor, cursor, sizeof (*cursor)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #966: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:643: + new_len - sizeof (*trailer) - sizeof (uint32_t)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #966: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:643: + new_len - sizeof (*trailer) - sizeof (uint32_t)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #972: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:649: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #979: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:656: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #998: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:675: + EFX_STATIC_ASSERT(sizeof (*header) <= EF10_NVRAM_CHUNK); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1006: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:683: + if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)partn_data, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1025: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:702: + if ((rc = tlv_find(&cursor, TLV_TAG_PARTITION_TRAILER)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1031: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:708: + if ((rc = tlv_advance(&cursor)) != 0) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1048: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:725: + for (pos = 0; (size_t)pos < total_length; pos += sizeof (uint32_t)) { WARNING:BRACES: braces {} are not necessary for single statement blocks #1048: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:725: + for (pos = 0; (size_t)pos < total_length; pos += sizeof (uint32_t)) { + cksum += *((uint32_t *)(partn_data + pos)); + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1056: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:733: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1077: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:754: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1095: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:772: + unsigned int min_buf_size = sizeof (struct tlv_partition_header) + WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1096: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:773: + sizeof (struct tlv_partition_trailer); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1105: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:782: + if ((rc = tlv_init_cursor(&cursor, buf, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1112: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:789: + header.length = __CPU_TO_LE_32(sizeof (header) - 8); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1117: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:794: + if ((rc = tlv_insert( WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1119: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:796: + (uint8_t *)&header.type_id, sizeof (header) - 8)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1121: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:798: + if ((rc = tlv_advance(&cursor)) != 0) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1125: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:802: + trailer.length = __CPU_TO_LE_32(sizeof (trailer) - 8); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1128: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:805: + if ((rc = tlv_insert(&cursor, TLV_TAG_PARTITION_TRAILER, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1129: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:806: + (uint8_t *)&trailer.generation, sizeof (trailer) - 8)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1132: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:809: + if ((rc = tlv_update_partition_len_and_cks(&cursor)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1136: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:813: + if ((rc = ef10_nvram_buffer_validate(enp, partn_type, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1140: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:817: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1157: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:834: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1180: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:857: + if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)bufferp, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1190: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:867: + if ((rc = tlv_advance(&cursor)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1196: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:873: + if ((rc = tlv_require_end(&cursor)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1199: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:876: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1210: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:887: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1228: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:905: + if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)bufferp, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1258: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:935: + *endp = (segment_used - cursor.block) * sizeof (uint32_t); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1260: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:937: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1267: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:944: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1286: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:963: + return (B_FALSE); WARNING:BRACES: braces {} are not necessary for single statement blocks #1293: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:970: + if (tlv_advance(&cursor) != 0) { + break; + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1301: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:978: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1304: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:981: + return (B_FALSE); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1328: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1005: + if ((rc = tlv_init_cursor_at_offset(&cursor, (uint8_t *)bufferp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1342: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1019: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1351: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1028: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1367: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1044: + if ((rc = tlv_init_cursor_at_offset(&cursor, (uint8_t *)bufferp, WARNING:BRACES: braces {} are not necessary for single statement blocks #1374: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1051: + if (rc != 0) { + goto fail2; + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1381: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1058: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1388: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1065: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1405: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1082: + if ((rc = tlv_init_cursor_at_offset(&cursor, (uint8_t *)bufferp, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1410: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1087: + if ((rc = tlv_delete(&cursor)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1413: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1090: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1420: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1097: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1432: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1109: + if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)bufferp, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1438: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1115: + if ((rc = tlv_require_end(&cursor)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1441: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1118: + if ((rc = tlv_update_partition_len_and_cks(&cursor)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1444: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1121: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1453: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1130: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1480: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1157: + EFX_STATIC_ASSERT(sizeof (*header) <= EF10_NVRAM_CHUNK); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1488: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1165: + if ((rc = ef10_nvram_partn_read_mode(enp, partn, seg_offset, seg_data, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1495: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1172: + if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)seg_data, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1515: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1192: + if ((rc = ef10_nvram_partn_read_mode(enp, partn, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1524: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1201: + if ((rc = tlv_find(&cursor, TLV_TAG_PARTITION_TRAILER)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1530: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1207: + if ((rc = tlv_advance(&cursor)) != 0) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1553: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1230: + for (pos = 0; (size_t)pos < total_length; pos += sizeof (uint32_t)) { WARNING:BRACES: braces {} are not necessary for single statement blocks #1553: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1230: + for (pos = 0; (size_t)pos < total_length; pos += sizeof (uint32_t)) { + cksum += *((uint32_t *)(seg_data + pos)); + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1561: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1238: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1586: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1263: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1614: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1291: + if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)seg_data, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1619: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1296: + if ((rc = tlv_find(&cursor, tag)) != 0) { CHECK:BRACES: braces {} should be used on all arms of this statement #1626: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1303: + if (length == 0) [...] + else { [...] ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1641: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1318: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1652: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1329: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1672: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1349: + if ((rc = ef10_nvram_partn_size(enp, partn, &partn_size)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1705: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1382: + if ((rc = ef10_nvram_buf_read_tlv(enp, seg_data, partn_size, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1714: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1391: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1729: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1406: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1748: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1425: + if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)seg_data, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1767: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1444: + if ((rc = tlv_find(&cursor, TLV_TAG_PARTITION_TRAILER)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1772: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1449: + if ((rc = tlv_advance(&cursor)) != 0) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1784: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1461: + for (pos = 0; (size_t)pos < *seg_sizep; pos += sizeof (uint32_t)) { WARNING:BRACES: braces {} are not necessary for single statement blocks #1784: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1461: + for (pos = 0; (size_t)pos < *seg_sizep; pos += sizeof (uint32_t)) { + cksum += *((uint32_t *)(seg_data + pos)); + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1830: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1507: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1857: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1534: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1882: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1559: + if ((rc = tlv_init_cursor_from_size(&cursor, (uint8_t *)seg_data, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1894: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1571: + if ((rc = tlv_find(&cursor, tag)) == 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1896: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1573: + if ((rc = tlv_modify(&cursor, tag, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1906: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1583: + if ((rc = tlv_insert(&cursor, tag, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1914: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1591: + if ((rc = tlv_find(&cursor, TLV_TAG_PARTITION_TRAILER)) != 0) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1935: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1612: + for (pos = 0; (size_t)pos < *total_lengthp; pos += sizeof (uint32_t)) { WARNING:BRACES: braces {} are not necessary for single statement blocks #1935: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1612: + for (pos = 0; (size_t)pos < *total_lengthp; pos += sizeof (uint32_t)) { + cksum += *((uint32_t *)(seg_data + pos)); + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1940: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1617: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1957: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1634: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2021: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1698: + if ((rc = ef10_nvram_buf_write_tlv(*seg_datap, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2040: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1717: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2049: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1726: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2094: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1771: + if ((rc = ef10_nvram_partn_size(enp, partn, &partn_size)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2108: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1785: + if ((rc = ef10_nvram_partn_lock(enp, partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2142: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1819: + if ((rc = ef10_nvram_partn_erase(enp, partn, 0, partn_size)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2146: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1823: + if ((rc = ef10_nvram_partn_write(enp, partn, 0, partn_data, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2155: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1832: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2176: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1853: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2191: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1868: + if ((rc = efx_mcdi_nvram_info(enp, partn, sizep, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2195: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1872: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2200: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1877: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2210: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1887: + if ((rc = efx_mcdi_nvram_update_start(enp, partn)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2213: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1890: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2218: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1895: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2236: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1913: + if ((rc = efx_mcdi_nvram_read(enp, partn, offset, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2246: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1923: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2251: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1928: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2280: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1957: + if ((rc = efx_mcdi_nvram_info(enp, partn, NULL, NULL, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2285: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1962: + if ((rc = efx_mcdi_nvram_erase(enp, partn, offset, size)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2293: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1970: + if ((rc = efx_mcdi_nvram_erase(enp, partn, offset, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2301: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1978: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2312: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:1989: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2327: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2004: + if ((rc = efx_mcdi_nvram_info(enp, partn, NULL, NULL, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2347: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2024: + if ((rc = efx_mcdi_nvram_write(enp, partn, offset, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2357: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2034: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2366: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2043: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2385: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2062: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2390: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2067: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2409: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2086: + size = sizeof (partn_version) - (2 * sizeof (uint32_t)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2409: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2086: + size = sizeof (partn_version) - (2 * sizeof (uint32_t)); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2412: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2089: + if ((rc = ef10_nvram_partn_write_segment_tlv(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2418: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2095: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2423: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2100: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2530: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2207: + return (EINVAL); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EINVAL) #2530: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2207: + return (EINVAL); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2532: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2209: + return (0); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #2541: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2218: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2556: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2233: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2561: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2238: + return (ENOTSUP); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2561: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2238: + return (ENOTSUP); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #2572: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2249: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2586: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2263: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2591: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2268: + return (ENOTSUP); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #2591: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2268: + return (ENOTSUP); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2606: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2283: + size = MC_CMD_NVRAM_PARTITIONS_OUT_TYPE_ID_MAXNUM * sizeof (uint32_t); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2613: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2290: + if ((rc = efx_mcdi_nvram_partitions(enp, (caddr_t)partns, size, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2620: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2297: + if ((rc = ef10_nvram_partn_to_type(enp, partns[i], &type)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2623: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2300: + if ((rc = efx_mcdi_nvram_test(enp, partns[i])) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2628: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2305: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2637: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2314: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2654: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2331: + if ((rc = efx_mcdi_nvram_metadata(enp, partn, subtypep, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2658: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2335: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2663: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2340: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2674: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2351: + if ((rc = ef10_nvram_partn_lock(enp, partn)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2680: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2357: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2685: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2362: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2695: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2372: + if ((rc = ef10_nvram_partn_unlock(enp, partn, NULL)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2698: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2375: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2703: FILE: drivers/net/sfc/efx/base/ef10_nvram.c:2380: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3085: FILE: drivers/net/sfc/efx/base/efx_nvram.c:115: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3090: FILE: drivers/net/sfc/efx/base/efx_nvram.c:120: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3105: FILE: drivers/net/sfc/efx/base/efx_nvram.c:135: + if ((rc = envop->envo_test(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3108: FILE: drivers/net/sfc/efx/base/efx_nvram.c:138: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3113: FILE: drivers/net/sfc/efx/base/efx_nvram.c:143: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3133: FILE: drivers/net/sfc/efx/base/efx_nvram.c:163: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3136: FILE: drivers/net/sfc/efx/base/efx_nvram.c:166: + if ((rc = envop->envo_partn_size(enp, partn, sizep)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3139: FILE: drivers/net/sfc/efx/base/efx_nvram.c:169: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3147: FILE: drivers/net/sfc/efx/base/efx_nvram.c:177: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3167: FILE: drivers/net/sfc/efx/base/efx_nvram.c:197: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3170: FILE: drivers/net/sfc/efx/base/efx_nvram.c:200: + if ((rc = envop->envo_partn_get_version(enp, partn, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3174: FILE: drivers/net/sfc/efx/base/efx_nvram.c:204: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3181: FILE: drivers/net/sfc/efx/base/efx_nvram.c:211: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3202: FILE: drivers/net/sfc/efx/base/efx_nvram.c:232: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3205: FILE: drivers/net/sfc/efx/base/efx_nvram.c:235: + if ((rc = envop->envo_partn_rw_start(enp, partn, chunk_sizep)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3210: FILE: drivers/net/sfc/efx/base/efx_nvram.c:240: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3217: FILE: drivers/net/sfc/efx/base/efx_nvram.c:247: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3240: FILE: drivers/net/sfc/efx/base/efx_nvram.c:270: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3243: FILE: drivers/net/sfc/efx/base/efx_nvram.c:273: + if ((rc = envop->envo_partn_read(enp, partn, offset, data, size)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3246: FILE: drivers/net/sfc/efx/base/efx_nvram.c:276: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3253: FILE: drivers/net/sfc/efx/base/efx_nvram.c:283: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3275: FILE: drivers/net/sfc/efx/base/efx_nvram.c:305: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3278: FILE: drivers/net/sfc/efx/base/efx_nvram.c:308: + if ((rc = envop->envo_partn_size(enp, partn, &size)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3281: FILE: drivers/net/sfc/efx/base/efx_nvram.c:311: + if ((rc = envop->envo_partn_erase(enp, partn, offset, size)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3284: FILE: drivers/net/sfc/efx/base/efx_nvram.c:314: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3293: FILE: drivers/net/sfc/efx/base/efx_nvram.c:323: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3316: FILE: drivers/net/sfc/efx/base/efx_nvram.c:346: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3319: FILE: drivers/net/sfc/efx/base/efx_nvram.c:349: + if ((rc = envop->envo_partn_write(enp, partn, offset, data, size)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3322: FILE: drivers/net/sfc/efx/base/efx_nvram.c:352: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3329: FILE: drivers/net/sfc/efx/base/efx_nvram.c:359: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3349: FILE: drivers/net/sfc/efx/base/efx_nvram.c:379: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3352: FILE: drivers/net/sfc/efx/base/efx_nvram.c:382: + if ((rc = envop->envo_partn_rw_finish(enp, partn)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3357: FILE: drivers/net/sfc/efx/base/efx_nvram.c:387: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3366: FILE: drivers/net/sfc/efx/base/efx_nvram.c:396: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3392: FILE: drivers/net/sfc/efx/base/efx_nvram.c:422: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3395: FILE: drivers/net/sfc/efx/base/efx_nvram.c:425: + if ((rc = envop->envo_partn_set_version(enp, partn, version)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3398: FILE: drivers/net/sfc/efx/base/efx_nvram.c:428: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3405: FILE: drivers/net/sfc/efx/base/efx_nvram.c:435: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3427: FILE: drivers/net/sfc/efx/base/efx_nvram.c:457: + if ((rc = envop->envo_type_to_partn(enp, type, &partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3430: FILE: drivers/net/sfc/efx/base/efx_nvram.c:460: + if (envop->envo_type_to_partn != NULL && ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3435: FILE: drivers/net/sfc/efx/base/efx_nvram.c:465: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3442: FILE: drivers/net/sfc/efx/base/efx_nvram.c:472: + return (rc); CHECK:SPACING: No space is necessary after a cast #3481: FILE: drivers/net/sfc/efx/base/efx_nvram.c:511: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3481: FILE: drivers/net/sfc/efx/base/efx_nvram.c:511: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3506: FILE: drivers/net/sfc/efx/base/efx_nvram.c:536: + if (size < npartn * sizeof (uint32_t)) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3515: FILE: drivers/net/sfc/efx/base/efx_nvram.c:545: + (npartn * sizeof (uint32_t))); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3517: FILE: drivers/net/sfc/efx/base/efx_nvram.c:547: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3526: FILE: drivers/net/sfc/efx/base/efx_nvram.c:556: + return (rc); CHECK:SPACING: No space is necessary after a cast #3543: FILE: drivers/net/sfc/efx/base/efx_nvram.c:573: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3543: FILE: drivers/net/sfc/efx/base/efx_nvram.c:573: + (void) memset(payload, 0, sizeof (payload)); CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #3578: FILE: drivers/net/sfc/efx/base/efx_nvram.c:608: + version[0] = version[1] = version[2] = version[3] = 0; WARNING:TYPO_SPELLING: 'descrition' may be misspelled - perhaps 'description'? #3583: FILE: drivers/net/sfc/efx/base/efx_nvram.c:613: + /* Return optional descrition string */ ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3608: FILE: drivers/net/sfc/efx/base/efx_nvram.c:638: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3617: FILE: drivers/net/sfc/efx/base/efx_nvram.c:647: + return (rc); CHECK:SPACING: No space is necessary after a cast #3634: FILE: drivers/net/sfc/efx/base/efx_nvram.c:664: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3634: FILE: drivers/net/sfc/efx/base/efx_nvram.c:664: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3671: FILE: drivers/net/sfc/efx/base/efx_nvram.c:701: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3678: FILE: drivers/net/sfc/efx/base/efx_nvram.c:708: + return (rc); CHECK:SPACING: No space is necessary after a cast #3695: FILE: drivers/net/sfc/efx/base/efx_nvram.c:725: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3695: FILE: drivers/net/sfc/efx/base/efx_nvram.c:725: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3714: FILE: drivers/net/sfc/efx/base/efx_nvram.c:744: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3719: FILE: drivers/net/sfc/efx/base/efx_nvram.c:749: + return (rc); CHECK:SPACING: No space is necessary after a cast #3741: FILE: drivers/net/sfc/efx/base/efx_nvram.c:771: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3741: FILE: drivers/net/sfc/efx/base/efx_nvram.c:771: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3769: FILE: drivers/net/sfc/efx/base/efx_nvram.c:799: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3776: FILE: drivers/net/sfc/efx/base/efx_nvram.c:806: + return (rc); CHECK:SPACING: No space is necessary after a cast #3791: FILE: drivers/net/sfc/efx/base/efx_nvram.c:821: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3791: FILE: drivers/net/sfc/efx/base/efx_nvram.c:821: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3809: FILE: drivers/net/sfc/efx/base/efx_nvram.c:839: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3814: FILE: drivers/net/sfc/efx/base/efx_nvram.c:844: + return (rc); CHECK:SPACING: No space is necessary after a cast #3847: FILE: drivers/net/sfc/efx/base/efx_nvram.c:877: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3847: FILE: drivers/net/sfc/efx/base/efx_nvram.c:877: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3868: FILE: drivers/net/sfc/efx/base/efx_nvram.c:898: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3875: FILE: drivers/net/sfc/efx/base/efx_nvram.c:905: + return (rc); CHECK:SPACING: No space is necessary after a cast #3897: FILE: drivers/net/sfc/efx/base/efx_nvram.c:927: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3897: FILE: drivers/net/sfc/efx/base/efx_nvram.c:927: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3940: FILE: drivers/net/sfc/efx/base/efx_nvram.c:970: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3953: FILE: drivers/net/sfc/efx/base/efx_nvram.c:983: + return (rc); CHECK:SPACING: No space is necessary after a cast #3969: FILE: drivers/net/sfc/efx/base/efx_nvram.c:999: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3969: FILE: drivers/net/sfc/efx/base/efx_nvram.c:999: + (void) memset(payload, 0, sizeof (payload)); CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #3992: FILE: drivers/net/sfc/efx/base/efx_nvram.c:1022: + if (result == MC_CMD_NVRAM_TEST_FAIL) { + ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3999: FILE: drivers/net/sfc/efx/base/efx_nvram.c:1029: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4008: FILE: drivers/net/sfc/efx/base/efx_nvram.c:1038: + return (rc); CHECK:SPACING: No space is necessary after a cast #4145: FILE: drivers/net/sfc/efx/base/siena_nic.c:49: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4145: FILE: drivers/net/sfc/efx/base/siena_nic.c:49: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4166: FILE: drivers/net/sfc/efx/base/siena_nic.c:70: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4173: FILE: drivers/net/sfc/efx/base/siena_nic.c:77: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4186: FILE: drivers/net/sfc/efx/base/siena_nic.c:259: + if ((rc = siena_nic_get_partn_mask(enp, &mask)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4261: FILE: drivers/net/sfc/efx/base/siena_nvram.c:51: + if ((rc = efx_mcdi_nvram_info(enp, partn, sizep, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4266: FILE: drivers/net/sfc/efx/base/siena_nvram.c:56: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4273: FILE: drivers/net/sfc/efx/base/siena_nvram.c:63: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4283: FILE: drivers/net/sfc/efx/base/siena_nvram.c:73: + if ((rc = efx_mcdi_nvram_update_start(enp, partn)) != 0) { WARNING:BRACES: braces {} are not necessary for single statement blocks #4283: FILE: drivers/net/sfc/efx/base/siena_nvram.c:73: + if ((rc = efx_mcdi_nvram_update_start(enp, partn)) != 0) { + goto fail1; + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4287: FILE: drivers/net/sfc/efx/base/siena_nvram.c:77: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4292: FILE: drivers/net/sfc/efx/base/siena_nvram.c:82: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4309: FILE: drivers/net/sfc/efx/base/siena_nvram.c:99: + if ((rc = efx_mcdi_nvram_read(enp, partn, offset, data, chunk, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4319: FILE: drivers/net/sfc/efx/base/siena_nvram.c:109: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4324: FILE: drivers/net/sfc/efx/base/siena_nvram.c:114: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4336: FILE: drivers/net/sfc/efx/base/siena_nvram.c:126: + if ((rc = efx_mcdi_nvram_erase(enp, partn, offset, size)) != 0) { WARNING:BRACES: braces {} are not necessary for single statement blocks #4336: FILE: drivers/net/sfc/efx/base/siena_nvram.c:126: + if ((rc = efx_mcdi_nvram_erase(enp, partn, offset, size)) != 0) { + goto fail1; + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4340: FILE: drivers/net/sfc/efx/base/siena_nvram.c:130: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4345: FILE: drivers/net/sfc/efx/base/siena_nvram.c:135: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4362: FILE: drivers/net/sfc/efx/base/siena_nvram.c:152: + if ((rc = efx_mcdi_nvram_write(enp, partn, offset, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4372: FILE: drivers/net/sfc/efx/base/siena_nvram.c:162: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4377: FILE: drivers/net/sfc/efx/base/siena_nvram.c:167: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4400: FILE: drivers/net/sfc/efx/base/siena_nvram.c:190: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4405: FILE: drivers/net/sfc/efx/base/siena_nvram.c:195: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #4449: FILE: drivers/net/sfc/efx/base/siena_nvram.c:239: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4460: FILE: drivers/net/sfc/efx/base/siena_nvram.c:250: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4464: FILE: drivers/net/sfc/efx/base/siena_nvram.c:254: + return (ENOTSUP); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #4464: FILE: drivers/net/sfc/efx/base/siena_nvram.c:254: + return (ENOTSUP); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #4474: FILE: drivers/net/sfc/efx/base/siena_nvram.c:264: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4490: FILE: drivers/net/sfc/efx/base/siena_nvram.c:280: + if ((rc = efx_mcdi_nvram_test(enp, entry->partn)) != 0) { WARNING:BRACES: braces {} are not necessary for single statement blocks #4490: FILE: drivers/net/sfc/efx/base/siena_nvram.c:280: + if ((rc = efx_mcdi_nvram_test(enp, entry->partn)) != 0) { + goto fail1; + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4495: FILE: drivers/net/sfc/efx/base/siena_nvram.c:285: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4500: FILE: drivers/net/sfc/efx/base/siena_nvram.c:290: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4507: FILE: drivers/net/sfc/efx/base/siena_nvram.c:297: + (sizeof (siena_mc_dynamic_config_hdr_t) + ((_nitems) * \ WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4508: FILE: drivers/net/sfc/efx/base/siena_nvram.c:298: + sizeof (((siena_mc_dynamic_config_hdr_t *)NULL)->fw_version[0]))) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4536: FILE: drivers/net/sfc/efx/base/siena_nvram.c:326: + if ((rc = siena_nvram_partn_size(enp, partn, &size)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4545: FILE: drivers/net/sfc/efx/base/siena_nvram.c:335: + if ((rc = siena_nvram_partn_read(enp, partn, 0, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4579: FILE: drivers/net/sfc/efx/base/siena_nvram.c:369: + if ((rc = siena_nvram_partn_read(enp, partn, SIENA_NVRAM_CHUNK, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4610: FILE: drivers/net/sfc/efx/base/siena_nvram.c:400: + EFX_POPULATE_WORD_1(dcfg->length, EFX_WORD_0, sizeof (*dcfg)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4614: FILE: drivers/net/sfc/efx/base/siena_nvram.c:404: + EFX_DWORD_0, sizeof (*dcfg)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4622: FILE: drivers/net/sfc/efx/base/siena_nvram.c:412: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4636: FILE: drivers/net/sfc/efx/base/siena_nvram.c:426: + return (rc); CHECK:SPACING: No space is necessary after a cast #4651: FILE: drivers/net/sfc/efx/base/siena_nvram.c:441: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4651: FILE: drivers/net/sfc/efx/base/siena_nvram.c:441: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4672: FILE: drivers/net/sfc/efx/base/siena_nvram.c:462: + (partn + 1) * sizeof (efx_word_t)) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4681: FILE: drivers/net/sfc/efx/base/siena_nvram.c:471: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4690: FILE: drivers/net/sfc/efx/base/siena_nvram.c:480: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4711: FILE: drivers/net/sfc/efx/base/siena_nvram.c:501: + if ((rc = siena_nvram_get_subtype(enp, partn, subtypep)) != 0) CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #4719: FILE: drivers/net/sfc/efx/base/siena_nvram.c:509: + version[0] = version[1] = version[2] = version[3] = 0; WARNING:TYPO_SPELLING: 'Ingore' may be misspelled - perhaps 'Ignore'? #4734: FILE: drivers/net/sfc/efx/base/siena_nvram.c:524: + * Ingore missing partitions on port 2, assuming they're due ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4742: FILE: drivers/net/sfc/efx/base/siena_nvram.c:532: + if ((rc = siena_nvram_get_dynamic_cfg(enp, dcfg_partn, WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4756: FILE: drivers/net/sfc/efx/base/siena_nvram.c:546: + if (memcmp(version, temp, sizeof (temp)) < 0) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4757: FILE: drivers/net/sfc/efx/base/siena_nvram.c:547: + memcpy(version, temp, sizeof (temp)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4763: FILE: drivers/net/sfc/efx/base/siena_nvram.c:553: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4772: FILE: drivers/net/sfc/efx/base/siena_nvram.c:562: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4783: FILE: drivers/net/sfc/efx/base/siena_nvram.c:573: + if ((rc = siena_nvram_partn_lock(enp, partn)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4789: FILE: drivers/net/sfc/efx/base/siena_nvram.c:579: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4794: FILE: drivers/net/sfc/efx/base/siena_nvram.c:584: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4804: FILE: drivers/net/sfc/efx/base/siena_nvram.c:594: + if ((rc = siena_nvram_partn_unlock(enp, partn)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4807: FILE: drivers/net/sfc/efx/base/siena_nvram.c:597: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4812: FILE: drivers/net/sfc/efx/base/siena_nvram.c:602: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #4821: FILE: drivers/net/sfc/efx/base/siena_nvram.c:611: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4841: FILE: drivers/net/sfc/efx/base/siena_nvram.c:631: + if ((rc = siena_nvram_partn_size(enp, dcfg_partn, &dcfg_size)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4844: FILE: drivers/net/sfc/efx/base/siena_nvram.c:634: + if ((rc = siena_nvram_partn_lock(enp, dcfg_partn)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4847: FILE: drivers/net/sfc/efx/base/siena_nvram.c:637: + if ((rc = siena_nvram_get_dynamic_cfg(enp, dcfg_partn, CHECK:SPACING: No space is necessary after a cast #4867: FILE: drivers/net/sfc/efx/base/siena_nvram.c:657: + (void) memmove((caddr_t)dcfg + required_hdr_length, CHECK:SPACING: No space is necessary after a cast #4875: FILE: drivers/net/sfc/efx/base/siena_nvram.c:665: + (void) memset((caddr_t)dcfg + hdr_length, 0, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4883: FILE: drivers/net/sfc/efx/base/siena_nvram.c:673: + if ((rc = siena_nvram_get_subtype(enp, partn, &subtype)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4908: FILE: drivers/net/sfc/efx/base/siena_nvram.c:698: + if ((rc = siena_nvram_partn_erase(enp, dcfg_partn, 0, dcfg_size)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4912: FILE: drivers/net/sfc/efx/base/siena_nvram.c:702: + if ((rc = siena_nvram_partn_write(enp, dcfg_partn, 0, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4920: FILE: drivers/net/sfc/efx/base/siena_nvram.c:710: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4939: FILE: drivers/net/sfc/efx/base/siena_nvram.c:729: + return (rc); total: 268 errors, 68 warnings, 23 checks, 4808 lines checked