From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>
Subject: [dpdk-test-report] |WARNING| [PATCH 11/16] e1000/base: enable new i219 devices
Date: Thu, 24 Nov 2016 02:33:26 +0100 (CET) [thread overview]
Message-ID: <20161124013326.D95719252@dpdk.org> (raw)
In-Reply-To: <1479921780-9813-12-git-send-email-wenzhuo.lu@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17219
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#156: FILE: drivers/net/e1000/base/e1000_ich8lan.c:97:
+STATIC s32 e1000_read_nvm_spt(struct e1000_hw *hw, u16 offset, u16 words,
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#162: FILE: drivers/net/e1000/base/e1000_ich8lan.c:103:
+STATIC s32 e1000_update_nvm_checksum_spt(struct e1000_hw *hw);
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#170: FILE: drivers/net/e1000/base/e1000_ich8lan.c:131:
+STATIC s32 e1000_read_flash_data32_ich8lan(struct e1000_hw *hw, u32 offset,
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#172: FILE: drivers/net/e1000/base/e1000_ich8lan.c:133:
+STATIC s32 e1000_read_flash_dword_ich8lan(struct e1000_hw *hw,
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#174: FILE: drivers/net/e1000/base/e1000_ich8lan.c:135:
+STATIC s32 e1000_write_flash_data32_ich8lan(struct e1000_hw *hw,
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#176: FILE: drivers/net/e1000/base/e1000_ich8lan.c:137:
+STATIC s32 e1000_retry_write_flash_dword_ich8lan(struct e1000_hw *hw,
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#412: FILE: drivers/net/e1000/base/e1000_ich8lan.c:1633:
+
+ }
WARNING:BRACES: braces {} are not necessary for single statement blocks
#431: FILE: drivers/net/e1000/base/e1000_ich8lan.c:1664:
+ if (hw->mac.type >= e1000_pch_lpt) {
e1000_configure_k0s_lpt(hw, K1_ENTRY_LATENCY, K1_MIN_TIME);
}
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#559: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3492:
+ if (dev_spec->shadow_ram[offset+i].modified) {
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#560: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3493:
+ data[i] = dev_spec->shadow_ram[offset+i].value;
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#577: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3510:
+ if (!(dev_spec->shadow_ram[offset+i].modified) ||
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#578: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3511:
+ !(dev_spec->shadow_ram[offset+i+1].modified)) {
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#578: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3511:
+ !(dev_spec->shadow_ram[offset+i+1].modified)) {
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#586: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3519:
+ if (dev_spec->shadow_ram[offset+i].modified)
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#587: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3520:
+ data[i] = dev_spec->shadow_ram[offset+i].value;
^
CHECK:SPACING: No space is necessary after a cast
#589: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3522:
+ data[i] = (u16) (dword & 0xFFFF);
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#590: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3523:
+ if (dev_spec->shadow_ram[offset+i].modified)
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#591: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3524:
+ data[i+1] =
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#592: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3525:
+ dev_spec->shadow_ram[offset+i+1].value;
^
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#592: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3525:
+ dev_spec->shadow_ram[offset+i+1].value;
^
CHECK:SPACING: No space is necessary after a cast
#594: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3527:
+ data[i+1] = (u16) (dword >> 16 & 0xFFFF);
CHECK:SPACING: spaces preferred around that '+' (ctx:VxV)
#594: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3527:
+ data[i+1] = (u16) (dword >> 16 & 0xFFFF);
^
CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#659: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3705:
+ hsflctl.regval = E1000_READ_FLASH_REG(hw, ICH_FLASH_HSFSTS)>>16;
^
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#713: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3795:
+ return -E1000_ERR_NVM;
+ else
CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#756: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3916:
+ hsflctl.regval = E1000_READ_FLASH_REG(hw, ICH_FLASH_HSFSTS)>>16;
^
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#779: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3939:
+ break;
+ } else {
WARNING:LONG_LINE_STRING: line over 90 characters
#791: FILE: drivers/net/e1000/base/e1000_ich8lan.c:3951:
+ DEBUGOUT("Timeout error - flash cycle did not complete.
");
WARNING:TABSTOP: Statements should start on a tabstop
#900: FILE: drivers/net/e1000/base/e1000_ich8lan.c:4091:
+ }
CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#1012: FILE: drivers/net/e1000/base/e1000_ich8lan.c:4412:
+ E1000_READ_FLASH_REG(hw, ICH_FLASH_HSFSTS)>>16;
^
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1039: FILE: drivers/net/e1000/base/e1000_ich8lan.c:4468:
+/**
+* e1000_write_flash_data32_ich8lan - Writes 4 bytes to the NVM
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1134: FILE: drivers/net/e1000/base/e1000_ich8lan.c:4575:
+/**
+* e1000_retry_write_flash_dword_ich8lan - Writes a dword to NVM
CHECK:SPACING: spaces preferred around that '>>' (ctx:VxV)
#1181: FILE: drivers/net/e1000/base/e1000_ich8lan.c:4722:
+ ICH_FLASH_HSFSTS)>>16;
^
total: 0 errors, 13 warnings, 19 checks, 1149 lines checked
parent reply other threads:[~2016-11-24 1:33 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1479921780-9813-12-git-send-email-wenzhuo.lu@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161124013326.D95719252@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).