From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BA56F567A; Tue, 29 Nov 2016 17:21:33 +0100 (CET)
In-Reply-To: <1480436367-20749-18-git-send-email-arybchenko@solarflare.com>
References: <1480436367-20749-18-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20161129162133.BA56F567A@dpdk.org>
Date: Tue, 29 Nov 2016 17:21:33 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| [PATCH v2 17/55] net/sfc: import
	libefx PHY LEDs control support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Nov 2016 16:21:33 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17285

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#134: FILE: drivers/net/sfc/base/efx.h:476:
+extern	__checkReturn	efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#218: FILE: drivers/net/sfc/base/efx_phy.c:143:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#240: FILE: drivers/net/sfc/base/efx_phy.c:165:
+	if ((rc = epop->epo_reconfigure(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#244: FILE: drivers/net/sfc/base/efx_phy.c:169:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#251: FILE: drivers/net/sfc/base/efx_phy.c:176:
+	return (rc);

total: 3 errors, 0 warnings, 2 checks, 168 lines checked