* [dpdk-test-report] |WARNING| [PATCH v2 17/55] net/sfc: import libefx PHY LEDs control support
[not found] <1480436367-20749-18-git-send-email-arybchenko@solarflare.com>
@ 2016-11-29 16:21 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-11-29 16:21 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17285
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#134: FILE: drivers/net/sfc/base/efx.h:476:
+extern __checkReturn efx_rc_t
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#218: FILE: drivers/net/sfc/base/efx_phy.c:143:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#240: FILE: drivers/net/sfc/base/efx_phy.c:165:
+ if ((rc = epop->epo_reconfigure(enp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#244: FILE: drivers/net/sfc/base/efx_phy.c:169:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#251: FILE: drivers/net/sfc/base/efx_phy.c:176:
+ return (rc);
total: 3 errors, 0 warnings, 2 checks, 168 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-29 16:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1480436367-20749-18-git-send-email-arybchenko@solarflare.com>
2016-11-29 16:21 ` [dpdk-test-report] |WARNING| [PATCH v2 17/55] net/sfc: import libefx PHY LEDs control support checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).