From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id AD9C4D59A; Tue, 29 Nov 2016 17:21:43 +0100 (CET) In-Reply-To: <1480436367-20749-17-git-send-email-arybchenko@solarflare.com> References: <1480436367-20749-17-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161129162143.AD9C4D59A@dpdk.org> Date: Tue, 29 Nov 2016 17:21:43 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH v2 16/55] net/sfc: import libefx PHY statistics support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 16:21:43 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17288 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #98: FILE: drivers/net/sfc/base/ef10_impl.h:357: +extern __checkReturn efx_rc_t WARNING:SPACING: space prohibited between function name and open parenthesis '(' #127: FILE: drivers/net/sfc/base/ef10_phy.c:407: + memset(stat, 0, EFX_PHY_NSTATS * sizeof (*stat)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #129: FILE: drivers/net/sfc/base/ef10_phy.c:409: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #379: FILE: drivers/net/sfc/base/efx_phy.c:351: + return (__efx_phy_stat_name[type]); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #390: FILE: drivers/net/sfc/base/efx_phy.c:362: + efx_port_t *epp = &(enp->en_port); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #396: FILE: drivers/net/sfc/base/efx_phy.c:368: + return (epop->epo_stats_update(enp, esmp, stat)); ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #460: FILE: drivers/net/sfc/base/siena_phy.c:381: +#define SIENA_SIMPLE_STAT_SET(_vmask, _esmp, _smask, _stat, \ + _mc_record, _efx_record) \ + if ((_vmask) & (1ULL << (_mc_record))) { \ + (_smask) |= (1ULL << (_efx_record)); \ + if ((_stat) != NULL && !EFSYS_MEM_IS_NULL(_esmp)) { \ + efx_dword_t dword; \ + EFSYS_MEM_READD(_esmp, (_mc_record) * 4, &dword);\ + (_stat)[_efx_record] = \ + EFX_DWORD_FIELD(dword, EFX_DWORD_0); \ + } \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse '_esmp' - possible side-effects? #460: FILE: drivers/net/sfc/base/siena_phy.c:381: +#define SIENA_SIMPLE_STAT_SET(_vmask, _esmp, _smask, _stat, \ + _mc_record, _efx_record) \ + if ((_vmask) & (1ULL << (_mc_record))) { \ + (_smask) |= (1ULL << (_efx_record)); \ + if ((_stat) != NULL && !EFSYS_MEM_IS_NULL(_esmp)) { \ + efx_dword_t dword; \ + EFSYS_MEM_READD(_esmp, (_mc_record) * 4, &dword);\ + (_stat)[_efx_record] = \ + EFX_DWORD_FIELD(dword, EFX_DWORD_0); \ + } \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse '_stat' - possible side-effects? #460: FILE: drivers/net/sfc/base/siena_phy.c:381: +#define SIENA_SIMPLE_STAT_SET(_vmask, _esmp, _smask, _stat, \ + _mc_record, _efx_record) \ + if ((_vmask) & (1ULL << (_mc_record))) { \ + (_smask) |= (1ULL << (_efx_record)); \ + if ((_stat) != NULL && !EFSYS_MEM_IS_NULL(_esmp)) { \ + efx_dword_t dword; \ + EFSYS_MEM_READD(_esmp, (_mc_record) * 4, &dword);\ + (_stat)[_efx_record] = \ + EFX_DWORD_FIELD(dword, EFX_DWORD_0); \ + } \ + } CHECK:MACRO_ARG_REUSE: Macro argument reuse '_efx_record' - possible side-effects? #460: FILE: drivers/net/sfc/base/siena_phy.c:381: +#define SIENA_SIMPLE_STAT_SET(_vmask, _esmp, _smask, _stat, \ + _mc_record, _efx_record) \ + if ((_vmask) & (1ULL << (_mc_record))) { \ + (_smask) |= (1ULL << (_efx_record)); \ + if ((_stat) != NULL && !EFSYS_MEM_IS_NULL(_esmp)) { \ + efx_dword_t dword; \ + EFSYS_MEM_READD(_esmp, (_mc_record) * 4, &dword);\ + (_stat)[_efx_record] = \ + EFX_DWORD_FIELD(dword, EFX_DWORD_0); \ + } \ + } CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #569: FILE: drivers/net/sfc/base/siena_phy.c:490: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); CHECK:SPACING: No space is necessary after a cast #577: FILE: drivers/net/sfc/base/siena_phy.c:498: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #577: FILE: drivers/net/sfc/base/siena_phy.c:498: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #600: FILE: drivers/net/sfc/base/siena_phy.c:521: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #605: FILE: drivers/net/sfc/base/siena_phy.c:526: + return (0); total: 6 errors, 2 warnings, 7 checks, 472 lines checked