From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 50109FA3C; Tue, 29 Nov 2016 17:21:50 +0100 (CET) In-Reply-To: <1480436367-20749-12-git-send-email-arybchenko@solarflare.com> References: <1480436367-20749-12-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161129162150.50109FA3C@dpdk.org> Date: Tue, 29 Nov 2016 17:21:50 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH v2 11/55] net/sfc: import libefx SFN8xxx family support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 16:21:50 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17291 _coding style issues_ ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #246: FILE: drivers/net/sfc/base/efx_nic.c:84: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #250: FILE: drivers/net/sfc/base/efx_nic.c:88: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #254: FILE: drivers/net/sfc/base/efx_nic.c:92: + return (0); CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #453: FILE: drivers/net/sfc/base/medford_impl.h:58: +extern __checkReturn efx_rc_t WARNING:SPACING: space prohibited between function name and open parenthesis '(' #516: FILE: drivers/net/sfc/base/medford_nic.c:48: + memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #553: FILE: drivers/net/sfc/base/medford_nic.c:85: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #560: FILE: drivers/net/sfc/base/medford_nic.c:92: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #573: FILE: drivers/net/sfc/base/medford_nic.c:105: + if ((rc = efx_mcdi_get_port_modes(enp, &port_modes, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #580: FILE: drivers/net/sfc/base/medford_nic.c:112: + if ((rc = ef10_nic_get_port_mode_bandwidth(current_mode, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #587: FILE: drivers/net/sfc/base/medford_nic.c:119: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #592: FILE: drivers/net/sfc/base/medford_nic.c:124: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #599: FILE: drivers/net/sfc/base/medford_nic.c:131: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #600: FILE: drivers/net/sfc/base/medford_nic.c:132: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #604: FILE: drivers/net/sfc/base/medford_nic.c:136: + efx_port_t *epp = &(enp->en_port); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #620: FILE: drivers/net/sfc/base/medford_nic.c:152: + if ((rc = efx_mcdi_get_port_assignment(enp, &port)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #629: FILE: drivers/net/sfc/base/medford_nic.c:161: + if ((rc = ef10_external_port_mapping(enp, port, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #639: FILE: drivers/net/sfc/base/medford_nic.c:171: + if ((rc = efx_mcdi_get_function_info(enp, &pf, &vf)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #686: FILE: drivers/net/sfc/base/medford_nic.c:218: + if ((rc = efx_mcdi_get_phy_cfg(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #690: FILE: drivers/net/sfc/base/medford_nic.c:222: + if ((rc = ef10_phy_get_link(enp, &els)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #738: FILE: drivers/net/sfc/base/medford_nic.c:270: + if ((rc = efx_mcdi_get_clock(enp, &sysclk, &dpcpu_clk)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #750: FILE: drivers/net/sfc/base/medford_nic.c:282: + if ((rc = ef10_get_datapath_caps(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #757: FILE: drivers/net/sfc/base/medford_nic.c:289: + if ((rc = efx_mcdi_get_rxdp_config(enp, &end_padding)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #798: FILE: drivers/net/sfc/base/medford_nic.c:330: + if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #803: FILE: drivers/net/sfc/base/medford_nic.c:335: + if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #832: FILE: drivers/net/sfc/base/medford_nic.c:364: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #863: FILE: drivers/net/sfc/base/medford_nic.c:395: + return (rc); total: 21 errors, 1 warnings, 4 checks, 694 lines checked