automatic DPDK test reports
 help / color / mirror / Atom feed
* [dpdk-test-report] |WARNING| [PATCH v2 13/55] net/sfc: import libefx built-in selftest support
       [not found] <1480436367-20749-14-git-send-email-arybchenko@solarflare.com>
@ 2016-11-29 16:22 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-11-29 16:22 UTC (permalink / raw)
  To: test-report; +Cc: Andrew Rybchenko

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17295

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#98: FILE: drivers/net/sfc/base/ef10_impl.h:350:
+extern	__checkReturn		efx_rc_t

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#144: FILE: drivers/net/sfc/base/ef10_phy.c:401:
+	if ((rc = efx_mcdi_bist_enable_offline(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#147: FILE: drivers/net/sfc/base/ef10_phy.c:404:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#152: FILE: drivers/net/sfc/base/ef10_phy.c:409:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#162: FILE: drivers/net/sfc/base/ef10_phy.c:419:
+	if ((rc = efx_mcdi_bist_start(enp, type)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#165: FILE: drivers/net/sfc/base/ef10_phy.c:422:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#170: FILE: drivers/net/sfc/base/ef10_phy.c:427:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#184: FILE: drivers/net/sfc/base/ef10_phy.c:441:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:SPACING: No space is necessary after a cast
#194: FILE: drivers/net/sfc/base/ef10_phy.c:451:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#194: FILE: drivers/net/sfc/base/ef10_phy.c:451:
+	(void) memset(payload, 0, sizeof (payload));

CHECK:SPACING: No space is necessary after a cast
#214: FILE: drivers/net/sfc/base/ef10_phy.c:471:
+		(void) memset(valuesp, '

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2016-11-29 16:22 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1480436367-20749-14-git-send-email-arybchenko@solarflare.com>
2016-11-29 16:22 ` [dpdk-test-report] |WARNING| [PATCH v2 13/55] net/sfc: import libefx built-in selftest support checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).