* [dpdk-test-report] |WARNING| [PATCH v2 23/55] net/sfc: import libefx monitors statistics support
[not found] <1480436367-20749-24-git-send-email-arybchenko@solarflare.com>
@ 2016-11-29 16:22 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-11-29 16:22 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17297
_coding style issues_
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#109: FILE: drivers/net/sfc/base/ef10_ev.c:1097:
+ if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0) {
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#132: FILE: drivers/net/sfc/base/ef10_nic.c:1386:
+ if ((rc = mcdi_mon_cfg_build(enp)) != 0) {
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#279: FILE: drivers/net/sfc/base/efx.h:729:
+extern __checkReturn efx_rc_t
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#380: FILE: drivers/net/sfc/base/efx_ev.c:1135:
+ if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0)
CHECK:BRACES: braces {} should be used on all arms of this statement
#380: FILE: drivers/net/sfc/base/efx_ev.c:1135:
+ if ((rc = mcdi_mon_ev(enp, eqp, &id, &value)) == 0)
[...]
+ else if (rc == ENOTSUP) {
[...]
+ } else
[...]
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#513: FILE: drivers/net/sfc/base/efx_mon.c:199:
+ return (__mon_stat_name[id]);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mon
#524: FILE: drivers/net/sfc/base/efx_mon.c:210:
+ efx_mon_t *emp = &(enp->en_mon);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#530: FILE: drivers/net/sfc/base/efx_mon.c:216:
+ return (emop->emo_stats_update(enp, esmp, values));
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#547: FILE: drivers/net/sfc/base/siena_nic.c:225:
+ if ((rc = mcdi_mon_cfg_build(enp)) != 0)
total: 6 errors, 0 warnings, 3 checks, 439 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-29 16:22 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1480436367-20749-24-git-send-email-arybchenko@solarflare.com>
2016-11-29 16:22 ` [dpdk-test-report] |WARNING| [PATCH v2 23/55] net/sfc: import libefx monitors statistics support checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).