[dpdk-test-report] |WARNING| [PATCH v2 22/55] net/sfc: import libefx loopback control support

[dpdk-test-report] |WARNING| [PATCH v2 22/55] net/sfc: import libefx loopback control support

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17298

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#103: FILE: drivers/net/sfc/base/ef10_impl.h:264:
+extern	__checkReturn	efx_rc_t

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#140: FILE: drivers/net/sfc/base/ef10_mac.c:454:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#152: FILE: drivers/net/sfc/base/ef10_mac.c:466:
+	if ((rc = epop->epo_reconfigure(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#155: FILE: drivers/net/sfc/base/ef10_mac.c:469:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#163: FILE: drivers/net/sfc/base/ef10_mac.c:477:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#180: FILE: drivers/net/sfc/base/ef10_nic.c:1381:
+	if ((rc = efx_mcdi_get_loopback_modes(enp)) != 0)

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#553: FILE: drivers/net/sfc/base/efx_nic.c:886:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

CHECK:SPACING: No space is necessary after a cast
#561: FILE: drivers/net/sfc/base/efx_nic.c:894:
+	(void) memset(payload, 0, sizeof (payload));

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#561: FILE: drivers/net/sfc/base/efx_nic.c:894:
+	(void) memset(payload, 0, sizeof (payload));

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#621: FILE: drivers/net/sfc/base/efx_nic.c:954:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#628: FILE: drivers/net/sfc/base/efx_nic.c:961:
+	return (rc);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#652: FILE: drivers/net/sfc/base/efx_port.c:136:
+	efx_port_t *epp = &(enp->en_port);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#653: FILE: drivers/net/sfc/base/efx_port.c:137:
+	efx_nic_cfg_t *encp = &(enp->en_nic_cfg);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#671: FILE: drivers/net/sfc/base/efx_port.c:155:
+		return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#673: FILE: drivers/net/sfc/base/efx_port.c:157:
+	if ((rc = emop->emo_loopback_set(enp, link_mode, loopback_type)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#676: FILE: drivers/net/sfc/base/efx_port.c:160:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#683: FILE: drivers/net/sfc/base/efx_port.c:167:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#738: FILE: drivers/net/sfc/base/efx_port.c:222:
+	return (__efx_loopback_type_name[type]);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#795: FILE: drivers/net/sfc/base/siena_mac.c:205:
+	efx_port_t *epp = &(enp->en_port);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#807: FILE: drivers/net/sfc/base/siena_mac.c:217:
+	if ((rc = epop->epo_reconfigure(enp)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#810: FILE: drivers/net/sfc/base/siena_mac.c:220:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#818: FILE: drivers/net/sfc/base/siena_mac.c:228:
+	return (rc);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#835: FILE: drivers/net/sfc/base/siena_nic.c:220:
+	if ((rc = efx_mcdi_get_loopback_modes(enp)) != 0)

total: 15 errors, 1 warnings, 7 checks, 737 lines checked