From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 65514FA64; Tue, 29 Nov 2016 17:22:09 +0100 (CET) In-Reply-To: <1480436367-20749-23-git-send-email-arybchenko@solarflare.com> References: <1480436367-20749-23-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161129162209.65514FA64@dpdk.org> Date: Tue, 29 Nov 2016 17:22:09 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH v2 22/55] net/sfc: import libefx loopback control support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 16:22:09 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17298 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #103: FILE: drivers/net/sfc/base/ef10_impl.h:264: +extern __checkReturn efx_rc_t CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #140: FILE: drivers/net/sfc/base/ef10_mac.c:454: + efx_port_t *epp = &(enp->en_port); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #152: FILE: drivers/net/sfc/base/ef10_mac.c:466: + if ((rc = epop->epo_reconfigure(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #155: FILE: drivers/net/sfc/base/ef10_mac.c:469: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #163: FILE: drivers/net/sfc/base/ef10_mac.c:477: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #180: FILE: drivers/net/sfc/base/ef10_nic.c:1381: + if ((rc = efx_mcdi_get_loopback_modes(enp)) != 0) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #553: FILE: drivers/net/sfc/base/efx_nic.c:886: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); CHECK:SPACING: No space is necessary after a cast #561: FILE: drivers/net/sfc/base/efx_nic.c:894: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #561: FILE: drivers/net/sfc/base/efx_nic.c:894: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #621: FILE: drivers/net/sfc/base/efx_nic.c:954: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #628: FILE: drivers/net/sfc/base/efx_nic.c:961: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #652: FILE: drivers/net/sfc/base/efx_port.c:136: + efx_port_t *epp = &(enp->en_port); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #653: FILE: drivers/net/sfc/base/efx_port.c:137: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #671: FILE: drivers/net/sfc/base/efx_port.c:155: + return (0); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #673: FILE: drivers/net/sfc/base/efx_port.c:157: + if ((rc = emop->emo_loopback_set(enp, link_mode, loopback_type)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #676: FILE: drivers/net/sfc/base/efx_port.c:160: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #683: FILE: drivers/net/sfc/base/efx_port.c:167: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #738: FILE: drivers/net/sfc/base/efx_port.c:222: + return (__efx_loopback_type_name[type]); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #795: FILE: drivers/net/sfc/base/siena_mac.c:205: + efx_port_t *epp = &(enp->en_port); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #807: FILE: drivers/net/sfc/base/siena_mac.c:217: + if ((rc = epop->epo_reconfigure(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #810: FILE: drivers/net/sfc/base/siena_mac.c:220: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #818: FILE: drivers/net/sfc/base/siena_mac.c:228: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #835: FILE: drivers/net/sfc/base/siena_nic.c:220: + if ((rc = efx_mcdi_get_loopback_modes(enp)) != 0) total: 15 errors, 1 warnings, 7 checks, 737 lines checked