From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id BA343FA72; Tue, 29 Nov 2016 17:22:14 +0100 (CET) In-Reply-To: <1480436367-20749-30-git-send-email-arybchenko@solarflare.com> References: <1480436367-20749-30-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161129162214.BA343FA72@dpdk.org> Date: Tue, 29 Nov 2016 17:22:14 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH v2 29/55] net/sfc: import libefx licensing support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 16:22:15 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17300 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #109: FILE: drivers/net/sfc/base/efx.h:2370: +extern __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #371: FILE: drivers/net/sfc/base/efx_lic.c:49: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #399: FILE: drivers/net/sfc/base/efx_lic.c:77: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #413: FILE: drivers/net/sfc/base/efx_lic.c:91: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #425: FILE: drivers/net/sfc/base/efx_lic.c:103: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #437: FILE: drivers/net/sfc/base/efx_lic.c:115: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #445: FILE: drivers/net/sfc/base/efx_lic.c:123: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #546: FILE: drivers/net/sfc/base/efx_lic.c:224: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #555: FILE: drivers/net/sfc/base/efx_lic.c:233: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #583: FILE: drivers/net/sfc/base/efx_lic.c:261: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #597: FILE: drivers/net/sfc/base/efx_lic.c:275: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #609: FILE: drivers/net/sfc/base/efx_lic.c:287: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #621: FILE: drivers/net/sfc/base/efx_lic.c:299: + __checkReturn efx_rc_t WARNING:AVOID_EXTERNS: externs should be avoided in .c files #629: FILE: drivers/net/sfc/base/efx_lic.c:307: + __checkReturn efx_rc_t CHECK:SPACING: No space is necessary after a cast #670: FILE: drivers/net/sfc/base/efx_lic.c:348: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #670: FILE: drivers/net/sfc/base/efx_lic.c:348: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #695: FILE: drivers/net/sfc/base/efx_lic.c:373: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #702: FILE: drivers/net/sfc/base/efx_lic.c:380: + return (rc); CHECK:SPACING: No space is necessary after a cast #717: FILE: drivers/net/sfc/base/efx_lic.c:395: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #717: FILE: drivers/net/sfc/base/efx_lic.c:395: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #755: FILE: drivers/net/sfc/base/efx_lic.c:433: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #762: FILE: drivers/net/sfc/base/efx_lic.c:440: + return (rc); CHECK:SPACING: spaces preferred around that '*' (ctx:ExV) #791: FILE: drivers/net/sfc/base/efx_lic.c:469: + *startp = 0; ^ ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #792: FILE: drivers/net/sfc/base/efx_lic.c:470: + return (0); CHECK:SPACING: spaces preferred around that '*' (ctx:ExV) #807: FILE: drivers/net/sfc/base/efx_lic.c:485: + *endp = offset + EFX_LICENSE_V1V2_HEADER_LENGTH; ^ ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #808: FILE: drivers/net/sfc/base/efx_lic.c:486: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #841: FILE: drivers/net/sfc/base/efx_lic.c:519: + return (found); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #846: FILE: drivers/net/sfc/base/efx_lic.c:524: + return (B_FALSE); WARNING:BRACES: braces {} are not necessary for single statement blocks #861: FILE: drivers/net/sfc/base/efx_lic.c:539: + if (length < EFX_LICENSE_V1V2_HEADER_LENGTH) { + goto fail1; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #868: FILE: drivers/net/sfc/base/efx_lic.c:546: + if (tlv_length > EFX_LICENSE_V1V2_PAYLOAD_LENGTH_MAX) { + goto fail2; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #871: FILE: drivers/net/sfc/base/efx_lic.c:549: + if (tlv_type == 0) { + goto fail3; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #874: FILE: drivers/net/sfc/base/efx_lic.c:552: + if ((tlv_length + EFX_LICENSE_V1V2_HEADER_LENGTH) != length) { + goto fail4; + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #878: FILE: drivers/net/sfc/base/efx_lic.c:556: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #889: FILE: drivers/net/sfc/base/efx_lic.c:567: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #921: FILE: drivers/net/sfc/base/efx_lic.c:599: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #926: FILE: drivers/net/sfc/base/efx_lic.c:604: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #958: FILE: drivers/net/sfc/base/efx_lic.c:636: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #963: FILE: drivers/net/sfc/base/efx_lic.c:641: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #989: FILE: drivers/net/sfc/base/efx_lic.c:667: + return (0); WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test #1001: FILE: drivers/net/sfc/base/efx_lic.c:679: + EFSYS_ASSERT(EFX_LICENSE_V1V2_HEADER_LENGTH <= buffer_size); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1005: FILE: drivers/net/sfc/base/efx_lic.c:683: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1019: FILE: drivers/net/sfc/base/efx_lic.c:697: + return (0); CHECK:SPACING: No space is necessary after a cast #1049: FILE: drivers/net/sfc/base/efx_lic.c:727: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1049: FILE: drivers/net/sfc/base/efx_lic.c:727: + (void) memset(payload, 0, sizeof (payload)); WARNING:BRACES: braces {} are not necessary for any arm of this statement #1072: FILE: drivers/net/sfc/base/efx_lic.c:750: + if (app_state != MC_CMD_GET_LICENSED_APP_STATE_OUT_NOT_LICENSED) { [...] + } else { [...] ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1078: FILE: drivers/net/sfc/base/efx_lic.c:756: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1087: FILE: drivers/net/sfc/base/efx_lic.c:765: + return (rc); CHECK:SPACING: No space is necessary after a cast #1100: FILE: drivers/net/sfc/base/efx_lic.c:778: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1100: FILE: drivers/net/sfc/base/efx_lic.c:778: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1122: FILE: drivers/net/sfc/base/efx_lic.c:800: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1129: FILE: drivers/net/sfc/base/efx_lic.c:807: + return (rc); CHECK:SPACING: No space is necessary after a cast #1144: FILE: drivers/net/sfc/base/efx_lic.c:822: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1144: FILE: drivers/net/sfc/base/efx_lic.c:822: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1181: FILE: drivers/net/sfc/base/efx_lic.c:859: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1188: FILE: drivers/net/sfc/base/efx_lic.c:866: + return (rc); CHECK:SPACING: No space is necessary after a cast #1207: FILE: drivers/net/sfc/base/efx_lic.c:885: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1207: FILE: drivers/net/sfc/base/efx_lic.c:885: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1224: FILE: drivers/net/sfc/base/efx_lic.c:902: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1229: FILE: drivers/net/sfc/base/efx_lic.c:907: + return (rc); CHECK:SPACING: No space is necessary after a cast #1244: FILE: drivers/net/sfc/base/efx_lic.c:922: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1244: FILE: drivers/net/sfc/base/efx_lic.c:922: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1284: FILE: drivers/net/sfc/base/efx_lic.c:962: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1291: FILE: drivers/net/sfc/base/efx_lic.c:969: + return (rc); CHECK:SPACING: No space is necessary after a cast #1308: FILE: drivers/net/sfc/base/efx_lic.c:986: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1308: FILE: drivers/net/sfc/base/efx_lic.c:986: + (void) memset(payload, 0, sizeof (payload)); WARNING:BRACES: braces {} are not necessary for any arm of this statement #1333: FILE: drivers/net/sfc/base/efx_lic.c:1011: + if (app_state != MC_CMD_GET_LICENSED_V3_APP_STATE_OUT_NOT_LICENSED) { [...] + } else { [...] ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1339: FILE: drivers/net/sfc/base/efx_lic.c:1017: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1346: FILE: drivers/net/sfc/base/efx_lic.c:1024: + return (rc); CHECK:SPACING: No space is necessary after a cast #1371: FILE: drivers/net/sfc/base/efx_lic.c:1049: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1371: FILE: drivers/net/sfc/base/efx_lic.c:1049: + (void) memset(payload, 0, sizeof (payload)); WARNING:LONG_LINE: line over 90 characters #1377: FILE: drivers/net/sfc/base/efx_lic.c:1055: + req.emr_out_length = MIN(buffer_size, MC_CMD_LICENSING_GET_ID_V3_OUT_LENMAX); CHECK:SPACING: No space is necessary after a cast #1378: FILE: drivers/net/sfc/base/efx_lic.c:1056: + (void) memset(bufferp, 0, req.emr_out_length); WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #1398: FILE: drivers/net/sfc/base/efx_lic.c:1076: + /* modify length requirements to indicate to caller the extra buffering + ** needed to read the complete output. ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1410: FILE: drivers/net/sfc/base/efx_lic.c:1088: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1417: FILE: drivers/net/sfc/base/efx_lic.c:1095: + return (rc); WARNING:BRACES: braces {} are not necessary for single statement blocks #1483: FILE: drivers/net/sfc/base/efx_lic.c:1161: + if (length < EFX_LICENSE_V3_KEY_LENGTH_MIN) { + goto fail1; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1487: FILE: drivers/net/sfc/base/efx_lic.c:1165: + if (length > EFX_LICENSE_V3_KEY_LENGTH_MAX) { + goto fail2; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1494: FILE: drivers/net/sfc/base/efx_lic.c:1172: + if (key_type < 3) { + goto fail3; + } WARNING:BRACES: braces {} are not necessary for single statement blocks #1497: FILE: drivers/net/sfc/base/efx_lic.c:1175: + if (key_length > length) { + goto fail4; + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1500: FILE: drivers/net/sfc/base/efx_lic.c:1178: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1511: FILE: drivers/net/sfc/base/efx_lic.c:1189: + return (B_FALSE); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1569: FILE: drivers/net/sfc/base/efx_lic.c:1247: + if ((rc = ef10_nvram_buffer_delete_item(bufferp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1576: FILE: drivers/net/sfc/base/efx_lic.c:1254: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1581: FILE: drivers/net/sfc/base/efx_lic.c:1259: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1595: FILE: drivers/net/sfc/base/efx_lic.c:1273: + if ((rc = ef10_nvram_buffer_create(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1602: FILE: drivers/net/sfc/base/efx_lic.c:1280: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1607: FILE: drivers/net/sfc/base/efx_lic.c:1285: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1620: FILE: drivers/net/sfc/base/efx_lic.c:1298: + if ((rc = ef10_nvram_buffer_finish(bufferp, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1626: FILE: drivers/net/sfc/base/efx_lic.c:1304: + if ((rc = ef10_nvram_buffer_validate(enp, NVRAM_PARTITION_TYPE_LICENSE, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1631: FILE: drivers/net/sfc/base/efx_lic.c:1309: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1638: FILE: drivers/net/sfc/base/efx_lic.c:1316: + return (rc); CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1657: FILE: drivers/net/sfc/base/efx_lic.c:1335: + switch (enp->en_family) { + WARNING:BRACES: braces {} are not necessary for any arm of this statement #1686: FILE: drivers/net/sfc/base/efx_lic.c:1364: + if (efx_lic_get_key_stats(enp, &eks) == 0) { [...] + } else { [...] ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1692: FILE: drivers/net/sfc/base/efx_lic.c:1370: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1697: FILE: drivers/net/sfc/base/efx_lic.c:1375: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1734: FILE: drivers/net/sfc/base/efx_lic.c:1412: + if ((rc = elop->elo_update_licenses(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1737: FILE: drivers/net/sfc/base/efx_lic.c:1415: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1742: FILE: drivers/net/sfc/base/efx_lic.c:1420: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1756: FILE: drivers/net/sfc/base/efx_lic.c:1434: + if ((rc = elop->elo_get_key_stats(enp, eksp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1759: FILE: drivers/net/sfc/base/efx_lic.c:1437: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1764: FILE: drivers/net/sfc/base/efx_lic.c:1442: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1780: FILE: drivers/net/sfc/base/efx_lic.c:1458: + return (ENOTSUP); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #1780: FILE: drivers/net/sfc/base/efx_lic.c:1458: + return (ENOTSUP); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1782: FILE: drivers/net/sfc/base/efx_lic.c:1460: + if ((rc = elop->elo_app_state(enp, app_id, licensedp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1785: FILE: drivers/net/sfc/base/efx_lic.c:1463: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1790: FILE: drivers/net/sfc/base/efx_lic.c:1468: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1809: FILE: drivers/net/sfc/base/efx_lic.c:1487: + return (ENOTSUP); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #1809: FILE: drivers/net/sfc/base/efx_lic.c:1487: + return (ENOTSUP); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1811: FILE: drivers/net/sfc/base/efx_lic.c:1489: + if ((rc = elop->elo_get_id(enp, buffer_size, typep, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1815: FILE: drivers/net/sfc/base/efx_lic.c:1493: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1820: FILE: drivers/net/sfc/base/efx_lic.c:1498: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1840: FILE: drivers/net/sfc/base/efx_lic.c:1518: + if ((rc = elop->elo_find_start(enp, bufferp, buffer_size, startp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1843: FILE: drivers/net/sfc/base/efx_lic.c:1521: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1848: FILE: drivers/net/sfc/base/efx_lic.c:1526: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1867: FILE: drivers/net/sfc/base/efx_lic.c:1545: + if ((rc = elop->elo_find_end(enp, bufferp, buffer_size, offset, endp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1870: FILE: drivers/net/sfc/base/efx_lic.c:1548: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1875: FILE: drivers/net/sfc/base/efx_lic.c:1553: + return (rc); WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #1904: FILE: drivers/net/sfc/base/efx_lic.c:1582: +/* Validate that the buffer contains a single key in a recognised format. +** An empty or terminator buffer is not accepted as a valid key. ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1919: FILE: drivers/net/sfc/base/efx_lic.c:1597: + if ((rc = elop->elo_validate_key(enp, keyp, length)) == B_FALSE) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1922: FILE: drivers/net/sfc/base/efx_lic.c:1600: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1927: FILE: drivers/net/sfc/base/efx_lic.c:1605: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1950: FILE: drivers/net/sfc/base/efx_lic.c:1628: + if ((rc = elop->elo_read_key(enp, bufferp, buffer_size, offset, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1954: FILE: drivers/net/sfc/base/efx_lic.c:1632: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1959: FILE: drivers/net/sfc/base/efx_lic.c:1637: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #1980: FILE: drivers/net/sfc/base/efx_lic.c:1658: + if ((rc = elop->elo_write_key(enp, bufferp, buffer_size, offset, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1984: FILE: drivers/net/sfc/base/efx_lic.c:1662: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1989: FILE: drivers/net/sfc/base/efx_lic.c:1667: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2010: FILE: drivers/net/sfc/base/efx_lic.c:1688: + if ((rc = elop->elo_delete_key(enp, bufferp, buffer_size, offset, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2014: FILE: drivers/net/sfc/base/efx_lic.c:1692: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2019: FILE: drivers/net/sfc/base/efx_lic.c:1697: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2036: FILE: drivers/net/sfc/base/efx_lic.c:1714: + if ((rc = elop->elo_create_partition(enp, bufferp, buffer_size)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2039: FILE: drivers/net/sfc/base/efx_lic.c:1717: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2044: FILE: drivers/net/sfc/base/efx_lic.c:1722: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2062: FILE: drivers/net/sfc/base/efx_lic.c:1740: + if ((rc = elop->elo_finish_partition(enp, bufferp, buffer_size)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2065: FILE: drivers/net/sfc/base/efx_lic.c:1743: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2070: FILE: drivers/net/sfc/base/efx_lic.c:1748: + return (rc); total: 83 errors, 39 warnings, 14 checks, 1967 lines checked