From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 783A958EF; Tue, 29 Nov 2016 17:28:38 +0100 (CET) In-Reply-To: <1480436367-20749-25-git-send-email-arybchenko@solarflare.com> References: <1480436367-20749-25-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161129162838.783A958EF@dpdk.org> Date: Tue, 29 Nov 2016 17:28:38 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH v2 24/55] net/sfc: import libefx support to access monitors via MCDI X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 16:28:38 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17305 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #253: FILE: drivers/net/sfc/base/mcdi_mon.c:48: +#define MCDI_MON_PORT_Px (0xFFFF) CHECK:CAMELCASE: Avoid CamelCase: #276: FILE: drivers/net/sfc/base/mcdi_mon.c:71: + STAT(Px, INT_TEMP), /* 0x00 CONTROLLER_TEMP */ CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_field' may be better as '(_field)' to avoid precedence issues #367: FILE: drivers/net/sfc/base/mcdi_mon.c:162: +#define MCDI_STATIC_SENSOR_ASSERT(_field) \ + EFX_STATIC_ASSERT(MC_CMD_SENSOR_STATE_ ## _field \ + == EFX_MON_STAT_STATE_ ## _field) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #380: FILE: drivers/net/sfc/base/mcdi_mon.c:175: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #395: FILE: drivers/net/sfc/base/mcdi_mon.c:190: + EFX_STATIC_ASSERT(sizeof (stat_mask[0]) * 8 == WARNING:SPACING: space prohibited between function name and open parenthesis '(' #403: FILE: drivers/net/sfc/base/mcdi_mon.c:198: + memset(stat_mask, 0, sizeof (stat_mask)); WARNING:BRACES: braces {} are not necessary for single statement blocks #457: FILE: drivers/net/sfc/base/mcdi_mon.c:252: + if (stat_maskp != NULL) { + memcpy(stat_maskp, stat_mask, sizeof (stat_mask)); + } WARNING:SPACING: space prohibited between function name and open parenthesis '(' #458: FILE: drivers/net/sfc/base/mcdi_mon.c:253: + memcpy(stat_maskp, stat_mask, sizeof (stat_mask)); CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #462: FILE: drivers/net/sfc/base/mcdi_mon.c:257: + __checkReturn efx_rc_t CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #469: FILE: drivers/net/sfc/base/mcdi_mon.c:264: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #470: FILE: drivers/net/sfc/base/mcdi_mon.c:265: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #499: FILE: drivers/net/sfc/base/mcdi_mon.c:294: + return (ENODEV); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENODEV) #499: FILE: drivers/net/sfc/base/mcdi_mon.c:294: + return (ENODEV); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #506: FILE: drivers/net/sfc/base/mcdi_mon.c:301: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #511: FILE: drivers/net/sfc/base/mcdi_mon.c:306: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #541: FILE: drivers/net/sfc/base/mcdi_mon.c:336: + return (req.emr_rc); CHECK:SPACING: No space is necessary after a cast #559: FILE: drivers/net/sfc/base/mcdi_mon.c:354: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #559: FILE: drivers/net/sfc/base/mcdi_mon.c:354: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #579: FILE: drivers/net/sfc/base/mcdi_mon.c:374: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #584: FILE: drivers/net/sfc/base/mcdi_mon.c:379: + return (rc); CHECK:SPACING: No space is necessary after a cast #604: FILE: drivers/net/sfc/base/mcdi_mon.c:399: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #604: FILE: drivers/net/sfc/base/mcdi_mon.c:399: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #635: FILE: drivers/net/sfc/base/mcdi_mon.c:430: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #644: FILE: drivers/net/sfc/base/mcdi_mon.c:439: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #653: FILE: drivers/net/sfc/base/mcdi_mon.c:448: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #657: FILE: drivers/net/sfc/base/mcdi_mon.c:452: + if ((rc = efx_mcdi_read_sensors(enp, esmp, size)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #667: FILE: drivers/net/sfc/base/mcdi_mon.c:462: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #672: FILE: drivers/net/sfc/base/mcdi_mon.c:467: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #679: FILE: drivers/net/sfc/base/mcdi_mon.c:474: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #706: FILE: drivers/net/sfc/base/mcdi_mon.c:501: + if ((rc = efx_mcdi_sensor_info_npages(enp, &npages)) != 0) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #710: FILE: drivers/net/sfc/base/mcdi_mon.c:505: + encp->enc_mcdi_sensor_mask_size = npages * sizeof (uint32_t); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #723: FILE: drivers/net/sfc/base/mcdi_mon.c:518: + if ((rc = efx_mcdi_sensor_info(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #734: FILE: drivers/net/sfc/base/mcdi_mon.c:529: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #751: FILE: drivers/net/sfc/base/mcdi_mon.c:546: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #758: FILE: drivers/net/sfc/base/mcdi_mon.c:553: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); WARNING:LEADING_SPACE: please, no spaces at the start of a line #822: FILE: drivers/net/sfc/base/mcdi_mon.h:46: + __in^I^Iefx_nic_t *enp);$ total: 15 errors, 9 warnings, 12 checks, 724 lines checked