From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 919C7FA31; Tue, 29 Nov 2016 17:31:23 +0100 (CET) In-Reply-To: <1480436367-20749-22-git-send-email-arybchenko@solarflare.com> References: <1480436367-20749-22-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161129163123.919C7FA31@dpdk.org> Date: Tue, 29 Nov 2016 17:31:23 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH v2 21/55] net/sfc: import libefx RSS support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 16:31:23 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17308 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #126: FILE: drivers/net/sfc/base/ef10_impl.h:586: +extern __checkReturn efx_rc_t CHECK:SPACING: No space is necessary after a cast #196: FILE: drivers/net/sfc/base/ef10_rx.c:185: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #196: FILE: drivers/net/sfc/base/ef10_rx.c:185: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #229: FILE: drivers/net/sfc/base/ef10_rx.c:218: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #242: FILE: drivers/net/sfc/base/ef10_rx.c:231: + return (rc); CHECK:SPACING: No space is necessary after a cast #262: FILE: drivers/net/sfc/base/ef10_rx.c:251: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #262: FILE: drivers/net/sfc/base/ef10_rx.c:251: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #278: FILE: drivers/net/sfc/base/ef10_rx.c:267: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #285: FILE: drivers/net/sfc/base/ef10_rx.c:274: + return (rc); CHECK:SPACING: No space is necessary after a cast #306: FILE: drivers/net/sfc/base/ef10_rx.c:295: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #306: FILE: drivers/net/sfc/base/ef10_rx.c:295: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #333: FILE: drivers/net/sfc/base/ef10_rx.c:322: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #340: FILE: drivers/net/sfc/base/ef10_rx.c:329: + return (rc); CHECK:SPACING: No space is necessary after a cast #362: FILE: drivers/net/sfc/base/ef10_rx.c:351: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #362: FILE: drivers/net/sfc/base/ef10_rx.c:351: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #388: FILE: drivers/net/sfc/base/ef10_rx.c:377: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #397: FILE: drivers/net/sfc/base/ef10_rx.c:386: + return (rc); CHECK:SPACING: No space is necessary after a cast #420: FILE: drivers/net/sfc/base/ef10_rx.c:409: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #420: FILE: drivers/net/sfc/base/ef10_rx.c:409: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #446: FILE: drivers/net/sfc/base/ef10_rx.c:435: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #453: FILE: drivers/net/sfc/base/ef10_rx.c:442: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #513: FILE: drivers/net/sfc/base/ef10_rx.c:510: + if ((rc = efx_mcdi_rss_context_set_flags(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #517: FILE: drivers/net/sfc/base/ef10_rx.c:514: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #526: FILE: drivers/net/sfc/base/ef10_rx.c:523: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #544: FILE: drivers/net/sfc/base/ef10_rx.c:541: + if ((rc = efx_mcdi_rss_context_set_key(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #548: FILE: drivers/net/sfc/base/ef10_rx.c:545: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #555: FILE: drivers/net/sfc/base/ef10_rx.c:552: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #573: FILE: drivers/net/sfc/base/ef10_rx.c:570: + if ((rc = efx_mcdi_rss_context_set_table(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #577: FILE: drivers/net/sfc/base/ef10_rx.c:574: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #584: FILE: drivers/net/sfc/base/ef10_rx.c:581: + return (rc); WARNING:MISSING_BREAK: Possible switch case/default not preceeded by break or fallthrough comment #611: FILE: drivers/net/sfc/base/ef10_rx.c:641: + default: ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #613: FILE: drivers/net/sfc/base/ef10_rx.c:643: + return (0); WARNING:BRACES: braces {} are not necessary for single statement blocks #626: FILE: drivers/net/sfc/base/ef10_rx.c:841: + if (enp->en_rss_support != EFX_RX_SCALE_UNAVAILABLE) { + (void) efx_mcdi_rss_context_free(enp, enp->en_rss_context); + } CHECK:SPACING: No space is necessary after a cast #627: FILE: drivers/net/sfc/base/ef10_rx.c:842: + (void) efx_mcdi_rss_context_free(enp, enp->en_rss_context); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #897: FILE: drivers/net/sfc/base/efx_rx.c:300: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #902: FILE: drivers/net/sfc/base/efx_rx.c:305: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #923: FILE: drivers/net/sfc/base/efx_rx.c:326: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #928: FILE: drivers/net/sfc/base/efx_rx.c:331: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #945: FILE: drivers/net/sfc/base/efx_rx.c:348: + if ((rc = erxop->erxo_scale_mode_set(enp, alg, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #950: FILE: drivers/net/sfc/base/efx_rx.c:353: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #954: FILE: drivers/net/sfc/base/efx_rx.c:357: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #971: FILE: drivers/net/sfc/base/efx_rx.c:374: + if ((rc = erxop->erxo_scale_key_set(enp, key, n)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #974: FILE: drivers/net/sfc/base/efx_rx.c:377: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #979: FILE: drivers/net/sfc/base/efx_rx.c:382: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #996: FILE: drivers/net/sfc/base/efx_rx.c:399: + if ((rc = erxop->erxo_scale_tbl_set(enp, table, n)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #999: FILE: drivers/net/sfc/base/efx_rx.c:402: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1004: FILE: drivers/net/sfc/base/efx_rx.c:407: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1028: FILE: drivers/net/sfc/base/efx_rx.c:566: + return (erxop->erxo_prefix_hash(enp, func, buffer)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1089: FILE: drivers/net/sfc/base/efx_rx.c:748: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1098: FILE: drivers/net/sfc/base/efx_rx.c:757: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1212: FILE: drivers/net/sfc/base/efx_rx.c:871: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1223: FILE: drivers/net/sfc/base/efx_rx.c:882: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1278: FILE: drivers/net/sfc/base/efx_rx.c:937: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1285: FILE: drivers/net/sfc/base/efx_rx.c:944: + return (rc); WARNING:MISSING_BREAK: Possible switch case/default not preceeded by break or fallthrough comment #1312: FILE: drivers/net/sfc/base/efx_rx.c:980: + case EFX_RX_HASHALG_LFSR: ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1317: FILE: drivers/net/sfc/base/efx_rx.c:985: + return (0); total: 41 errors, 8 warnings, 7 checks, 1181 lines checked