* [dpdk-test-report] |WARNING| [PATCH v2 18/55] net/sfc: import libefx MAC statistics support
[not found] <1480436367-20749-19-git-send-email-arybchenko@solarflare.com>
@ 2016-11-29 16:32 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-11-29 16:32 UTC (permalink / raw)
To: test-report; +Cc: Andrew Rybchenko
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17311
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#123: FILE: drivers/net/sfc/base/ef10_impl.h:264:
+extern __checkReturn efx_rc_t
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg
#166: FILE: drivers/net/sfc/base/ef10_mac.c:463:
+ efx_nic_cfg_t *encp = &(enp->en_nic_cfg);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#167: FILE: drivers/net/sfc/base/ef10_mac.c:464:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#170: FILE: drivers/net/sfc/base/ef10_mac.c:467:
+ if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#179: FILE: drivers/net/sfc/base/ef10_mac.c:476:
+ if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#184: FILE: drivers/net/sfc/base/ef10_mac.c:481:
+ if ((rc = efx_mac_stats_mask_add_ranges(maskp,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#190: FILE: drivers/net/sfc/base/ef10_mac.c:487:
+ if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#200: FILE: drivers/net/sfc/base/ef10_mac.c:497:
+ if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#211: FILE: drivers/net/sfc/base/ef10_mac.c:508:
+ if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#216: FILE: drivers/net/sfc/base/ef10_mac.c:513:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#231: FILE: drivers/net/sfc/base/ef10_mac.c:528:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#235: FILE: drivers/net/sfc/base/ef10_mac.c:532:
+ EFSYS_MEM_READQ((_esmp), (_field) * sizeof (efx_qword_t), _eqp)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PKTS]
#259: FILE: drivers/net/sfc/base/ef10_mac.c:556:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PKTS]
#262: FILE: drivers/net/sfc/base/ef10_mac.c:559:
+ EFSYS_STAT_SUBR_QWORD(&(stat[EFX_MAC_TX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PAUSE_PKTS]
#265: FILE: drivers/net/sfc/base/ef10_mac.c:562:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_PAUSE_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_UNICST_PKTS]
#268: FILE: drivers/net/sfc/base/ef10_mac.c:565:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_UNICST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_MULTICST_PKTS]
#271: FILE: drivers/net/sfc/base/ef10_mac.c:568:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_MULTICST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_BRDCST_PKTS]
#274: FILE: drivers/net/sfc/base/ef10_mac.c:571:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_BRDCST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_OCTETS]
#277: FILE: drivers/net/sfc/base/ef10_mac.c:574:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_OCTETS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LE_64_PKTS]
#280: FILE: drivers/net/sfc/base/ef10_mac.c:577:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LE_64_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LE_64_PKTS]
#282: FILE: drivers/net/sfc/base/ef10_mac.c:579:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LE_64_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_65_TO_127_PKTS]
#285: FILE: drivers/net/sfc/base/ef10_mac.c:582:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_65_TO_127_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_128_TO_255_PKTS]
#288: FILE: drivers/net/sfc/base/ef10_mac.c:585:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_128_TO_255_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_256_TO_511_PKTS]
#291: FILE: drivers/net/sfc/base/ef10_mac.c:588:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_256_TO_511_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_512_TO_1023_PKTS]
#294: FILE: drivers/net/sfc/base/ef10_mac.c:591:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_512_TO_1023_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_1024_TO_15XX_PKTS]
#297: FILE: drivers/net/sfc/base/ef10_mac.c:594:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_1024_TO_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_GE_15XX_PKTS]
#300: FILE: drivers/net/sfc/base/ef10_mac.c:597:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_GE_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_GE_15XX_PKTS]
#302: FILE: drivers/net/sfc/base/ef10_mac.c:599:
+ EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_TX_GE_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_ERRORS]
#305: FILE: drivers/net/sfc/base/ef10_mac.c:602:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_SGL_COL_PKTS]
#308: FILE: drivers/net/sfc/base/ef10_mac.c:605:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_SGL_COL_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_MULT_COL_PKTS]
#312: FILE: drivers/net/sfc/base/ef10_mac.c:609:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_MULT_COL_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_EX_COL_PKTS]
#316: FILE: drivers/net/sfc/base/ef10_mac.c:613:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_EX_COL_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LATE_COL_PKTS]
#319: FILE: drivers/net/sfc/base/ef10_mac.c:616:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LATE_COL_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_DEF_PKTS]
#322: FILE: drivers/net/sfc/base/ef10_mac.c:619:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_DEF_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_EX_DEF_PKTS]
#326: FILE: drivers/net/sfc/base/ef10_mac.c:623:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_EX_DEF_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_OCTETS]
#330: FILE: drivers/net/sfc/base/ef10_mac.c:627:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_OCTETS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_PKTS]
#333: FILE: drivers/net/sfc/base/ef10_mac.c:630:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_UNICST_PKTS]
#336: FILE: drivers/net/sfc/base/ef10_mac.c:633:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_UNICST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_MULTICST_PKTS]
#339: FILE: drivers/net/sfc/base/ef10_mac.c:636:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_MULTICST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_BRDCST_PKTS]
#342: FILE: drivers/net/sfc/base/ef10_mac.c:639:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_BRDCST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_PAUSE_PKTS]
#345: FILE: drivers/net/sfc/base/ef10_mac.c:642:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_PAUSE_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LE_64_PKTS]
#348: FILE: drivers/net/sfc/base/ef10_mac.c:645:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_LE_64_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LE_64_PKTS]
#350: FILE: drivers/net/sfc/base/ef10_mac.c:647:
+ EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_RX_LE_64_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_65_TO_127_PKTS]
#353: FILE: drivers/net/sfc/base/ef10_mac.c:650:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_65_TO_127_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_128_TO_255_PKTS]
#356: FILE: drivers/net/sfc/base/ef10_mac.c:653:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_128_TO_255_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_256_TO_511_PKTS]
#359: FILE: drivers/net/sfc/base/ef10_mac.c:656:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_256_TO_511_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_512_TO_1023_PKTS]
#362: FILE: drivers/net/sfc/base/ef10_mac.c:659:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_512_TO_1023_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_1024_TO_15XX_PKTS]
#365: FILE: drivers/net/sfc/base/ef10_mac.c:662:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_1024_TO_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_GE_15XX_PKTS]
#368: FILE: drivers/net/sfc/base/ef10_mac.c:665:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_GE_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_GE_15XX_PKTS]
#370: FILE: drivers/net/sfc/base/ef10_mac.c:667:
+ EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_RX_GE_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_FCS_ERRORS]
#373: FILE: drivers/net/sfc/base/ef10_mac.c:670:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_FCS_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_DROP_EVENTS]
#376: FILE: drivers/net/sfc/base/ef10_mac.c:673:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_DROP_EVENTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_FALSE_CARRIER_ERRORS]
#379: FILE: drivers/net/sfc/base/ef10_mac.c:676:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_FALSE_CARRIER_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_SYMBOL_ERRORS]
#382: FILE: drivers/net/sfc/base/ef10_mac.c:679:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_SYMBOL_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_ALIGN_ERRORS]
#385: FILE: drivers/net/sfc/base/ef10_mac.c:682:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_ALIGN_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_INTERNAL_ERRORS]
#388: FILE: drivers/net/sfc/base/ef10_mac.c:685:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_INTERNAL_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_JABBER_PKTS]
#391: FILE: drivers/net/sfc/base/ef10_mac.c:688:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_JABBER_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE0_CHAR_ERR]
#394: FILE: drivers/net/sfc/base/ef10_mac.c:691:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE0_CHAR_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#395: FILE: drivers/net/sfc/base/ef10_mac.c:692:
+ &(value.eq_dword[0]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE1_CHAR_ERR]
#396: FILE: drivers/net/sfc/base/ef10_mac.c:693:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE1_CHAR_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#397: FILE: drivers/net/sfc/base/ef10_mac.c:694:
+ &(value.eq_dword[1]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE2_CHAR_ERR]
#400: FILE: drivers/net/sfc/base/ef10_mac.c:697:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE2_CHAR_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#401: FILE: drivers/net/sfc/base/ef10_mac.c:698:
+ &(value.eq_dword[0]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE3_CHAR_ERR]
#402: FILE: drivers/net/sfc/base/ef10_mac.c:699:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE3_CHAR_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#403: FILE: drivers/net/sfc/base/ef10_mac.c:700:
+ &(value.eq_dword[1]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE0_DISP_ERR]
#406: FILE: drivers/net/sfc/base/ef10_mac.c:703:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE0_DISP_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#407: FILE: drivers/net/sfc/base/ef10_mac.c:704:
+ &(value.eq_dword[0]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE1_DISP_ERR]
#408: FILE: drivers/net/sfc/base/ef10_mac.c:705:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE1_DISP_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#409: FILE: drivers/net/sfc/base/ef10_mac.c:706:
+ &(value.eq_dword[1]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE2_DISP_ERR]
#412: FILE: drivers/net/sfc/base/ef10_mac.c:709:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE2_DISP_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#413: FILE: drivers/net/sfc/base/ef10_mac.c:710:
+ &(value.eq_dword[0]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE3_DISP_ERR]
#414: FILE: drivers/net/sfc/base/ef10_mac.c:711:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE3_DISP_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#415: FILE: drivers/net/sfc/base/ef10_mac.c:712:
+ &(value.eq_dword[1]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_MATCH_FAULT]
#418: FILE: drivers/net/sfc/base/ef10_mac.c:715:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_MATCH_FAULT]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_NODESC_DROP_CNT]
#421: FILE: drivers/net/sfc/base/ef10_mac.c:718:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_NODESC_DROP_CNT]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_TRUNC_BB_OVERFLOW]
#425: FILE: drivers/net/sfc/base/ef10_mac.c:722:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_TRUNC_BB_OVERFLOW]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_DISCARD_BB_OVERFLOW]
#428: FILE: drivers/net/sfc/base/ef10_mac.c:725:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_DISCARD_BB_OVERFLOW]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_TRUNC_VFIFO_FULL]
#431: FILE: drivers/net/sfc/base/ef10_mac.c:728:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_TRUNC_VFIFO_FULL]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_DISCARD_VFIFO_FULL]
#434: FILE: drivers/net/sfc/base/ef10_mac.c:731:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_DISCARD_VFIFO_FULL]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_TRUNC_QBB]
#437: FILE: drivers/net/sfc/base/ef10_mac.c:734:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_TRUNC_QBB]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_DISCARD_QBB]
#440: FILE: drivers/net/sfc/base/ef10_mac.c:737:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_DISCARD_QBB]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_PM_DISCARD_MAPPING]
#443: FILE: drivers/net/sfc/base/ef10_mac.c:740:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_PM_DISCARD_MAPPING]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_Q_DISABLED_PKTS]
#447: FILE: drivers/net/sfc/base/ef10_mac.c:744:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_Q_DISABLED_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_DI_DROPPED_PKTS]
#450: FILE: drivers/net/sfc/base/ef10_mac.c:747:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_DI_DROPPED_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_STREAMING_PKTS]
#453: FILE: drivers/net/sfc/base/ef10_mac.c:750:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_STREAMING_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_HLB_FETCH]
#456: FILE: drivers/net/sfc/base/ef10_mac.c:753:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_HLB_FETCH]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RXDP_HLB_WAIT]
#459: FILE: drivers/net/sfc/base/ef10_mac.c:756:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RXDP_HLB_WAIT]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_UNICAST_PACKETS]
#465: FILE: drivers/net/sfc/base/ef10_mac.c:762:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_UNICAST_PACKETS]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_UNICAST_BYTES]
#470: FILE: drivers/net/sfc/base/ef10_mac.c:767:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_UNICAST_BYTES]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_MULTICAST_PACKETS]
#475: FILE: drivers/net/sfc/base/ef10_mac.c:772:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_MULTICAST_PACKETS]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_MULTICAST_BYTES]
#480: FILE: drivers/net/sfc/base/ef10_mac.c:777:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_MULTICAST_BYTES]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_BROADCAST_PACKETS]
#485: FILE: drivers/net/sfc/base/ef10_mac.c:782:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_BROADCAST_PACKETS]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_BROADCAST_BYTES]
#490: FILE: drivers/net/sfc/base/ef10_mac.c:787:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_BROADCAST_BYTES]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_BAD_PACKETS]
#495: FILE: drivers/net/sfc/base/ef10_mac.c:792:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_BAD_PACKETS]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_BAD_BYTES]
#499: FILE: drivers/net/sfc/base/ef10_mac.c:796:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_BAD_BYTES]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_RX_OVERFLOW]
#502: FILE: drivers/net/sfc/base/ef10_mac.c:799:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_RX_OVERFLOW]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_UNICAST_PACKETS]
#507: FILE: drivers/net/sfc/base/ef10_mac.c:804:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_UNICAST_PACKETS]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_UNICAST_BYTES]
#512: FILE: drivers/net/sfc/base/ef10_mac.c:809:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_UNICAST_BYTES]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_MULTICAST_PACKETS]
#517: FILE: drivers/net/sfc/base/ef10_mac.c:814:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_MULTICAST_PACKETS]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES]
#522: FILE: drivers/net/sfc/base/ef10_mac.c:819:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_MULTICAST_BYTES]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_BROADCAST_PACKETS]
#527: FILE: drivers/net/sfc/base/ef10_mac.c:824:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_BROADCAST_PACKETS]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES]
#532: FILE: drivers/net/sfc/base/ef10_mac.c:829:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_BROADCAST_BYTES]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_BAD_PACKETS]
#536: FILE: drivers/net/sfc/base/ef10_mac.c:833:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_BAD_PACKETS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_BAD_BYTES]
#539: FILE: drivers/net/sfc/base/ef10_mac.c:836:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_BAD_BYTES]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_VADAPTER_TX_OVERFLOW]
#542: FILE: drivers/net/sfc/base/ef10_mac.c:839:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_VADAPTER_TX_OVERFLOW]), &value);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#553: FILE: drivers/net/sfc/base/ef10_mac.c:850:
+ sizeof (generation_start)))
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#554: FILE: drivers/net/sfc/base/ef10_mac.c:851:
+ return (EAGAIN);
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#554: FILE: drivers/net/sfc/base/ef10_mac.c:851:
+ return (EAGAIN);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#559: FILE: drivers/net/sfc/base/ef10_mac.c:856:
+ return (0);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#575: FILE: drivers/net/sfc/base/ef10_nic.c:1376:
+ if ((rc = efx_mcdi_mac_stats_clear(enp)) != 0)
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#708: FILE: drivers/net/sfc/base/efx.h:537:
+#define EFX_MAC_STATS_MASK_BITS_PER_PAGE (8 * sizeof (uint32_t))
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_stat' - possible side-effects?
#727: FILE: drivers/net/sfc/base/efx.h:556:
+#define EFX_MAC_STAT_SUPPORTED(_mask, _stat) \
+ ((_mask)[(_stat) / EFX_MAC_STATS_MASK_BITS_PER_PAGE] & \
+ (1ULL << ((_stat) & (EFX_MAC_STATS_MASK_BITS_PER_PAGE - 1))))
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1012: FILE: drivers/net/sfc/base/efx_mac.c:606:
+ return (__efx_mac_stat_name[id]);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1023: FILE: drivers/net/sfc/base/efx_mac.c:617:
+ unsigned int mask_npages = mask_size / sizeof (*maskp);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1056: FILE: drivers/net/sfc/base/efx_mac.c:650:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1061: FILE: drivers/net/sfc/base/efx_mac.c:655:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1075: FILE: drivers/net/sfc/base/efx_mac.c:669:
+ if ((rc = efx_mac_stats_mask_add_range(maskp, mask_size,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1080: FILE: drivers/net/sfc/base/efx_mac.c:674:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1085: FILE: drivers/net/sfc/base/efx_mac.c:679:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1094: FILE: drivers/net/sfc/base/efx_mac.c:688:
+ efx_port_t *epp = &(enp->en_port);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1101: FILE: drivers/net/sfc/base/efx_mac.c:695:
+ EFSYS_ASSERT(mask_size % sizeof (maskp[0]) == 0);
CHECK:SPACING: No space is necessary after a cast
#1103: FILE: drivers/net/sfc/base/efx_mac.c:697:
+ (void) memset(maskp, 0, mask_size);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1105: FILE: drivers/net/sfc/base/efx_mac.c:699:
+ if ((rc = emop->emo_stats_get_mask(enp, maskp, mask_size)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1108: FILE: drivers/net/sfc/base/efx_mac.c:702:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1113: FILE: drivers/net/sfc/base/efx_mac.c:707:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1121: FILE: drivers/net/sfc/base/efx_mac.c:715:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1134: FILE: drivers/net/sfc/base/efx_mac.c:728:
+ if ((rc = emop->emo_stats_upload(enp, esmp)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1139: FILE: drivers/net/sfc/base/efx_mac.c:733:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1144: FILE: drivers/net/sfc/base/efx_mac.c:738:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1154: FILE: drivers/net/sfc/base/efx_mac.c:748:
+ efx_port_t *epp = &(enp->en_port);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1168: FILE: drivers/net/sfc/base/efx_mac.c:762:
+ if ((rc = emop->emo_stats_periodic(enp, esmp, period_ms, events)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1171: FILE: drivers/net/sfc/base/efx_mac.c:765:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1178: FILE: drivers/net/sfc/base/efx_mac.c:772:
+ return (rc);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port
#1189: FILE: drivers/net/sfc/base/efx_mac.c:783:
+ efx_port_t *epp = &(enp->en_port);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1201: FILE: drivers/net/sfc/base/efx_mac.c:795:
+ return (rc);
CHECK:SPACING: No space is necessary after a cast
#1243: FILE: drivers/net/sfc/base/efx_mcdi.c:1737:
+ (void) memset(payload, 0, sizeof (payload));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1243: FILE: drivers/net/sfc/base/efx_mcdi.c:1737:
+ (void) memset(payload, 0, sizeof (payload));
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1259: FILE: drivers/net/sfc/base/efx_mcdi.c:1753:
+ int bytes = MC_CMD_MAC_NSTATS * sizeof (uint64_t);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1261: FILE: drivers/net/sfc/base/efx_mcdi.c:1755:
+ EFX_STATIC_ASSERT(MC_CMD_MAC_NSTATS * sizeof (uint64_t) <=
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1292: FILE: drivers/net/sfc/base/efx_mcdi.c:1786:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1297: FILE: drivers/net/sfc/base/efx_mcdi.c:1791:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1306: FILE: drivers/net/sfc/base/efx_mcdi.c:1800:
+ if ((rc = efx_mcdi_mac_stats(enp, NULL, EFX_STATS_CLEAR)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1309: FILE: drivers/net/sfc/base/efx_mcdi.c:1803:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1314: FILE: drivers/net/sfc/base/efx_mcdi.c:1808:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1329: FILE: drivers/net/sfc/base/efx_mcdi.c:1823:
+ if ((rc = efx_mcdi_mac_stats(enp, esmp, EFX_STATS_UPLOAD)) != 0)
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1332: FILE: drivers/net/sfc/base/efx_mcdi.c:1826:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1337: FILE: drivers/net/sfc/base/efx_mcdi.c:1831:
+ return (rc);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1365: FILE: drivers/net/sfc/base/efx_mcdi.c:1859:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1370: FILE: drivers/net/sfc/base/efx_mcdi.c:1864:
+ return (rc);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1431: FILE: drivers/net/sfc/base/siena_mac.c:214:
+ if ((rc = efx_mac_stats_mask_add_ranges(maskp, mask_size,
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1435: FILE: drivers/net/sfc/base/siena_mac.c:218:
+ return (0);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1440: FILE: drivers/net/sfc/base/siena_mac.c:223:
+ return (rc);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1444: FILE: drivers/net/sfc/base/siena_mac.c:227:
+ EFSYS_MEM_READQ((_esmp), (_field) * sizeof (efx_qword_t), _eqp)
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PKTS]
#1467: FILE: drivers/net/sfc/base/siena_mac.c:250:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PKTS]
#1469: FILE: drivers/net/sfc/base/siena_mac.c:252:
+ EFSYS_STAT_SUBR_QWORD(&(stat[EFX_MAC_TX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_PAUSE_PKTS]
#1472: FILE: drivers/net/sfc/base/siena_mac.c:255:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_PAUSE_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_UNICST_PKTS]
#1475: FILE: drivers/net/sfc/base/siena_mac.c:258:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_UNICST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_MULTICST_PKTS]
#1478: FILE: drivers/net/sfc/base/siena_mac.c:261:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_MULTICST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_BRDCST_PKTS]
#1481: FILE: drivers/net/sfc/base/siena_mac.c:264:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_BRDCST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_OCTETS]
#1484: FILE: drivers/net/sfc/base/siena_mac.c:267:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_OCTETS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LE_64_PKTS]
#1487: FILE: drivers/net/sfc/base/siena_mac.c:270:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LE_64_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LE_64_PKTS]
#1489: FILE: drivers/net/sfc/base/siena_mac.c:272:
+ EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_TX_LE_64_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_65_TO_127_PKTS]
#1492: FILE: drivers/net/sfc/base/siena_mac.c:275:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_65_TO_127_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_128_TO_255_PKTS]
#1495: FILE: drivers/net/sfc/base/siena_mac.c:278:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_128_TO_255_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_256_TO_511_PKTS]
#1498: FILE: drivers/net/sfc/base/siena_mac.c:281:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_256_TO_511_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_512_TO_1023_PKTS]
#1501: FILE: drivers/net/sfc/base/siena_mac.c:284:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_512_TO_1023_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_1024_TO_15XX_PKTS]
#1504: FILE: drivers/net/sfc/base/siena_mac.c:287:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_1024_TO_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_GE_15XX_PKTS]
#1507: FILE: drivers/net/sfc/base/siena_mac.c:290:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_GE_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_GE_15XX_PKTS]
#1509: FILE: drivers/net/sfc/base/siena_mac.c:292:
+ EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_TX_GE_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_ERRORS]
#1512: FILE: drivers/net/sfc/base/siena_mac.c:295:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_SGL_COL_PKTS]
#1515: FILE: drivers/net/sfc/base/siena_mac.c:298:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_SGL_COL_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_MULT_COL_PKTS]
#1519: FILE: drivers/net/sfc/base/siena_mac.c:302:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_MULT_COL_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_EX_COL_PKTS]
#1523: FILE: drivers/net/sfc/base/siena_mac.c:306:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_EX_COL_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_LATE_COL_PKTS]
#1526: FILE: drivers/net/sfc/base/siena_mac.c:309:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_LATE_COL_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_DEF_PKTS]
#1529: FILE: drivers/net/sfc/base/siena_mac.c:312:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_DEF_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_TX_EX_DEF_PKTS]
#1533: FILE: drivers/net/sfc/base/siena_mac.c:316:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_TX_EX_DEF_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_OCTETS]
#1537: FILE: drivers/net/sfc/base/siena_mac.c:320:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_OCTETS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_PKTS]
#1540: FILE: drivers/net/sfc/base/siena_mac.c:323:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_UNICST_PKTS]
#1543: FILE: drivers/net/sfc/base/siena_mac.c:326:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_UNICST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_MULTICST_PKTS]
#1546: FILE: drivers/net/sfc/base/siena_mac.c:329:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_MULTICST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_BRDCST_PKTS]
#1549: FILE: drivers/net/sfc/base/siena_mac.c:332:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_BRDCST_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_PAUSE_PKTS]
#1552: FILE: drivers/net/sfc/base/siena_mac.c:335:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_PAUSE_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LE_64_PKTS]
#1555: FILE: drivers/net/sfc/base/siena_mac.c:338:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_LE_64_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LE_64_PKTS]
#1557: FILE: drivers/net/sfc/base/siena_mac.c:340:
+ EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_RX_LE_64_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_65_TO_127_PKTS]
#1560: FILE: drivers/net/sfc/base/siena_mac.c:343:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_65_TO_127_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_128_TO_255_PKTS]
#1563: FILE: drivers/net/sfc/base/siena_mac.c:346:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_128_TO_255_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_256_TO_511_PKTS]
#1566: FILE: drivers/net/sfc/base/siena_mac.c:349:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_256_TO_511_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_512_TO_1023_PKTS]
#1569: FILE: drivers/net/sfc/base/siena_mac.c:352:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_512_TO_1023_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_1024_TO_15XX_PKTS]
#1572: FILE: drivers/net/sfc/base/siena_mac.c:355:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_1024_TO_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_GE_15XX_PKTS]
#1575: FILE: drivers/net/sfc/base/siena_mac.c:358:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_GE_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_GE_15XX_PKTS]
#1577: FILE: drivers/net/sfc/base/siena_mac.c:360:
+ EFSYS_STAT_INCR_QWORD(&(stat[EFX_MAC_RX_GE_15XX_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_FCS_ERRORS]
#1580: FILE: drivers/net/sfc/base/siena_mac.c:363:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_FCS_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_DROP_EVENTS]
#1583: FILE: drivers/net/sfc/base/siena_mac.c:366:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_DROP_EVENTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_FALSE_CARRIER_ERRORS]
#1586: FILE: drivers/net/sfc/base/siena_mac.c:369:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_FALSE_CARRIER_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_SYMBOL_ERRORS]
#1589: FILE: drivers/net/sfc/base/siena_mac.c:372:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_SYMBOL_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_ALIGN_ERRORS]
#1592: FILE: drivers/net/sfc/base/siena_mac.c:375:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_ALIGN_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_INTERNAL_ERRORS]
#1595: FILE: drivers/net/sfc/base/siena_mac.c:378:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_INTERNAL_ERRORS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_JABBER_PKTS]
#1598: FILE: drivers/net/sfc/base/siena_mac.c:381:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_JABBER_PKTS]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE0_CHAR_ERR]
#1601: FILE: drivers/net/sfc/base/siena_mac.c:384:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE0_CHAR_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#1602: FILE: drivers/net/sfc/base/siena_mac.c:385:
+ &(value.eq_dword[0]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE1_CHAR_ERR]
#1603: FILE: drivers/net/sfc/base/siena_mac.c:386:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE1_CHAR_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#1604: FILE: drivers/net/sfc/base/siena_mac.c:387:
+ &(value.eq_dword[1]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE2_CHAR_ERR]
#1607: FILE: drivers/net/sfc/base/siena_mac.c:390:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE2_CHAR_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#1608: FILE: drivers/net/sfc/base/siena_mac.c:391:
+ &(value.eq_dword[0]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE3_CHAR_ERR]
#1609: FILE: drivers/net/sfc/base/siena_mac.c:392:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE3_CHAR_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#1610: FILE: drivers/net/sfc/base/siena_mac.c:393:
+ &(value.eq_dword[1]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE0_DISP_ERR]
#1613: FILE: drivers/net/sfc/base/siena_mac.c:396:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE0_DISP_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#1614: FILE: drivers/net/sfc/base/siena_mac.c:397:
+ &(value.eq_dword[0]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE1_DISP_ERR]
#1615: FILE: drivers/net/sfc/base/siena_mac.c:398:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE1_DISP_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#1616: FILE: drivers/net/sfc/base/siena_mac.c:399:
+ &(value.eq_dword[1]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE2_DISP_ERR]
#1619: FILE: drivers/net/sfc/base/siena_mac.c:402:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE2_DISP_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[0]
#1620: FILE: drivers/net/sfc/base/siena_mac.c:403:
+ &(value.eq_dword[0]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_LANE3_DISP_ERR]
#1621: FILE: drivers/net/sfc/base/siena_mac.c:404:
+ EFSYS_STAT_SET_DWORD(&(stat[EFX_MAC_RX_LANE3_DISP_ERR]),
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around value.eq_dword[1]
#1622: FILE: drivers/net/sfc/base/siena_mac.c:405:
+ &(value.eq_dword[1]));
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_MATCH_FAULT]
#1625: FILE: drivers/net/sfc/base/siena_mac.c:408:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_MATCH_FAULT]), &value);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around stat[EFX_MAC_RX_NODESC_DROP_CNT]
#1628: FILE: drivers/net/sfc/base/siena_mac.c:411:
+ EFSYS_STAT_SET_QWORD(&(stat[EFX_MAC_RX_NODESC_DROP_CNT]), &value);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#1638: FILE: drivers/net/sfc/base/siena_mac.c:421:
+ sizeof (generation_start)))
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1639: FILE: drivers/net/sfc/base/siena_mac.c:422:
+ return (EAGAIN);
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EAGAIN)
#1639: FILE: drivers/net/sfc/base/siena_mac.c:422:
+ return (EAGAIN);
ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#1644: FILE: drivers/net/sfc/base/siena_mac.c:427:
+ return (0);
ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#1662: FILE: drivers/net/sfc/base/siena_nic.c:215:
+ if ((rc = efx_mcdi_mac_stats_clear(enp)) != 0)
total: 43 errors, 12 warnings, 166 checks, 1510 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-11-29 16:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1480436367-20749-19-git-send-email-arybchenko@solarflare.com>
2016-11-29 16:32 ` [dpdk-test-report] |WARNING| [PATCH v2 18/55] net/sfc: import libefx MAC statistics support checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).