From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id 891C85584; Tue, 29 Nov 2016 17:33:33 +0100 (CET) In-Reply-To: <1480436367-20749-11-git-send-email-arybchenko@solarflare.com> References: <1480436367-20749-11-git-send-email-arybchenko@solarflare.com> To: test-report@dpdk.org Cc: Andrew Rybchenko Message-Id: <20161129163333.891C85584@dpdk.org> Date: Tue, 29 Nov 2016 17:33:33 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH v2 10/55] net/sfc: import libefx SFN7xxx family support X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Nov 2016 16:33:33 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17314 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn> #172: FILE: drivers/net/sfc/base/ef10_ev.c:45: +static __checkReturn boolean_t CHECK:SPACING: No space is necessary after a cast #220: FILE: drivers/net/sfc/base/ef10_ev.c:93: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #220: FILE: drivers/net/sfc/base/ef10_ev.c:93: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #244: FILE: drivers/net/sfc/base/ef10_ev.c:117: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #251: FILE: drivers/net/sfc/base/ef10_ev.c:124: + return (rc); CHECK:SPACING: No space is necessary after a cast #283: FILE: drivers/net/sfc/base/ef10_ev.c:156: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #283: FILE: drivers/net/sfc/base/ef10_ev.c:156: + (void) memset(payload, 0, sizeof (payload)); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #336: FILE: drivers/net/sfc/base/ef10_ev.c:209: + if ((rc = efx_ev_usecs_to_ticks(enp, us, &ticks)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #375: FILE: drivers/net/sfc/base/ef10_ev.c:248: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #388: FILE: drivers/net/sfc/base/ef10_ev.c:261: + return (rc); CHECK:SPACING: No space is necessary after a cast #420: FILE: drivers/net/sfc/base/ef10_ev.c:293: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #420: FILE: drivers/net/sfc/base/ef10_ev.c:293: + (void) memset(payload, 0, sizeof (payload)); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #463: FILE: drivers/net/sfc/base/ef10_ev.c:336: + if ((rc = efx_ev_usecs_to_ticks(enp, us, &ticks)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #505: FILE: drivers/net/sfc/base/ef10_ev.c:378: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #518: FILE: drivers/net/sfc/base/ef10_ev.c:391: + return (rc); CHECK:SPACING: No space is necessary after a cast #531: FILE: drivers/net/sfc/base/ef10_ev.c:404: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #531: FILE: drivers/net/sfc/base/ef10_ev.c:404: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #547: FILE: drivers/net/sfc/base/ef10_ev.c:420: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #552: FILE: drivers/net/sfc/base/ef10_ev.c:425: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #562: FILE: drivers/net/sfc/base/ef10_ev.c:435: + return (0); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #583: FILE: drivers/net/sfc/base/ef10_ev.c:456: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #662: FILE: drivers/net/sfc/base/ef10_ev.c:535: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #675: FILE: drivers/net/sfc/base/ef10_ev.c:548: + return (rc); CHECK:SPACING: No space is necessary after a cast #687: FILE: drivers/net/sfc/base/ef10_ev.c:560: + (void) efx_mcdi_fini_evq(eep->ee_enp, eep->ee_index); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #728: FILE: drivers/net/sfc/base/ef10_ev.c:601: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #762: FILE: drivers/net/sfc/base/ef10_ev.c:635: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #767: FILE: drivers/net/sfc/base/ef10_ev.c:640: + return (rc); CHECK:SPACING: No space is necessary after a cast #783: FILE: drivers/net/sfc/base/ef10_ev.c:656: + (void) efx_mcdi_driver_event(enp, eep->ee_index, event); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #792: FILE: drivers/net/sfc/base/ef10_ev.c:665: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); WARNING:BRACES: braces {} are not necessary for any arm of this statement #813: FILE: drivers/net/sfc/base/ef10_ev.c:686: + if (us == 0) { [...] + } else { [...] ERROR:ASSIGN_IN_IF: do not use assignment in if condition #828: FILE: drivers/net/sfc/base/ef10_ev.c:701: + if ((rc = efx_ev_usecs_to_ticks(enp, us, &ticks)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #848: FILE: drivers/net/sfc/base/ef10_ev.c:721: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #857: FILE: drivers/net/sfc/base/ef10_ev.c:730: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #887: FILE: drivers/net/sfc/base/ef10_ev.c:760: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #903: FILE: drivers/net/sfc/base/ef10_ev.c:776: + return (B_FALSE); WARNING:BRACES: braces {} are not necessary for any arm of this statement #972: FILE: drivers/net/sfc/base/ef10_ev.c:845: + if (EFX_QWORD_FIELD(*eqp, ESF_DZ_RX_IPCKSUM_ERR)) { [...] + } else { [...] WARNING:BRACES: braces {} are not necessary for any arm of this statement #1010: FILE: drivers/net/sfc/base/ef10_ev.c:883: + if (EFX_QWORD_FIELD(*eqp, ESF_DZ_RX_TCPUDP_CKSUM_ERR)) { [...] + } else { [...] ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1025: FILE: drivers/net/sfc/base/ef10_ev.c:898: + return (should_abort); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1044: FILE: drivers/net/sfc/base/ef10_ev.c:917: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1048: FILE: drivers/net/sfc/base/ef10_ev.c:921: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1060: FILE: drivers/net/sfc/base/ef10_ev.c:933: + return (should_abort); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1110: FILE: drivers/net/sfc/base/ef10_ev.c:983: + return (should_abort); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1132: FILE: drivers/net/sfc/base/ef10_ev.c:1005: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1138: FILE: drivers/net/sfc/base/ef10_ev.c:1011: + return (should_abort); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1315: FILE: drivers/net/sfc/base/ef10_ev.c:1188: + return (should_abort); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1414: FILE: drivers/net/sfc/base/ef10_filter.c:55: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1416: FILE: drivers/net/sfc/base/ef10_filter.c:57: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1425: FILE: drivers/net/sfc/base/ef10_filter.c:66: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1427: FILE: drivers/net/sfc/base/ef10_filter.c:68: + return (B_FALSE); CHECK:MACRO_ARG_REUSE: Macro argument reuse 'match' - possible side-effects? #1483: FILE: drivers/net/sfc/base/ef10_filter.c:124: +#define MATCH_MASK(match) (EFX_MASK32(match) << EFX_LOW_BIT(match)) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1506: FILE: drivers/net/sfc/base/ef10_filter.c:147: + EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (ef10_filter_table_t), eftp); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1515: FILE: drivers/net/sfc/base/ef10_filter.c:156: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1520: FILE: drivers/net/sfc/base/ef10_filter.c:161: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1531: FILE: drivers/net/sfc/base/ef10_filter.c:172: + EFSYS_KMEM_FREE(enp->en_esip, sizeof (ef10_filter_table_t), WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1549: FILE: drivers/net/sfc/base/ef10_filter.c:190: + memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1635: FILE: drivers/net/sfc/base/ef10_filter.c:276: + EFX_STATIC_ASSERT(sizeof (spec->efs_rem_host) == WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1637: FILE: drivers/net/sfc/base/ef10_filter.c:278: + EFX_STATIC_ASSERT(sizeof (spec->efs_loc_host) == ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1663: FILE: drivers/net/sfc/base/ef10_filter.c:304: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1672: FILE: drivers/net/sfc/base/ef10_filter.c:313: + return (rc); CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1674: FILE: drivers/net/sfc/base/ef10_filter.c:315: + +} WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1687: FILE: drivers/net/sfc/base/ef10_filter.c:328: + memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1724: FILE: drivers/net/sfc/base/ef10_filter.c:365: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1734: FILE: drivers/net/sfc/base/ef10_filter.c:375: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1744: FILE: drivers/net/sfc/base/ef10_filter.c:385: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1746: FILE: drivers/net/sfc/base/ef10_filter.c:387: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1748: FILE: drivers/net/sfc/base/ef10_filter.c:389: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1750: FILE: drivers/net/sfc/base/ef10_filter.c:391: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1752: FILE: drivers/net/sfc/base/ef10_filter.c:393: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1754: FILE: drivers/net/sfc/base/ef10_filter.c:395: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1756: FILE: drivers/net/sfc/base/ef10_filter.c:397: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1758: FILE: drivers/net/sfc/base/ef10_filter.c:399: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1760: FILE: drivers/net/sfc/base/ef10_filter.c:401: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1762: FILE: drivers/net/sfc/base/ef10_filter.c:403: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1764: FILE: drivers/net/sfc/base/ef10_filter.c:405: + return (B_FALSE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1766: FILE: drivers/net/sfc/base/ef10_filter.c:407: + return (B_TRUE); CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #1768: FILE: drivers/net/sfc/base/ef10_filter.c:409: + +} ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1778: FILE: drivers/net/sfc/base/ef10_filter.c:419: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1782: FILE: drivers/net/sfc/base/ef10_filter.c:423: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1784: FILE: drivers/net/sfc/base/ef10_filter.c:425: + return (B_FALSE); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1791: FILE: drivers/net/sfc/base/ef10_filter.c:432: + EFX_STATIC_ASSERT((sizeof (efx_filter_spec_t) % sizeof (uint32_t)) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1791: FILE: drivers/net/sfc/base/ef10_filter.c:432: + EFX_STATIC_ASSERT((sizeof (efx_filter_spec_t) % sizeof (uint32_t)) WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1794: FILE: drivers/net/sfc/base/ef10_filter.c:435: + sizeof (uint32_t)) == 0); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1802: FILE: drivers/net/sfc/base/ef10_filter.c:443: + (sizeof (efx_filter_spec_t) - WARNING:SPACING: space prohibited between function name and open parenthesis '(' #1804: FILE: drivers/net/sfc/base/ef10_filter.c:445: + sizeof (uint32_t), 0)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1819: FILE: drivers/net/sfc/base/ef10_filter.c:460: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1826: FILE: drivers/net/sfc/base/ef10_filter.c:467: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1829: FILE: drivers/net/sfc/base/ef10_filter.c:470: + return (B_TRUE); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1832: FILE: drivers/net/sfc/base/ef10_filter.c:473: + return (B_FALSE); CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #1850: FILE: drivers/net/sfc/base/ef10_filter.c:491: + for (tbl_id = 0; tbl_id < EFX_EF10_FILTER_TBL_ROWS; tbl_id++) { + ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1889: FILE: drivers/net/sfc/base/ef10_filter.c:530: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #1894: FILE: drivers/net/sfc/base/ef10_filter.c:535: + return (rc); WARNING:BRACES: braces {} are not necessary for single statement blocks #1947: FILE: drivers/net/sfc/base/ef10_filter.c:588: + if (ins_index < 0) { + ins_index = i; + } CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #2002: FILE: drivers/net/sfc/base/ef10_filter.c:643: + + } WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2005: FILE: drivers/net/sfc/base/ef10_filter.c:646: + EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*spec), saved_spec); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2060: FILE: drivers/net/sfc/base/ef10_filter.c:701: + return (0); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2066: FILE: drivers/net/sfc/base/ef10_filter.c:707: + EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec), saved_spec); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2084: FILE: drivers/net/sfc/base/ef10_filter.c:725: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2099: FILE: drivers/net/sfc/base/ef10_filter.c:740: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2104: FILE: drivers/net/sfc/base/ef10_filter.c:745: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2132: FILE: drivers/net/sfc/base/ef10_filter.c:773: + if ((spec = ef10_filter_entry_spec(table, filter_idx)) != NULL) { WARNING:BRACES: braces {} are not necessary for single statement blocks #2132: FILE: drivers/net/sfc/base/ef10_filter.c:773: + if ((spec = ef10_filter_entry_spec(table, filter_idx)) != NULL) { + ef10_filter_set_entry_busy(table, filter_idx); + } WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2162: FILE: drivers/net/sfc/base/ef10_filter.c:803: + EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec), spec); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2168: FILE: drivers/net/sfc/base/ef10_filter.c:809: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2176: FILE: drivers/net/sfc/base/ef10_filter.c:817: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2223: FILE: drivers/net/sfc/base/ef10_filter.c:864: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2234: FILE: drivers/net/sfc/base/ef10_filter.c:875: + return (rc); CHECK:SPACING: No space is necessary after a cast #2251: FILE: drivers/net/sfc/base/ef10_filter.c:892: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2251: FILE: drivers/net/sfc/base/ef10_filter.c:892: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2281: FILE: drivers/net/sfc/base/ef10_filter.c:922: + (*length) * sizeof (uint32_t)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #2282: FILE: drivers/net/sfc/base/ef10_filter.c:923: + EFX_STATIC_ASSERT(sizeof (uint32_t) == ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2307: FILE: drivers/net/sfc/base/ef10_filter.c:948: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2314: FILE: drivers/net/sfc/base/ef10_filter.c:955: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2325: FILE: drivers/net/sfc/base/ef10_filter.c:966: + if ((rc = efx_mcdi_get_parser_disp_info(enp, list, length)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2328: FILE: drivers/net/sfc/base/ef10_filter.c:969: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2333: FILE: drivers/net/sfc/base/ef10_filter.c:974: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2361: FILE: drivers/net/sfc/base/ef10_filter.c:1002: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2365: FILE: drivers/net/sfc/base/ef10_filter.c:1006: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2391: FILE: drivers/net/sfc/base/ef10_filter.c:1032: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2395: FILE: drivers/net/sfc/base/ef10_filter.c:1036: + return (rc); CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #2403: FILE: drivers/net/sfc/base/ef10_filter.c:1044: + __in_ecount(6*count) uint8_t const *addrs, ^ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #2450: FILE: drivers/net/sfc/base/ef10_filter.c:1091: + + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2478: FILE: drivers/net/sfc/base/ef10_filter.c:1119: + return (0); CHECK:SPACING: No space is necessary after a cast #2484: FILE: drivers/net/sfc/base/ef10_filter.c:1125: + (void) ef10_filter_delete_internal(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2492: FILE: drivers/net/sfc/base/ef10_filter.c:1133: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2522: FILE: drivers/net/sfc/base/ef10_filter.c:1163: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2527: FILE: drivers/net/sfc/base/ef10_filter.c:1168: + return (rc); WARNING:BRACES: braces {} are not necessary for single statement blocks #2538: FILE: drivers/net/sfc/base/ef10_filter.c:1179: + if (ef10_filter_entry_is_auto_old(table, i)) { + (void) ef10_filter_delete_internal(enp, i); + } CHECK:SPACING: No space is necessary after a cast #2539: FILE: drivers/net/sfc/base/ef10_filter.c:1180: + (void) ef10_filter_delete_internal(enp, i); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2571: FILE: drivers/net/sfc/base/ef10_filter.c:1212: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2576: FILE: drivers/net/sfc/base/ef10_filter.c:1217: + return (rc); CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #2578: FILE: drivers/net/sfc/base/ef10_filter.c:1219: + +} CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #2595: FILE: drivers/net/sfc/base/ef10_filter.c:1236: + __in_ecount(6*count) uint8_t const *addrs, ^ CHECK:SPACING: No space is necessary after a cast #2614: FILE: drivers/net/sfc/base/ef10_filter.c:1255: + (void) ef10_filter_delete_internal(enp, CHECK:SPACING: No space is necessary after a cast #2620: FILE: drivers/net/sfc/base/ef10_filter.c:1261: + (void) ef10_filter_delete_internal(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2625: FILE: drivers/net/sfc/base/ef10_filter.c:1266: + return (0); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #2695: FILE: drivers/net/sfc/base/ef10_filter.c:1336: + if ((rc = ef10_filter_get_workarounds(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2768: FILE: drivers/net/sfc/base/ef10_filter.c:1409: + return (rc); WARNING:BRACES: braces {} are not necessary for single statement blocks #2781: FILE: drivers/net/sfc/base/ef10_filter.c:1422: + if (ef10_filter_entry_is_auto_old(table, i)) { + ef10_filter_set_entry_not_auto_old(table, i); + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #2786: FILE: drivers/net/sfc/base/ef10_filter.c:1427: + return (rc); CHECK:SPACING: No space is necessary after a cast #3288: FILE: drivers/net/sfc/base/ef10_impl.h:454: +#define EFX_PIOBUF_HANDLE_INVALID ((efx_piobuf_handle_t) -1) CHECK:SPACING: spaces preferred around that '*' (ctx:VxV) #3458: FILE: drivers/net/sfc/base/ef10_impl.h:624: + __in_ecount(6*count) uint8_t const *addrs, ^ ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3602: FILE: drivers/net/sfc/base/ef10_intr.c:44: + return (0); CHECK:SPACING: No space is necessary after a cast #3648: FILE: drivers/net/sfc/base/ef10_intr.c:90: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3648: FILE: drivers/net/sfc/base/ef10_intr.c:90: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3664: FILE: drivers/net/sfc/base/ef10_intr.c:106: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3672: FILE: drivers/net/sfc/base/ef10_intr.c:114: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #3680: FILE: drivers/net/sfc/base/ef10_intr.c:122: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3692: FILE: drivers/net/sfc/base/ef10_intr.c:134: + if ((rc = efx_mcdi_trigger_interrupt(enp, level)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3695: FILE: drivers/net/sfc/base/ef10_intr.c:137: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3702: FILE: drivers/net/sfc/base/ef10_intr.c:144: + return (rc); CHECK:SPACING: spaces preferred around that '*' (ctx:ExV) #3737: FILE: drivers/net/sfc/base/ef10_intr.c:179: + *fatalp = B_FALSE; ^ CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #3803: FILE: drivers/net/sfc/base/ef10_mac.c:42: + efx_port_t *epp = &(enp->en_port); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3807: FILE: drivers/net/sfc/base/ef10_mac.c:46: + if ((rc = ef10_phy_get_link(enp, &els)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3815: FILE: drivers/net/sfc/base/ef10_mac.c:54: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3822: FILE: drivers/net/sfc/base/ef10_mac.c:61: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3837: FILE: drivers/net/sfc/base/ef10_mac.c:76: + if ((rc = ef10_phy_get_link(enp, &els)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3842: FILE: drivers/net/sfc/base/ef10_mac.c:81: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3847: FILE: drivers/net/sfc/base/ef10_mac.c:86: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #3861: FILE: drivers/net/sfc/base/ef10_mac.c:100: + efx_port_t *epp = &(enp->en_port); CHECK:SPACING: No space is necessary after a cast #3867: FILE: drivers/net/sfc/base/ef10_mac.c:106: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3867: FILE: drivers/net/sfc/base/ef10_mac.c:106: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3886: FILE: drivers/net/sfc/base/ef10_mac.c:125: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3891: FILE: drivers/net/sfc/base/ef10_mac.c:130: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3900: FILE: drivers/net/sfc/base/ef10_mac.c:139: + if ((rc = efx_mcdi_vadapter_set_mac(enp)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #3908: FILE: drivers/net/sfc/base/ef10_mac.c:147: + if ((rc = ef10_mac_reconfigure(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3912: FILE: drivers/net/sfc/base/ef10_mac.c:151: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3920: FILE: drivers/net/sfc/base/ef10_mac.c:159: + return (rc); CHECK:SPACING: No space is necessary after a cast #3933: FILE: drivers/net/sfc/base/ef10_mac.c:172: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3933: FILE: drivers/net/sfc/base/ef10_mac.c:172: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3952: FILE: drivers/net/sfc/base/ef10_mac.c:191: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3957: FILE: drivers/net/sfc/base/ef10_mac.c:196: + return (rc); CHECK:SPACING: No space is necessary after a cast #3970: FILE: drivers/net/sfc/base/ef10_mac.c:209: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #3970: FILE: drivers/net/sfc/base/ef10_mac.c:209: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #3997: FILE: drivers/net/sfc/base/ef10_mac.c:236: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4004: FILE: drivers/net/sfc/base/ef10_mac.c:243: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #4011: FILE: drivers/net/sfc/base/ef10_mac.c:250: + efx_port_t *epp = &(enp->en_port); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #4012: FILE: drivers/net/sfc/base/ef10_mac.c:251: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4016: FILE: drivers/net/sfc/base/ef10_mac.c:255: + if ((rc = efx_mcdi_mtu_set(enp, epp->ep_mac_pdu)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4024: FILE: drivers/net/sfc/base/ef10_mac.c:263: + if ((rc = ef10_mac_reconfigure(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4028: FILE: drivers/net/sfc/base/ef10_mac.c:267: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4035: FILE: drivers/net/sfc/base/ef10_mac.c:274: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4045: FILE: drivers/net/sfc/base/ef10_mac.c:284: + if ((rc = efx_mcdi_mtu_get(enp, pdu)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4048: FILE: drivers/net/sfc/base/ef10_mac.c:287: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4053: FILE: drivers/net/sfc/base/ef10_mac.c:292: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #4060: FILE: drivers/net/sfc/base/ef10_mac.c:299: + efx_port_t *epp = &(enp->en_port); CHECK:SPACING: No space is necessary after a cast #4066: FILE: drivers/net/sfc/base/ef10_mac.c:305: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4066: FILE: drivers/net/sfc/base/ef10_mac.c:305: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4127: FILE: drivers/net/sfc/base/ef10_mac.c:366: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4132: FILE: drivers/net/sfc/base/ef10_mac.c:371: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #4139: FILE: drivers/net/sfc/base/ef10_mac.c:378: + efx_port_t *epp = &(enp->en_port); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #4146: FILE: drivers/net/sfc/base/ef10_mac.c:385: + if ((rc = emop->emo_reconfigure(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4149: FILE: drivers/net/sfc/base/ef10_mac.c:388: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4154: FILE: drivers/net/sfc/base/ef10_mac.c:393: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #4163: FILE: drivers/net/sfc/base/ef10_mac.c:402: + efx_port_t *epp = &(enp->en_port); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4181: FILE: drivers/net/sfc/base/ef10_mac.c:420: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4188: FILE: drivers/net/sfc/base/ef10_mac.c:427: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #4195: FILE: drivers/net/sfc/base/ef10_mac.c:434: + efx_port_t *epp = &(enp->en_port); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #4262: FILE: drivers/net/sfc/base/ef10_mcdi.c:49: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); CHECK:SPACING: No space is necessary after a cast #4297: FILE: drivers/net/sfc/base/ef10_mcdi.c:84: + (void) ef10_mcdi_poll_reboot(enp); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4302: FILE: drivers/net/sfc/base/ef10_mcdi.c:89: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4309: FILE: drivers/net/sfc/base/ef10_mcdi.c:96: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #4316: FILE: drivers/net/sfc/base/ef10_mcdi.c:103: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #4339: FILE: drivers/net/sfc/base/ef10_mcdi.c:126: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4378: FILE: drivers/net/sfc/base/ef10_mcdi.c:165: + for (pos = 0; pos < hdr_len; pos += sizeof (efx_dword_t)) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4384: FILE: drivers/net/sfc/base/ef10_mcdi.c:171: + for (pos = 0; pos < sdu_len; pos += sizeof (efx_dword_t)) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4414: FILE: drivers/net/sfc/base/ef10_mcdi.c:201: + return (EFX_DWORD_FIELD(hdr, MCDI_HEADER_RESPONSE) ? B_TRUE : B_FALSE); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4429: FILE: drivers/net/sfc/base/ef10_mcdi.c:216: + for (pos = 0; pos < length; pos += sizeof (efx_dword_t)) { WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4432: FILE: drivers/net/sfc/base/ef10_mcdi.c:219: + MIN(sizeof (data), length - pos)); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #4440: FILE: drivers/net/sfc/base/ef10_mcdi.c:227: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4475: FILE: drivers/net/sfc/base/ef10_mcdi.c:262: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4480: FILE: drivers/net/sfc/base/ef10_mcdi.c:267: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #4489: FILE: drivers/net/sfc/base/ef10_mcdi.c:276: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4545: FILE: drivers/net/sfc/base/ef10_mcdi.c:332: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4550: FILE: drivers/net/sfc/base/ef10_mcdi.c:337: + return (rc); CHECK:SPACING: No space is necessary after a cast #4612: FILE: drivers/net/sfc/base/ef10_nic.c:51: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4612: FILE: drivers/net/sfc/base/ef10_nic.c:51: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4633: FILE: drivers/net/sfc/base/ef10_nic.c:72: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4640: FILE: drivers/net/sfc/base/ef10_nic.c:79: + return (rc); CHECK:SPACING: No space is necessary after a cast #4657: FILE: drivers/net/sfc/base/ef10_nic.c:96: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4657: FILE: drivers/net/sfc/base/ef10_nic.c:96: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4693: FILE: drivers/net/sfc/base/ef10_nic.c:132: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4702: FILE: drivers/net/sfc/base/ef10_nic.c:141: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4743: FILE: drivers/net/sfc/base/ef10_nic.c:182: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4748: FILE: drivers/net/sfc/base/ef10_nic.c:187: + return (rc); CHECK:SPACING: No space is necessary after a cast #4763: FILE: drivers/net/sfc/base/ef10_nic.c:202: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4763: FILE: drivers/net/sfc/base/ef10_nic.c:202: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4782: FILE: drivers/net/sfc/base/ef10_nic.c:221: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4787: FILE: drivers/net/sfc/base/ef10_nic.c:226: + return (rc); CHECK:SPACING: No space is necessary after a cast #4800: FILE: drivers/net/sfc/base/ef10_nic.c:239: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4800: FILE: drivers/net/sfc/base/ef10_nic.c:239: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4816: FILE: drivers/net/sfc/base/ef10_nic.c:255: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4821: FILE: drivers/net/sfc/base/ef10_nic.c:260: + return (rc); CHECK:SPACING: No space is necessary after a cast #4837: FILE: drivers/net/sfc/base/ef10_nic.c:276: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4837: FILE: drivers/net/sfc/base/ef10_nic.c:276: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4870: FILE: drivers/net/sfc/base/ef10_nic.c:309: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4879: FILE: drivers/net/sfc/base/ef10_nic.c:318: + return (rc); CHECK:SPACING: No space is necessary after a cast #4895: FILE: drivers/net/sfc/base/ef10_nic.c:334: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4895: FILE: drivers/net/sfc/base/ef10_nic.c:334: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4933: FILE: drivers/net/sfc/base/ef10_nic.c:372: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4942: FILE: drivers/net/sfc/base/ef10_nic.c:381: + return (rc); CHECK:SPACING: No space is necessary after a cast #4959: FILE: drivers/net/sfc/base/ef10_nic.c:398: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #4959: FILE: drivers/net/sfc/base/ef10_nic.c:398: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #4989: FILE: drivers/net/sfc/base/ef10_nic.c:428: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5000: FILE: drivers/net/sfc/base/ef10_nic.c:439: + return (rc); CHECK:SPACING: No space is necessary after a cast #5015: FILE: drivers/net/sfc/base/ef10_nic.c:454: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5015: FILE: drivers/net/sfc/base/ef10_nic.c:454: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5041: FILE: drivers/net/sfc/base/ef10_nic.c:480: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5048: FILE: drivers/net/sfc/base/ef10_nic.c:487: + return (rc); CHECK:SPACING: No space is necessary after a cast #5063: FILE: drivers/net/sfc/base/ef10_nic.c:502: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5063: FILE: drivers/net/sfc/base/ef10_nic.c:502: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5093: FILE: drivers/net/sfc/base/ef10_nic.c:532: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5100: FILE: drivers/net/sfc/base/ef10_nic.c:539: + return (rc); CHECK:SPACING: No space is necessary after a cast #5123: FILE: drivers/net/sfc/base/ef10_nic.c:562: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5123: FILE: drivers/net/sfc/base/ef10_nic.c:562: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5154: FILE: drivers/net/sfc/base/ef10_nic.c:593: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5163: FILE: drivers/net/sfc/base/ef10_nic.c:602: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5191: FILE: drivers/net/sfc/base/ef10_nic.c:630: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5196: FILE: drivers/net/sfc/base/ef10_nic.c:635: + return (rc); CHECK:SPACING: No space is necessary after a cast #5215: FILE: drivers/net/sfc/base/ef10_nic.c:654: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5215: FILE: drivers/net/sfc/base/ef10_nic.c:654: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5236: FILE: drivers/net/sfc/base/ef10_nic.c:675: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5245: FILE: drivers/net/sfc/base/ef10_nic.c:684: + return (rc); CHECK:SPACING: No space is necessary after a cast #5258: FILE: drivers/net/sfc/base/ef10_nic.c:697: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5258: FILE: drivers/net/sfc/base/ef10_nic.c:697: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5274: FILE: drivers/net/sfc/base/ef10_nic.c:713: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5279: FILE: drivers/net/sfc/base/ef10_nic.c:718: + return (rc); CHECK:SPACING: No space is necessary after a cast #5293: FILE: drivers/net/sfc/base/ef10_nic.c:732: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5293: FILE: drivers/net/sfc/base/ef10_nic.c:732: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5310: FILE: drivers/net/sfc/base/ef10_nic.c:749: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5315: FILE: drivers/net/sfc/base/ef10_nic.c:754: + return (rc); CHECK:SPACING: No space is necessary after a cast #5328: FILE: drivers/net/sfc/base/ef10_nic.c:767: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5328: FILE: drivers/net/sfc/base/ef10_nic.c:767: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5344: FILE: drivers/net/sfc/base/ef10_nic.c:783: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5349: FILE: drivers/net/sfc/base/ef10_nic.c:788: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5441: FILE: drivers/net/sfc/base/ef10_nic.c:880: + EFSYS_ASSERT3U(blk_per_buf, <=, (8 * sizeof (*map))); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5459: FILE: drivers/net/sfc/base/ef10_nic.c:898: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5466: FILE: drivers/net/sfc/base/ef10_nic.c:905: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5480: FILE: drivers/net/sfc/base/ef10_nic.c:919: + (blknum >= (8 * sizeof (*map)))) { ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5492: FILE: drivers/net/sfc/base/ef10_nic.c:931: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5499: FILE: drivers/net/sfc/base/ef10_nic.c:938: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5508: FILE: drivers/net/sfc/base/ef10_nic.c:947: + return (efx_mcdi_link_piobuf(enp, vi_index, handle)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5516: FILE: drivers/net/sfc/base/ef10_nic.c:955: + return (efx_mcdi_unlink_piobuf(enp, vi_index)); CHECK:SPACING: No space is necessary after a cast #5529: FILE: drivers/net/sfc/base/ef10_nic.c:968: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #5529: FILE: drivers/net/sfc/base/ef10_nic.c:968: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5553: FILE: drivers/net/sfc/base/ef10_nic.c:992: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5560: FILE: drivers/net/sfc/base/ef10_nic.c:999: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #5567: FILE: drivers/net/sfc/base/ef10_nic.c:1006: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5573: FILE: drivers/net/sfc/base/ef10_nic.c:1012: + if ((rc = efx_mcdi_get_capabilities(enp, &flags, &flags2, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5577: FILE: drivers/net/sfc/base/ef10_nic.c:1016: + if ((rc = ef10_mcdi_get_pf_count(enp, &encp->enc_hw_pf_count)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5689: FILE: drivers/net/sfc/base/ef10_nic.c:1128: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5696: FILE: drivers/net/sfc/base/ef10_nic.c:1135: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #5721: FILE: drivers/net/sfc/base/ef10_nic.c:1160: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5725: FILE: drivers/net/sfc/base/ef10_nic.c:1164: + if ((rc = efx_mcdi_privilege_mask(enp, encp->enc_pf, encp->enc_vf, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5742: FILE: drivers/net/sfc/base/ef10_nic.c:1181: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5747: FILE: drivers/net/sfc/base/ef10_nic.c:1186: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5837: FILE: drivers/net/sfc/base/ef10_nic.c:1276: + if ((rc = efx_mcdi_get_port_modes(enp, &port_modes, ¤t)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5842: FILE: drivers/net/sfc/base/ef10_nic.c:1281: + if ((rc = efx_mcdi_get_port_modes(enp, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5884: FILE: drivers/net/sfc/base/ef10_nic.c:1323: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5889: FILE: drivers/net/sfc/base/ef10_nic.c:1328: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #5898: FILE: drivers/net/sfc/base/ef10_nic.c:1337: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_drv_cfg #5899: FILE: drivers/net/sfc/base/ef10_nic.c:1338: + efx_drv_cfg_t *edcp = &(enp->en_drv_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5906: FILE: drivers/net/sfc/base/ef10_nic.c:1345: + if ((rc = efx_mcdi_read_assertion(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5910: FILE: drivers/net/sfc/base/ef10_nic.c:1349: + if ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5914: FILE: drivers/net/sfc/base/ef10_nic.c:1353: + if ((rc = efx_mcdi_drv_attach(enp, B_TRUE)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #5917: FILE: drivers/net/sfc/base/ef10_nic.c:1356: + if ((rc = enop->eno_board_cfg(enp)) != 0) CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided #5928: FILE: drivers/net/sfc/base/ef10_nic.c:1367: + edcp->edc_min_vi_count = edcp->edc_max_vi_count = ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5937: FILE: drivers/net/sfc/base/ef10_nic.c:1376: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #5948: FILE: drivers/net/sfc/base/ef10_nic.c:1387: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #5956: FILE: drivers/net/sfc/base/ef10_nic.c:1395: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_drv_cfg #5957: FILE: drivers/net/sfc/base/ef10_nic.c:1396: + efx_drv_cfg_t *edcp = &(enp->en_drv_cfg); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6017: FILE: drivers/net/sfc/base/ef10_nic.c:1456: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6022: FILE: drivers/net/sfc/base/ef10_nic.c:1461: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #6036: FILE: drivers/net/sfc/base/ef10_nic.c:1475: + if ((rc = efx_mcdi_read_assertion(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #6038: FILE: drivers/net/sfc/base/ef10_nic.c:1477: + if ((rc = efx_mcdi_exit_assertion_handler(enp)) != 0) CHECK:SPACING: No space is necessary after a cast #6041: FILE: drivers/net/sfc/base/ef10_nic.c:1480: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #6041: FILE: drivers/net/sfc/base/ef10_nic.c:1480: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6061: FILE: drivers/net/sfc/base/ef10_nic.c:1500: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6070: FILE: drivers/net/sfc/base/ef10_nic.c:1509: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_drv_cfg #6077: FILE: drivers/net/sfc/base/ef10_nic.c:1516: + efx_drv_cfg_t *edcp = &(enp->en_drv_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #6089: FILE: drivers/net/sfc/base/ef10_nic.c:1528: + if ((rc = efx_mcdi_log_ctrl(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #6113: FILE: drivers/net/sfc/base/ef10_nic.c:1552: + if ((rc = efx_mcdi_free_vis(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #6121: FILE: drivers/net/sfc/base/ef10_nic.c:1560: + if ((rc = efx_mcdi_alloc_vis(enp, min_vi_count, max_vi_count, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6215: FILE: drivers/net/sfc/base/ef10_nic.c:1654: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6233: FILE: drivers/net/sfc/base/ef10_nic.c:1672: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6250: FILE: drivers/net/sfc/base/ef10_nic.c:1689: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6288: FILE: drivers/net/sfc/base/ef10_nic.c:1727: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6293: FILE: drivers/net/sfc/base/ef10_nic.c:1732: + return (rc); CHECK:SPACING: No space is necessary after a cast #6303: FILE: drivers/net/sfc/base/ef10_nic.c:1742: + (void) efx_mcdi_vadaptor_free(enp, enp->en_vport_id); CHECK:SPACING: No space is necessary after a cast #6318: FILE: drivers/net/sfc/base/ef10_nic.c:1757: + (void) efx_mcdi_free_vis(enp); CHECK:SPACING: No space is necessary after a cast #6326: FILE: drivers/net/sfc/base/ef10_nic.c:1765: + (void) efx_mcdi_drv_attach(enp, B_FALSE); CHECK:BRACES: braces {} should be used on all arms of this statement #6437: FILE: drivers/net/sfc/base/ef10_phy.c:101: + if (fcntl == MC_CMD_FCNTL_OFF) [...] + else if (fcntl == MC_CMD_FCNTL_RESPOND) [...] + else if (fcntl == MC_CMD_FCNTL_GENERATE) [...] + else if (fcntl == MC_CMD_FCNTL_BIDIR) [...] + else { [...] CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #6458: FILE: drivers/net/sfc/base/ef10_phy.c:122: + efx_port_t *epp = &(enp->en_port); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6519: FILE: drivers/net/sfc/base/ef10_phy.c:183: + return (0); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #6522: FILE: drivers/net/sfc/base/ef10_phy.c:186: + if ((rc = ef10_phy_verify(enp)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6527: FILE: drivers/net/sfc/base/ef10_phy.c:191: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6532: FILE: drivers/net/sfc/base/ef10_phy.c:196: + return (rc); CHECK:SPACING: No space is necessary after a cast #6545: FILE: drivers/net/sfc/base/ef10_phy.c:209: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #6545: FILE: drivers/net/sfc/base/ef10_phy.c:209: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6576: FILE: drivers/net/sfc/base/ef10_phy.c:240: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6583: FILE: drivers/net/sfc/base/ef10_phy.c:247: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #6590: FILE: drivers/net/sfc/base/ef10_phy.c:254: + efx_port_t *epp = &(enp->en_port); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #6600: FILE: drivers/net/sfc/base/ef10_phy.c:264: + if ((rc = efx_mcdi_link_control_supported(enp, &supported)) != 0) CHECK:SPACING: No space is necessary after a cast #6605: FILE: drivers/net/sfc/base/ef10_phy.c:269: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #6605: FILE: drivers/net/sfc/base/ef10_phy.c:269: + (void) memset(payload, 0, sizeof (payload)); CHECK:SPACING: No space is necessary after a cast #6642: FILE: drivers/net/sfc/base/ef10_phy.c:306: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #6642: FILE: drivers/net/sfc/base/ef10_phy.c:306: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6658: FILE: drivers/net/sfc/base/ef10_phy.c:322: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6667: FILE: drivers/net/sfc/base/ef10_phy.c:331: + return (rc); CHECK:SPACING: No space is necessary after a cast #6680: FILE: drivers/net/sfc/base/ef10_phy.c:344: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #6680: FILE: drivers/net/sfc/base/ef10_phy.c:344: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6707: FILE: drivers/net/sfc/base/ef10_phy.c:371: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6716: FILE: drivers/net/sfc/base/ef10_phy.c:380: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6726: FILE: drivers/net/sfc/base/ef10_phy.c:390: + return (ENOTSUP); WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOTSUP) #6726: FILE: drivers/net/sfc/base/ef10_phy.c:390: + return (ENOTSUP); CHECK:SPACING: No space is necessary after a cast #6803: FILE: drivers/net/sfc/base/ef10_rx.c:68: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #6803: FILE: drivers/net/sfc/base/ef10_rx.c:68: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6846: FILE: drivers/net/sfc/base/ef10_rx.c:111: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6851: FILE: drivers/net/sfc/base/ef10_rx.c:116: + return (rc); CHECK:SPACING: No space is necessary after a cast #6864: FILE: drivers/net/sfc/base/ef10_rx.c:129: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #6864: FILE: drivers/net/sfc/base/ef10_rx.c:129: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6880: FILE: drivers/net/sfc/base/ef10_rx.c:145: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6885: FILE: drivers/net/sfc/base/ef10_rx.c:150: + return (rc); CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #6893: FILE: drivers/net/sfc/base/ef10_rx.c:158: +{ + ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6894: FILE: drivers/net/sfc/base/ef10_rx.c:159: + return (0); CHECK:SPACING: spaces preferred around that '*' (ctx:ExV) #6933: FILE: drivers/net/sfc/base/ef10_rx.c:198: + *lengthp = buffer[8] | (buffer[9] << 8); ^ ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #6934: FILE: drivers/net/sfc/base/ef10_rx.c:199: + return (0); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around erp->er_mask #6955: FILE: drivers/net/sfc/base/ef10_rx.c:220: + id = added & (erp->er_mask); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #6968: FILE: drivers/net/sfc/base/ef10_rx.c:233: + offset = id * sizeof (efx_qword_t); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around erp->er_mask #6971: FILE: drivers/net/sfc/base/ef10_rx.c:236: + id = (id + 1) & (erp->er_mask); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #7013: FILE: drivers/net/sfc/base/ef10_rx.c:278: + if ((rc = efx_mcdi_fini_rxq(enp, erp->er_index)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #7016: FILE: drivers/net/sfc/base/ef10_rx.c:281: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #7021: FILE: drivers/net/sfc/base/ef10_rx.c:286: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #7045: FILE: drivers/net/sfc/base/ef10_rx.c:310: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #7086: FILE: drivers/net/sfc/base/ef10_rx.c:351: + if ((rc = efx_mcdi_init_rxq(enp, n, eep->ee_index, label, index, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #7095: FILE: drivers/net/sfc/base/ef10_rx.c:360: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #7106: FILE: drivers/net/sfc/base/ef10_rx.c:371: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #7122: FILE: drivers/net/sfc/base/ef10_rx.c:387: + EFSYS_KMEM_FREE(enp->en_esip, sizeof (efx_rxq_t), erp); WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #7140: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:2: +/**************************************************************************\ +*//*! ile WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #7148: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:10: +*//* +\**************************************************************************/ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7232: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:94: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7233: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:95: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7234: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:96: + uint16_t type_id;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7238: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:100: + * selected through an RFID command and copied by FW to the location at offset 0. */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7239: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:101: + uint16_t preset;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7240: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:102: + uint32_t generation;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7241: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:103: + uint32_t total_length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7254: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:116: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7255: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:117: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7256: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:118: + uint32_t generation;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7257: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:119: + uint32_t checksum;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7271: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:133: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7272: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:134: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7273: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:135: + uint16_t type_id;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7274: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:136: + uint16_t reserved;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7290: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:152: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7291: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:153: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7292: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:154: + uint32_t flags;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7308: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:170: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7309: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:171: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7310: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:172: + uint8_t base_address[6];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7311: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:173: + uint16_t reserved;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7312: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:174: + uint16_t count;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7313: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:175: + uint16_t stride;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7328: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:190: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7329: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:191: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7330: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:192: + uint8_t bytes[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7336: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:198: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7337: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:199: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7338: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:200: + uint8_t bytes[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7353: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:215: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7354: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:216: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7355: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:217: + uint8_t bytes[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7361: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:223: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7362: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:224: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7363: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:225: + uint8_t bytes[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7378: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:240: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7379: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:241: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7380: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:242: + struct {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7381: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:243: + uint16_t addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7382: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:244: + uint16_t byte_enables;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7383: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:245: + uint32_t value;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7384: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:246: + } items[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7391: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:253: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7392: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:254: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7393: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:255: + struct {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7394: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:256: + uint16_t addr;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7395: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:257: + uint16_t byte_enables;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7396: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:258: + uint32_t value;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7397: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:259: + } items[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7415: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:277: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7416: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:278: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7417: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:279: + uint32_t subtype;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7418: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:280: + uint8_t description[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7432: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:294: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7433: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:295: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7434: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:296: + uint16_t version_w;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7435: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:297: + uint16_t version_x;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7436: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:298: + uint16_t version_y;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7437: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:299: + uint16_t version_z;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7445: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:307: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7446: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:308: + uint32_t length;$ WARNING:LONG_LINE_COMMENT: line over 90 characters #7447: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:309: + int16_t max_pf_number; /**< Largest PF RID (lower PFs may be hidden) */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7447: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:309: + int16_t max_pf_number; /**< Largest PF RID (lower PFs may be hidden) */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7448: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:310: + uint16_t pf_aper; /**< BIU aperture for PF BAR2 */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7449: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:311: + uint16_t vf_aper; /**< BIU aperture for VF BAR0 */$ WARNING:LONG_LINE_COMMENT: line over 90 characters #7450: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:312: + uint16_t int_aper; /**< BIU aperture for PF BAR4 and VF BAR2 */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7450: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:312: + uint16_t int_aper; /**< BIU aperture for PF BAR4 and VF BAR2 */$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7458: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:320: + * tidy things up later */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7463: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:325: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7464: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:326: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7465: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:327: + uint8_t vfs_total;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7466: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:328: + uint8_t port_allocation;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7467: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:329: + uint16_t vectors_per_pf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7468: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:330: + uint16_t vectors_per_vf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7469: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:331: + uint8_t pf_bar0_aperture;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7470: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:332: + uint8_t pf_bar2_aperture;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7471: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:333: + uint8_t vf_bar0_aperture;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7472: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:334: + uint8_t vf_base;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7473: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:335: + uint16_t supp_pagesz;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7474: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:336: + uint16_t msix_vec_base;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7480: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:342: + * settings. This is a temporary measure. */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7485: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:347: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7486: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:348: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7488: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:350: + uint64_t tx0_tags; /* Bitmap */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7489: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:351: + uint64_t tx1_tags; /* Bitmap */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7490: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:352: + uint64_t dl_tags; /* Bitmap */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7491: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:353: + uint32_t flags;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7498: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:360: + uint32_t dut_features; /* All 1s -> leave alone */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7499: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:361: + int8_t with_rmon; /* 0 -> off, 1 -> on, -1 -> leave alone */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7501: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:363: + int8_t clk_mode; /* 0 -> off, 1 -> on, -1 -> leave alone */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7503: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:365: + int8_t rx_dc_size; /* -1 -> leave alone */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7504: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:366: + int8_t tx_dc_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7505: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:367: + int16_t num_q_allocs;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7516: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:378: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7517: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:379: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7518: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:380: + uint32_t ports_per_core;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7519: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:381: + uint32_t max_port_speed;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7536: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:398: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7537: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:399: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7538: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:400: + uint32_t firmware_variant;$ ERROR:CODE_INDENT: code indent should use tabs where possible #7551: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:413: + MC_CMD_FW_PACKED_STREAM_HASH_MODE_1$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7551: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:413: + MC_CMD_FW_PACKED_STREAM_HASH_MODE_1$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7559: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:421: + * determined. */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7564: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:426: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7565: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:427: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7566: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:428: + uint16_t flags; /* Boards with high 0v9 settings may need active cooling */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7568: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:430: + uint16_t target_voltage; /* In millivolts */$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7570: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:432: + * contain it) they need setting as well. */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7571: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:433: + uint16_t warn_low; /* In millivolts */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7572: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:434: + uint16_t warn_high; /* In millivolts */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7573: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:435: + uint16_t panic_low; /* In millivolts */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7574: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:436: + uint16_t panic_high; /* In millivolts */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7584: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:446: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7585: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:447: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7586: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:448: + uint16_t clk_sys; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7587: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:449: + uint16_t clk_dpcpu; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7588: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:450: + uint16_t clk_icore; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7589: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:451: + uint16_t clk_pcs; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7595: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:457: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7596: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:458: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7597: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:459: + uint16_t clk_sys; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7598: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:460: + uint16_t clk_mc; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7599: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:461: + uint16_t clk_rmon; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7600: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:462: + uint16_t clk_vswitch; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7601: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:463: + uint16_t clk_dpcpu; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7602: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:464: + uint16_t clk_pcs; /* MHz */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7616: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:478: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7617: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:479: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7618: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:480: + uint8_t base_address[6];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7619: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:481: + uint16_t reserved1;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7620: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:482: + uint16_t count;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7621: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:483: + uint16_t reserved2;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7628: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:490: + * analogue test bus */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7630: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:492: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7631: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:493: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7632: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:494: + uint16_t millivolts;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7633: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:495: + uint16_t reserved;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7639: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:501: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7640: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:502: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7641: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:503: + uint8_t quad_tx_imp2k[4];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7642: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:504: + uint8_t quad_tx_imp50[4];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7643: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:505: + uint8_t lane_amp[16];$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7651: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:513: + * the old tag will be left in the firmware indefinitely). */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7656: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:518: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7657: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:519: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7658: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:520: + uint16_t visible_pfs; /**< Bitmap of visible PFs */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7659: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:521: + uint16_t pf_aper; /**< BIU aperture for PF BAR2 */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7660: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:522: + uint16_t vf_aper; /**< BIU aperture for VF BAR0 */$ WARNING:LONG_LINE_COMMENT: line over 90 characters #7661: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:523: + uint16_t int_aper; /**< BIU aperture for PF BAR4 and VF BAR2 */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7661: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:523: + uint16_t int_aper; /**< BIU aperture for PF BAR4 and VF BAR2 */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7677: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:539: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7678: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:540: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7679: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:541: + uint32_t port_mode;$ WARNING:LONG_LINE_COMMENT: line over 90 characters #7683: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:545: +#define TLV_PORT_MODE_10G_10G (2) /* 2x10G, dual SFP/10G-KR or single QSFP */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7684: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:546: +#define TLV_PORT_MODE_40G_40G (3) /* 40G + 40G, dual QSFP/40G-KR (Greenport, Medford) */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7685: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:547: +#define TLV_PORT_MODE_10G_10G_10G_10G (4) /* 2x10G + 2x10G, quad SFP/10G-KR or dual QSFP (Greenport) */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7686: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:548: +#define TLV_PORT_MODE_10G_10G_10G_10G_Q1 (4) /* 4x10G, single QSFP, cage 0 (Medford) */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7687: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:549: +#define TLV_PORT_MODE_10G_10G_10G_10G_Q (5) /* 4x10G, single QSFP, cage 0 (Medford) OBSOLETE DO NOT USE */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7688: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:550: +#define TLV_PORT_MODE_40G_10G_10G (6) /* 1x40G + 2x10G, dual QSFP (Greenport, Medford) */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7689: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:551: +#define TLV_PORT_MODE_10G_10G_40G (7) /* 2x10G + 1x40G, dual QSFP (Greenport, Medford) */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7690: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:552: +#define TLV_PORT_MODE_10G_10G_10G_10G_Q2 (8) /* 4x10G, single QSFP, cage 1 (Medford) */ WARNING:LONG_LINE_COMMENT: line over 90 characters #7691: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:553: +#define TLV_PORT_MODE_10G_10G_10G_10G_Q1_Q2 (9) /* 2x10G + 2x10G, dual QSFP (Medford) */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7700: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:562: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7701: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:563: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7702: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:564: + uint32_t vswitch_type;$ WARNING:LONG_LINE_COMMENT: line over 90 characters #7703: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:565: +#define TLV_VSWITCH_TYPE_DEFAULT (0xffffffff) /* Firmware default; equivalent to no TLV present for a given port */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7717: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:579: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7718: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:580: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7719: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:581: + uint32_t vlan_tag;$ WARNING:LONG_LINE_COMMENT: line over 90 characters #7720: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:582: +#define TLV_VPORT_NO_VLAN_TAG (0xFFFFFFFF) /* Default in the absence of TLV for a given PF */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7728: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:590: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7729: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:591: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7730: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:592: + int16_t offset_millivolts;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7731: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:593: + uint16_t reserved;$ WARNING:LONG_LINE_COMMENT: line over 90 characters #7734: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:596: +/* A privilege mask given on reset to all non-admin PCIe functions (that is other than first-PF-per-port). WARNING:LONG_LINE_COMMENT: line over 90 characters #7735: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:597: + * The meaning of particular bits is defined in mcdi_ef10.yml under MC_CMD_PRIVILEGE_MASK, see also bug 44583. WARNING:LONG_LINE_COMMENT: line over 90 characters #7736: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:598: + * TLV_TAG_PRIVILEGE_MASK_ADD specifies bits that should be added (ORed) to firmware default while WARNING:LONG_LINE_COMMENT: line over 90 characters #7737: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:599: + * TLV_TAG_PRIVILEGE_MASK_REM specifies bits that should be removed (ANDed) from firmware default: WARNING:LONG_LINE_COMMENT: line over 90 characters #7738: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:600: + * Initial_privilege_mask = (firmware_default_mask | privilege_mask_add) & ~privilege_mask_rem */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7738: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:600: + * Initial_privilege_mask = (firmware_default_mask | privilege_mask_add) & ~privilege_mask_rem */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7743: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:605: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7744: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:606: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7745: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:607: + uint32_t privilege_mask;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7751: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:613: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7752: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:614: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7753: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:615: + uint32_t privilege_mask_add;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7759: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:621: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7760: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:622: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7761: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:623: + uint32_t privilege_mask_rem;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7765: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:627: + * This tag takes precedence over TLV_TAG_PRIVILEGE_MASK_REM. */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7770: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:632: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7771: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:633: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7772: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:634: + uint32_t privilege_mask_add;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7776: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:638: + * This tag takes precedence over TLV_TAG_PRIVILEGE_MASK_REM. */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7781: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:643: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7782: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:644: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7783: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:645: + uint32_t privilege_mask_add;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #7787: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:649: + * This tag only takes effect if TLV_TAG_VSWITCH_TYPE is missing or set to DEFAULT. */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7792: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:654: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7793: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:655: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7794: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:656: + uint32_t pfiov;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7822: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:684: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7823: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:685: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7824: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:686: + uint32_t mode;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7834: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:696: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7835: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:697: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7836: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:698: + uint32_t rate_mbps;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7857: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:719: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7858: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:720: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7859: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:721: + uint32_t mode;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7875: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:737: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7876: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:738: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7877: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:739: + uint8_t rx_desc_cache_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7878: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:740: + uint8_t tx_desc_cache_size;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7879: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:741: + uint16_t vi_count;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7893: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:755: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7894: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:756: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7895: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:757: + uint32_t max_events;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7897: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:759: + uint32_t timeout_ns;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7904: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:766: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7905: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:767: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7906: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:768: + uint16_t gen; /* Target PCIe generation: 1, 2, 3 */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7907: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:769: + uint16_t width; /* Number of lanes */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7918: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:780: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7919: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:781: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7920: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:782: + uint32_t max_events;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7922: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:784: + uint32_t timeout_ns;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7923: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:785: + uint32_t qempty_timeout_ns; /* Medford only */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7932: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:794: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7933: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:795: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7934: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:796: + uint8_t data[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7953: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:815: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7954: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:816: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7955: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:817: + uint32_t mode;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7956: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:818: + uint32_t ip;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7957: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:819: + uint32_t netmask;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7958: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:820: + uint32_t gateway;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7959: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:821: + uint32_t port;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7960: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:822: + uint32_t bind_retry; /* DEPRECATED */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7961: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:823: + uint32_t bind_bkout; /* DEPRECATED */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7977: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:839: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7978: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:840: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7979: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:841: + uint32_t num_tsacs;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7980: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:842: + uint32_t ip[TLV_MAX_TSACS];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7981: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:843: + uint32_t port[TLV_MAX_TSACS];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7997: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:859: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7998: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:860: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7999: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:861: + uint8_t bytes[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8014: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:876: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8015: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:877: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8016: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:878: + uint8_t bytes[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8032: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:894: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8033: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:895: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8034: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:896: + uint8_t bytes[];$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8045: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:907: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8046: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:908: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8047: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:909: + uint8_t mode;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8057: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:919: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8058: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:920: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8059: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:921: + uint8_t mode;$ WARNING:LONG_LINE_COMMENT: line over 90 characters #8060: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:922: +#define TLV_BIU_VI_WINDOW_MODE_8K 0 /* 8k per VI, CTPIO not mapped, medford/hunt compatible */ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8071: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:933: + uint32_t tag;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8072: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:934: + uint32_t length;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #8073: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:935: + uint8_t mode;$ WARNING:LONG_LINE_COMMENT: line over 90 characters #8076: FILE: drivers/net/sfc/base/ef10_tlv_layout.h:938: +#define TLV_FASTPD_MODE_FAST_SUPPORTED 2 /* Supported packet types to the FastPD; everything else to the SoftPD */ CHECK:SPACING: No space is necessary after a cast #8152: FILE: drivers/net/sfc/base/ef10_tx.c:67: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #8152: FILE: drivers/net/sfc/base/ef10_tx.c:67: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8197: FILE: drivers/net/sfc/base/ef10_tx.c:112: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8204: FILE: drivers/net/sfc/base/ef10_tx.c:119: + return (rc); CHECK:SPACING: No space is necessary after a cast #8217: FILE: drivers/net/sfc/base/ef10_tx.c:132: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #8217: FILE: drivers/net/sfc/base/ef10_tx.c:132: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8233: FILE: drivers/net/sfc/base/ef10_tx.c:148: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8238: FILE: drivers/net/sfc/base/ef10_tx.c:153: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8246: FILE: drivers/net/sfc/base/ef10_tx.c:161: + return (0); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #8274: FILE: drivers/net/sfc/base/ef10_tx.c:189: + if ((rc = efx_mcdi_init_txq(enp, n, eep->ee_index, label, index, flags, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8298: FILE: drivers/net/sfc/base/ef10_tx.c:213: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8303: FILE: drivers/net/sfc/base/ef10_tx.c:218: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #8329: FILE: drivers/net/sfc/base/ef10_tx.c:244: + if ((rc = ef10_nic_pio_alloc(enp, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #8340: FILE: drivers/net/sfc/base/ef10_tx.c:255: + if ((rc = ef10_nic_pio_link(enp, etp->et_index, handle)) != 0) { WARNING:BRACES: braces {} are not necessary for single statement blocks #8340: FILE: drivers/net/sfc/base/ef10_tx.c:255: + if ((rc = ef10_nic_pio_link(enp, etp->et_index, handle)) != 0) { + goto fail3; + } ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8357: FILE: drivers/net/sfc/base/ef10_tx.c:272: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8368: FILE: drivers/net/sfc/base/ef10_tx.c:283: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #8402: FILE: drivers/net/sfc/base/ef10_tx.c:317: + EFSYS_ASSERT(length % sizeof (efx_qword_t) == 0); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #8423: FILE: drivers/net/sfc/base/ef10_tx.c:338: + write_offset += sizeof (efx_qword_t); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8426: FILE: drivers/net/sfc/base/ef10_tx.c:341: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8433: FILE: drivers/net/sfc/base/ef10_tx.c:348: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #8461: FILE: drivers/net/sfc/base/ef10_tx.c:376: + offset = id * sizeof (efx_qword_t); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8479: FILE: drivers/net/sfc/base/ef10_tx.c:394: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8486: FILE: drivers/net/sfc/base/ef10_tx.c:401: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #8519: FILE: drivers/net/sfc/base/ef10_tx.c:434: + offset = id * sizeof (efx_qword_t); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8538: FILE: drivers/net/sfc/base/ef10_tx.c:453: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8543: FILE: drivers/net/sfc/base/ef10_tx.c:458: + return (rc); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #8566: FILE: drivers/net/sfc/base/ef10_tx.c:481: + offset = id * sizeof (efx_qword_t); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #8604: FILE: drivers/net/sfc/base/ef10_tx.c:519: + offset = id * sizeof (efx_desc_t); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8615: FILE: drivers/net/sfc/base/ef10_tx.c:530: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8620: FILE: drivers/net/sfc/base/ef10_tx.c:535: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8733: FILE: drivers/net/sfc/base/ef10_tx.c:648: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8738: FILE: drivers/net/sfc/base/ef10_tx.c:653: + return (rc); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #8748: FILE: drivers/net/sfc/base/ef10_tx.c:663: + if ((rc = efx_mcdi_fini_txq(enp, etp->et_index)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8751: FILE: drivers/net/sfc/base/ef10_tx.c:666: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #8756: FILE: drivers/net/sfc/base/ef10_tx.c:671: + return (rc); CHECK:SPACING: No space is necessary after a cast #9094: FILE: drivers/net/sfc/base/efx_mcdi.c:1596: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #9094: FILE: drivers/net/sfc/base/efx_mcdi.c:1596: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #9117: FILE: drivers/net/sfc/base/efx_mcdi.c:1619: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #9124: FILE: drivers/net/sfc/base/efx_mcdi.c:1626: + return (rc); CHECK:SPACING: No space is necessary after a cast #9139: FILE: drivers/net/sfc/base/efx_mcdi.c:1641: + (void) memset(payload, 0, sizeof (payload)); WARNING:SPACING: space prohibited between function name and open parenthesis '(' #9139: FILE: drivers/net/sfc/base/efx_mcdi.c:1641: + (void) memset(payload, 0, sizeof (payload)); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #9164: FILE: drivers/net/sfc/base/efx_mcdi.c:1666: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #9171: FILE: drivers/net/sfc/base/efx_mcdi.c:1673: + return (rc); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #9194: FILE: drivers/net/sfc/base/efx_nic.c:64: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #9199: FILE: drivers/net/sfc/base/efx_nic.c:69: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #9204: FILE: drivers/net/sfc/base/efx_nic.c:74: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #9925: FILE: drivers/net/sfc/base/efx_sram.c:64: + return (0); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10141: FILE: drivers/net/sfc/base/hunt_nic.c:54: + if ((rc = efx_mcdi_get_port_modes(enp, &port_modes, NULL)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10152: FILE: drivers/net/sfc/base/hunt_nic.c:65: + if ((rc = efx_nic_calculate_pcie_link_bandwidth(8, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10165: FILE: drivers/net/sfc/base/hunt_nic.c:78: + if ((rc = ef10_nic_get_port_mode_bandwidth(max_port_mode, ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #10173: FILE: drivers/net/sfc/base/hunt_nic.c:86: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #10180: FILE: drivers/net/sfc/base/hunt_nic.c:93: + return (rc); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_mcdi.em_emip #10187: FILE: drivers/net/sfc/base/hunt_nic.c:100: + efx_mcdi_iface_t *emip = &(enp->en_mcdi.em_emip); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_nic_cfg #10188: FILE: drivers/net/sfc/base/hunt_nic.c:101: + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around enp->en_port #10192: FILE: drivers/net/sfc/base/hunt_nic.c:105: + efx_port_t *epp = &(enp->en_port); ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10203: FILE: drivers/net/sfc/base/hunt_nic.c:116: + if ((rc = efx_mcdi_get_port_assignment(enp, &port)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10212: FILE: drivers/net/sfc/base/hunt_nic.c:125: + if ((rc = ef10_external_port_mapping(enp, port, ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10222: FILE: drivers/net/sfc/base/hunt_nic.c:135: + if ((rc = efx_mcdi_get_function_info(enp, &pf, &vf)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10262: FILE: drivers/net/sfc/base/hunt_nic.c:175: + if ((rc = efx_mcdi_get_phy_cfg(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10266: FILE: drivers/net/sfc/base/hunt_nic.c:179: + if ((rc = ef10_phy_get_link(enp, &els)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10359: FILE: drivers/net/sfc/base/hunt_nic.c:272: + if ((rc = efx_mcdi_get_clock(enp, &sysclk, &dpcpu_clk)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10378: FILE: drivers/net/sfc/base/hunt_nic.c:291: + if ((rc = ef10_get_datapath_caps(enp)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10416: FILE: drivers/net/sfc/base/hunt_nic.c:329: + if ((rc = ef10_get_privilege_mask(enp, &mask)) != 0) ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10421: FILE: drivers/net/sfc/base/hunt_nic.c:334: + if ((rc = efx_mcdi_get_vector_cfg(enp, &base, &nvec, NULL)) != 0) { ERROR:ASSIGN_IN_IF: do not use assignment in if condition #10438: FILE: drivers/net/sfc/base/hunt_nic.c:351: + if ((rc = hunt_nic_get_required_pcie_bandwidth(enp, &bandwidth)) != 0) ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #10445: FILE: drivers/net/sfc/base/hunt_nic.c:358: + return (0); ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required #10478: FILE: drivers/net/sfc/base/hunt_nic.c:391: + return (rc); total: 277 errors, 342 warnings, 94 checks, 10196 lines checked