From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id E6943FA31; Tue, 29 Nov 2016 17:38:22 +0100 (CET)
In-Reply-To: <1480436367-20749-21-git-send-email-arybchenko@solarflare.com>
References: <1480436367-20749-21-git-send-email-arybchenko@solarflare.com>
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Message-Id: <20161129163822.E6943FA31@dpdk.org>
Date: Tue, 29 Nov 2016 17:38:22 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| [PATCH v2 20/55] net/sfc: import
	libefx Rx scatter support
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Nov 2016 16:38:23 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17327

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <__checkReturn>
#93: FILE: drivers/net/sfc/base/ef10_impl.h:577:
+extern	__checkReturn	efx_rc_t

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#117: FILE: drivers/net/sfc/base/ef10_rx.c:169:
+	return (0);

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#293: FILE: drivers/net/sfc/base/efx_rx.c:230:
+	if ((rc = erxop->erxo_scatter_enable(enp, buf_size)) != 0)

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#296: FILE: drivers/net/sfc/base/efx_rx.c:233:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#300: FILE: drivers/net/sfc/base/efx_rx.c:237:
+	return (rc);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#344: FILE: drivers/net/sfc/base/efx_rx.c:446:
+	return (0);

ERROR:RETURN_PARENTHESES: return is not a function, parentheses are not required
#351: FILE: drivers/net/sfc/base/efx_rx.c:453:
+	return (rc);

total: 6 errors, 0 warnings, 1 checks, 248 lines checked