From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Andrew Rybchenko <arybchenko@solarflare.com>
Subject: [dpdk-test-report] |WARNING| [PATCH v2 31/55] net/sfc: implement driver operation to init device on attach
Date: Tue, 29 Nov 2016 17:38:43 +0100 (CET) [thread overview]
Message-ID: <20161129163843.A2A4CFA37@dpdk.org> (raw)
In-Reply-To: <1480436367-20749-32-git-send-email-arybchenko@solarflare.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17328
_coding style issues_
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#171: FILE: drivers/net/sfc/sfc.c:56:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#177: FILE: drivers/net/sfc/sfc.c:62:
+ return EFAULT;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -EFAULT)
#221: FILE: drivers/net/sfc/sfc.c:106:
+ return EFAULT;
CHECK:CAMELCASE: Avoid CamelCase: <PRIu8>
#480: FILE: drivers/net/sfc/sfc_debug.h:51:
+ rte_panic("sfc " PCI_PRI_FMT " #%" PRIu8 ": " fmt "
", \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#677: FILE: drivers/net/sfc/sfc_mcdi.c:79:
+ RTE_BUILD_BUG_ON(SFC_MCDI_POLL_INTERVAL_MAX_US > UINT_MAX / 2);
total: 0 errors, 4 warnings, 1 checks, 664 lines checked
parent reply other threads:[~2016-11-29 16:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1480436367-20749-32-git-send-email-arybchenko@solarflare.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129163843.A2A4CFA37@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=arybchenko@solarflare.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).