From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id CAE885597; Wed, 30 Nov 2016 19:16:59 +0100 (CET) In-Reply-To: <1480529810-95280-1-git-send-email-cristian.dumitrescu@intel.com> References: <1480529810-95280-1-git-send-email-cristian.dumitrescu@intel.com> To: test-report@dpdk.org Cc: Cristian Dumitrescu Message-Id: <20161130181659.CAE885597@dpdk.org> Date: Wed, 30 Nov 2016 19:16:59 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [RFC] ethdev: abstraction layer for QoS hierarchical scheduler X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 18:16:59 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17346 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #40: This RFC proposes an ethdev-based abstraction layer for Quality of Service (QoS) ERROR:EXECUTE_PERMISSIONS: do not set execute permissions for source files #165: FILE: lib/librte_ether/rte_ethdev.h WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #198: FILE: lib/librte_ether/rte_ethdev.h:1059: +/** + * Congestion management (CMAN) mode WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #220: FILE: lib/librte_ether/rte_ethdev.h:1081: +/** + * WRED profile WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #228: FILE: lib/librte_ether/rte_ethdev.h:1089: +/** + * Shaper (rate limiter) profile WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #241: FILE: lib/librte_ether/rte_ethdev.h:1102: +/** + * Node parameters WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #263: FILE: lib/librte_ether/rte_ethdev.h:1124: + /**< Child node weight (used by WFQ), relative to some of weights of all + siblings with same priority). The lowest weight is one. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #263: FILE: lib/librte_ether/rte_ethdev.h:1124: + siblings with same priority). The lowest weight is one. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #266: FILE: lib/librte_ether/rte_ethdev.h:1127: + /**< Set of shaper instances enabled for current node. Each node shaper + can be disabled by setting it to RTE_ETH_SCHED_SHAPER_ID_NONE. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #266: FILE: lib/librte_ether/rte_ethdev.h:1127: + can be disabled by setting it to RTE_ETH_SCHED_SHAPER_ID_NONE. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #269: FILE: lib/librte_ether/rte_ethdev.h:1130: + /**< Set to zero if current node is not a hierarchy leaf node, set to a + non-zero value otherwise. A leaf node is a hierarchy node that does WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #271: FILE: lib/librte_ether/rte_ethdev.h:1132: + packet queue. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #280: FILE: lib/librte_ether/rte_ethdev.h:1141: + /**< Set of WRED contexts enabled for current leaf node. Each + leaf node WRED context can be disabled by setting it to WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #282: FILE: lib/librte_ether/rte_ethdev.h:1143: + congestion management for current leaf node is set to WRED. */ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #288: FILE: lib/librte_ether/rte_ethdev.h:1149: +/** + * Node statistics counter type ERROR:SPACING: need consistent spacing around '<<' (ctx:VxW) #292: FILE: lib/librte_ether/rte_ethdev.h:1153: + RTE_ETH_SCHED_STATS_COUNTER_N_PKTS = 1<< 0, ^ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #298: FILE: lib/librte_ether/rte_ethdev.h:1159: + /**< Number of packets currently waiting in the packet queue of current + leaf node. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #298: FILE: lib/librte_ether/rte_ethdev.h:1159: + leaf node. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #301: FILE: lib/librte_ether/rte_ethdev.h:1162: + /**< Number of bytes currently waiting in the packet queue of current + leaf node. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #301: FILE: lib/librte_ether/rte_ethdev.h:1162: + leaf node. */ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #306: FILE: lib/librte_ether/rte_ethdev.h:1167: +/** + * Node statistics counters WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #320: FILE: lib/librte_ether/rte_ethdev.h:1181: + /**< Number of packets currently waiting in the packet queue of + current leaf node. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #320: FILE: lib/librte_ether/rte_ethdev.h:1181: + current leaf node. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #323: FILE: lib/librte_ether/rte_ethdev.h:1184: + /**< Number of bytes currently waiting in the packet queue of + current leaf node. */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #323: FILE: lib/librte_ether/rte_ethdev.h:1184: + current leaf node. */ ERROR:TRAILING_WHITESPACE: trailing whitespace #777: FILE: lib/librte_ether/rte_ethdev.h:4915: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #799: FILE: lib/librte_ether/rte_ethdev.h:4937: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #815: FILE: lib/librte_ether/rte_ethdev.h:4953: + * $ ERROR:TRAILING_WHITESPACE: trailing whitespace #831: FILE: lib/librte_ether/rte_ethdev.h:4969: + * $ ERROR:SPACING: spaces required around that '?' (ctx:VxW) #991: FILE: lib/librte_ether/rte_ethdev.h:5129: + return (dev->dev_ops->sched_run)? dev->dev_ops->sched_run(dev) : 0; ^ total: 7 errors, 23 warnings, 824 lines checked