From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Subject: [dpdk-test-report] |WARNING| [PATCH 10/24] ethdev: parse ethertype filter
Date: Fri, 2 Dec 2016 05:14:14 +0100 (CET) [thread overview]
Message-ID: <20161202041414.C82B5FA5B@dpdk.org> (raw)
In-Reply-To: <1480679625-4157-11-git-send-email-beilei.xing@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17371
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#210: FILE: lib/librte_ether/rte_flow_driver.h:179:
+#define PATTERN_SKIP_VOID(filter, filter_struct, error_type) \
+ do { \
+ if (!pattern) { \
+ memset(filter, 0, sizeof(filter_struct)); \
+ error->type = error_type; \
+ return -EINVAL; \
+ } \
+ item = pattern + i; \
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) { \
+ i++; \
+ item = pattern + i; \
+ } \
+ } while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#224: FILE: lib/librte_ether/rte_flow_driver.h:193:
+#define ACTION_SKIP_VOID(filter, filter_struct, error_type) \
+ do { \
+ if (!actions) { \
+ memset(filter, 0, sizeof(filter_struct)); \
+ error->type = error_type; \
+ return -EINVAL; \
+ } \
+ act = actions + i; \
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) { \
+ i++; \
+ act = actions + i; \
+ } \
+ } while (0)
total: 0 errors, 2 warnings, 179 lines checked
parent reply other threads:[~2016-12-02 4:14 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1480679625-4157-11-git-send-email-beilei.xing@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202041414.C82B5FA5B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=beilei.xing@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).