From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id BBE02FA30; Fri,  2 Dec 2016 10:52:21 +0100 (CET)
In-Reply-To: <1480671985-3677-3-git-send-email-declan.doherty@intel.com>
References: <1480671985-3677-3-git-send-email-declan.doherty@intel.com>
To: test-report@dpdk.org
Cc: Declan Doherty <declan.doherty@intel.com>
Message-Id: <20161202095221.BBE02FA30@dpdk.org>
Date: Fri,  2 Dec 2016 10:52:21 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| [PATCH 2/2] crypto/aesni_mb: add new
	option to select SIMD mode
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Dec 2016 09:52:21 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17458

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#41: 
Add new initialisation option to the aesni_mb_pmd to allow the user to specify

ERROR:SPACING: space required before the open parenthesis '('
#92: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:615:
+	switch(aesni_mb_init_params->mode) {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#173: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:731:
+	}
+	else if (strcmp("avx2", value) == 0) {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#177: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:735:
+	}
+	else if (strcmp("avx", value) == 0) {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#181: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:739:
+	}
+	else if (strcmp("sse", value) == 0) {

WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#189: FILE: drivers/crypto/aesni_mb/rte_aesni_mb_pmd.c:747:
+static const char *cryptodev_vdev_valid_params[] = {

total: 4 errors, 2 warnings, 208 lines checked