From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wei Zhao <wei.zhao1@intel.com>
Subject: [dpdk-test-report] |WARNING| [PATCH 11/18] net/ixgbe: parse n-tuple filter
Date: Fri, 2 Dec 2016 11:47:38 +0100 (CET) [thread overview]
Message-ID: <20161202104738.AFC08FA63@dpdk.org> (raw)
In-Reply-To: <1480675394-59179-12-git-send-email-wei.zhao1@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17470
_coding style issues_
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#79: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:408:
+enum rte_flow_error_type
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#84: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:413:
+int ixgbe_flow_validate(struct rte_eth_dev *dev,
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#132: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8042:
+#define PATTERN_SKIP_VOID(filter, filter_struct, ret)\
+ do {\
+ if (!pattern) {\
+ memset(filter, 0, sizeof(filter_struct));\
+ return ret;\
+ } \
+ item = pattern + i;\
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ i++;\
+ item = pattern + i;\
+ } \
+ } while (0)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 40)
#139: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8049:
+ while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+ i++;\
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#145: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8055:
+#define ACTION_SKIP_VOID(filter, filter_struct, ret)\
+ do {\
+ if (!actions) {\
+ memset(filter, 0, sizeof(filter_struct));\
+ return ret;\
+ } \
+ act = actions + i;\
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ i++;\
+ act = actions + i;\
+ } \
+ } while (0)
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 40)
#152: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8062:
+ while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+ i++;\
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#435: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8345:
+
+}
total: 0 errors, 6 warnings, 1 checks, 379 lines checked
parent reply other threads:[~2016-12-02 10:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1480675394-59179-12-git-send-email-wei.zhao1@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202104738.AFC08FA63@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=wei.zhao1@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).