From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id AFC08FA63; Fri,  2 Dec 2016 11:47:38 +0100 (CET)
In-Reply-To: <1480675394-59179-12-git-send-email-wei.zhao1@intel.com>
References: <1480675394-59179-12-git-send-email-wei.zhao1@intel.com>
To: test-report@dpdk.org
Cc: Wei Zhao <wei.zhao1@intel.com>
Message-Id: <20161202104738.AFC08FA63@dpdk.org>
Date: Fri,  2 Dec 2016 11:47:38 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| [PATCH 11/18] net/ixgbe: parse n-tuple
	filter
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 02 Dec 2016 10:47:39 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17470

_coding style issues_


WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#79: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:408:
+enum rte_flow_error_type

WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#84: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:413:
+int ixgbe_flow_validate(struct rte_eth_dev *dev,

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#132: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8042:
+#define PATTERN_SKIP_VOID(filter, filter_struct, ret)\
+		do {\
+			if (!pattern) {\
+			memset(filter, 0, sizeof(filter_struct));\
+			return ret;\
+			} \
+			item = pattern + i;\
+			while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+					i++;\
+					item = pattern + i;\
+			} \
+		} while (0)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 40)
#139: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8049:
+			while (item->type == RTE_FLOW_ITEM_TYPE_VOID) {\
+					i++;\

WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#145: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8055:
+#define ACTION_SKIP_VOID(filter, filter_struct, ret)\
+		do {\
+			if (!actions) {\
+			memset(filter, 0, sizeof(filter_struct));\
+			return ret;\
+			} \
+			act = actions + i;\
+			while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+					i++;\
+					act = actions + i;\
+			} \
+		} while (0)

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (24, 40)
#152: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8062:
+			while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {\
+					i++;\

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#435: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:8345:
+
+}

total: 0 errors, 6 warnings, 1 checks, 379 lines checked