automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Wei Dai <wei.dai@intel.com>
Subject: [dpdk-test-report] |WARNING| [PATCH 15/29] net/ixgbe/base: support FW commands to control some PHYs
Date: Sun,  4 Dec 2016 07:36:58 +0100 (CET)	[thread overview]
Message-ID: <20161204063658.4169DFA83@dpdk.org> (raw)
In-Reply-To: <1480833100-48545-15-git-send-email-wei.dai@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17605

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ixgbe_hw *' should also have an identifier name
#63: FILE: drivers/net/ixgbe/base/ixgbe_common.h:164:
+s32 ixgbe_shutdown_fw_phy(struct ixgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ixgbe_hw *' should also have an identifier name
#64: FILE: drivers/net/ixgbe/base/ixgbe_common.h:165:
+s32 ixgbe_fw_phy_activity(struct ixgbe_hw *, u16 activity,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#64: FILE: drivers/net/ixgbe/base/ixgbe_common.h:165:
+s32 ixgbe_fw_phy_activity(struct ixgbe_hw *, u16 activity,

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(ixgbe_fw_map)
#265: FILE: drivers/net/ixgbe/base/ixgbe_x550.c:548:
+	for (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) {

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(ixgbe_fw_map)
#376: FILE: drivers/net/ixgbe/base/ixgbe_x550.c:800:
+	for (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) {

total: 0 errors, 5 warnings, 0 checks, 367 lines checked

           reply	other threads:[~2016-12-04  6:36 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <1480833100-48545-15-git-send-email-wei.dai@intel.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161204063658.4169DFA83@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=wei.dai@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).