* [dpdk-test-report] |WARNING| [PATCH 27/32] net/dpaa2: add packet rx and tx support
[not found] <1480875447-23680-28-git-send-email-hemant.agrawal@nxp.com>
@ 2016-12-04 12:50 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2016-12-04 12:50 UTC (permalink / raw)
To: test-report; +Cc: Hemant Agrawal
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17659
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fd' - possible side-effects?
#191: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:137:
+#define DPAA2_SET_FD_ADDR(fd, addr) do { \
+ fd->simple.addr_lo = lower_32_bits((uint64_t)addr); \
+ fd->simple.addr_hi = upper_32_bits((uint64_t)addr); \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#191: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:137:
+#define DPAA2_SET_FD_ADDR(fd, addr) do { \
+ fd->simple.addr_lo = lower_32_bits((uint64_t)addr); \
+ fd->simple.addr_hi = upper_32_bits((uint64_t)addr); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects?
#191: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:137:
+#define DPAA2_SET_FD_ADDR(fd, addr) do { \
+ fd->simple.addr_lo = lower_32_bits((uint64_t)addr); \
+ fd->simple.addr_hi = upper_32_bits((uint64_t)addr); \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#195: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:141:
+#define DPAA2_SET_FD_LEN(fd, length) fd->simple.len = length
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#196: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:142:
+#define DPAA2_SET_FD_BPID(fd, bpid) (fd->simple.bpid_offset |= bpid)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#197: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:143:
+#define DPAA2_SET_FD_OFFSET(fd, offset) \
+ ((fd->simple.bpid_offset |= (uint32_t)(offset) << 16))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#199: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:145:
+#define DPAA2_RESET_FD_CTRL(fd) fd->simple.ctrl = 0
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#201: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:147:
+#define DPAA2_SET_FD_ASAL(fd, asal) (fd->simple.ctrl |= (asal << 16))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'asal' may be better as '(asal)' to avoid precedence issues
#201: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:147:
+#define DPAA2_SET_FD_ASAL(fd, asal) (fd->simple.ctrl |= (asal << 16))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fd' - possible side-effects?
#202: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:148:
+#define DPAA2_SET_FD_FLC(fd, addr) do { \
+ fd->simple.flc_lo = lower_32_bits((uint64_t)addr); \
+ fd->simple.flc_hi = upper_32_bits((uint64_t)addr); \
+} while (0)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#202: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:148:
+#define DPAA2_SET_FD_FLC(fd, addr) do { \
+ fd->simple.flc_lo = lower_32_bits((uint64_t)addr); \
+ fd->simple.flc_hi = upper_32_bits((uint64_t)addr); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects?
#202: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:148:
+#define DPAA2_SET_FD_FLC(fd, addr) do { \
+ fd->simple.flc_lo = lower_32_bits((uint64_t)addr); \
+ fd->simple.flc_hi = upper_32_bits((uint64_t)addr); \
+} while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fd' - possible side-effects?
#206: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:152:
+#define DPAA2_GET_FD_ADDR(fd) \
+((uint64_t)((((uint64_t)(fd->simple.addr_hi)) << 32) + fd->simple.addr_lo))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#206: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:152:
+#define DPAA2_GET_FD_ADDR(fd) \
+((uint64_t)((((uint64_t)(fd->simple.addr_hi)) << 32) + fd->simple.addr_lo))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#209: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:155:
+#define DPAA2_GET_FD_LEN(fd) (fd->simple.len)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#210: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:156:
+#define DPAA2_GET_FD_BPID(fd) ((fd->simple.bpid_offset & 0x00003FFF))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues
#211: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:157:
+#define DPAA2_GET_FD_OFFSET(fd) ((fd->simple.bpid_offset & 0x0FFF0000) >> 16)
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'buf' may be better as '(buf)' to avoid precedence issues
#212: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:158:
+#define DPAA2_INLINE_MBUF_FROM_BUF(buf, meta_data_size) \
+ ((struct rte_mbuf *)((uint64_t)buf - meta_data_size))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'meta_data_size' may be better as '(meta_data_size)' to avoid precedence issues
#212: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:158:
+#define DPAA2_INLINE_MBUF_FROM_BUF(buf, meta_data_size) \
+ ((struct rte_mbuf *)((uint64_t)buf - meta_data_size))
CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'mbuf' may be better as '(mbuf)' to avoid precedence issues
#226: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:172:
+#define DPAA2_MBUF_VADDR_TO_IOVA(mbuf) (mbuf->buf_addr)
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#326: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:65:
+ /* need to repopulated some of the fields,
+ as they may have changed in last transmission*/
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#326: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:65:
+ as they may have changed in last transmission*/
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#419: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:158:
+ /*Check if the previous issued command is completed.
+ *Also seems like the SWP is shared between the Ethernet Driver
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#420: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:159:
+ *and the SEC driver.*/
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#424: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:163:
+ * new token by QBMAN */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#428: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:167:
+ /* Check whether Last Pull command is Expired and
+ setting Condition for Loop termination */
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#428: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:167:
+ setting Condition for Loop termination */
total: 0 errors, 7 warnings, 20 checks, 358 lines checked
^ permalink raw reply [flat|nested] only message in thread