From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by dpdk.org (Postfix, from userid 1017) id BC25DFA7F; Mon, 5 Dec 2016 08:29:52 +0100 (CET) In-Reply-To: <20161205125540.6419-7-akhil.goyal@nxp.com> References: <20161205125540.6419-7-akhil.goyal@nxp.com> To: test-report@dpdk.org Cc: Akhil Goyal Message-Id: <20161205072952.BC25DFA7F@dpdk.org> Date: Mon, 5 Dec 2016 08:29:52 +0100 (CET) From: checkpatch@dpdk.org Subject: [dpdk-test-report] |WARNING| [PATCH 6/8] crypto/dpaa2_sec: add sec procssing functionality X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Dec 2016 07:29:52 -0000 Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/17677 _coding style issues_ WARNING:AVOID_EXTERNS: externs should be avoided in .c files #194: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:70: +extern struct dpaa2_bp_info bpid_info[MAX_BPID]; WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #235: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:111: + /* TODO we are using the first FLE entry to store Mbuf. + Currently we donot know which FLE has the mbuf stored. WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #238: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:114: + We can have a better approach to use the inline Mbuf*/ WARNING:LONG_LINE: line over 90 characters #301: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:177: + DPAA2_SET_FD_LEN(fd, (sym_op->auth.data.length + sym_op->cipher.iv.length)); WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #365: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:241: + /* TODO we are using the first FLE entry to store Mbuf. + Currently we donot know which FLE has the mbuf stored. WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #368: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:244: + We can have a better approach to use the inline Mbuf*/ WARNING:LONG_LINE: line over 90 characters #393: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:269: + DPAA2_SET_FLE_OFFSET(fle, sym_op->auth.data.offset + sym_op->m_src->data_off); WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #449: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:325: + /* TODO we are using the first FLE entry to store Mbuf. + Currently we donot know which FLE has the mbuf stored. WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #452: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:328: + We can have a better approach to use the inline Mbuf*/ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #631: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:507: + /* TODO we are using the first FLE entry to store Mbuf. + Currently we donot know which FLE has the mbuf stored. WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #634: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:510: + We can have a better approach to use the inline Mbuf*/ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #707: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:583: + /* Receive the packets till Last Dequeue entry is found with + respect to the above issues PULL command. WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #711: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:587: + /*Check if the previous issued command is completed. + *Also seems like the SWP is shared between the Ethernet Driver WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #712: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:588: + *and the SEC driver.*/ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #717: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:593: + * new token by QBMAN */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #721: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:597: + /* Check whether Last Pull command is Expired and + setting Condition for Loop termination */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #721: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:597: + setting Condition for Loop termination */ WARNING:LONG_LINE: line over 90 characters #906: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:782: + memcpy(session->cipher_key.data, xform->cipher.key.data, xform->cipher.key.length); WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *' #1247: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c:1123: + 0, (unsigned *)priv->flc_desc[0].desc, WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1602: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h:46: + unsigned max_nb_queue_pairs; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1604: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h:48: + unsigned max_nb_sessions; WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1712: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h:156: + * be 0 if no truncation required */ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #1712: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h:156: + uint8_t trunc_len; /*!< Length for output ICV, should + * be 0 if no truncation required */ WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1723: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h:167: + * be 0 if no truncation required */ WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line #1723: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h:167: + uint8_t trunc_len; /*!< Length for output ICV, should + * be 0 if no truncation required */ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #1746: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h:190: +/* struct nadk_ipsec_ctxt ipsec_ctxt; + struct nadk_pdcp_ctxt pdcp_ctxt; WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1747: FILE: drivers/crypto/dpaa2_sec/dpaa2_sec_priv.h:191: + struct nadk_null_sec_ctxt null_sec_ctxt;*/ CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues #2081: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:143: +#define DPAA2_SET_FD_IVP(fd) ((fd->simple.bpid_offset |= 0x00004000)) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues #2084: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:146: +#define DPAA2_SET_FD_INTERNAL_JD(fd, len) fd->simple.frc = (0x80000000 | (len)) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fle' may be better as '(fle)' to avoid precedence issues #2092: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:154: +#define DPAA2_SET_FLE_INTERNAL_JD(fle, len) (fle->frc = (0x80000000 | (len))) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fle' - possible side-effects? #2093: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:155: +#define DPAA2_GET_FLE_ADDR(fle) \ + (uint64_t)((((uint64_t)(fle->addr_hi)) << 32) + fle->addr_lo) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fle' may be better as '(fle)' to avoid precedence issues #2093: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:155: +#define DPAA2_GET_FLE_ADDR(fle) \ + (uint64_t)((((uint64_t)(fle->addr_hi)) << 32) + fle->addr_lo) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fle' - possible side-effects? #2095: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:157: +#define DPAA2_SET_FLE_ADDR(fle, addr) do { \ + fle->addr_lo = lower_32_bits((uint64_t)addr); \ + fle->addr_hi = upper_32_bits((uint64_t)addr); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fle' may be better as '(fle)' to avoid precedence issues #2095: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:157: +#define DPAA2_SET_FLE_ADDR(fle, addr) do { \ + fle->addr_lo = lower_32_bits((uint64_t)addr); \ + fle->addr_hi = upper_32_bits((uint64_t)addr); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #2095: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:157: +#define DPAA2_SET_FLE_ADDR(fle, addr) do { \ + fle->addr_lo = lower_32_bits((uint64_t)addr); \ + fle->addr_hi = upper_32_bits((uint64_t)addr); \ +} while (0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fle' may be better as '(fle)' to avoid precedence issues #2102: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:164: +#define DPAA2_GET_FLE_BPID(fle, bpid) (fle->fin_bpid_offset & 0x000000ff) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fle' may be better as '(fle)' to avoid precedence issues #2103: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:165: +#define DPAA2_SET_FLE_FIN(fle) (fle->fin_bpid_offset |= (uint64_t)1 << 31) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues #2105: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:167: +#define DPAA2_SET_FD_COMPOUND_FMT(fd) \ + (fd->simple.bpid_offset |= (uint32_t)1 << 28) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fd' may be better as '(fd)' to avoid precedence issues #2112: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:174: +#define DPAA2_GET_FD_IVP(fd) ((fd->simple.bpid_offset & 0x00004000) >> 14) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fle' may be better as '(fle)' to avoid precedence issues #2114: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:176: +#define DPAA2_SET_FLE_SG_EXT(fle) (fle->fin_bpid_offset |= (uint64_t)1 << 29) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'fle' may be better as '(fle)' to avoid precedence issues #2115: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:177: +#define DPAA2_IS_SET_FLE_SG_EXT(fle) \ + ((fle->fin_bpid_offset & ((uint64_t)1 << 29)) ? 1 : 0) CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'op' may be better as '(op)' to avoid precedence issues #2125: FILE: drivers/net/dpaa2/base/dpaa2_hw_pvt.h:232: +#define DPAA2_OP_VADDR_TO_IOVA(op) (op->phys_addr) total: 0 errors, 27 warnings, 15 checks, 1965 lines checked