From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Gregory Etelson <gregory@weka.io>
Subject: [dpdk-test-report] |WARNING| pw17776 [PATCH] IGB_UIO: PCI Resources Management
Date: Wed, 14 Dec 2016 23:59:09 +0100 (CET) [thread overview]
Message-ID: <20161214225909.1C512316B@dpdk.org> (raw)
In-Reply-To: <3355891.l3I590SjcV@polaris>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17776
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18:
The patches below provide IGB_UIO release callback and IXGBEVF release function
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#37: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:176:
+ extern int ixgbevf_uio_release(struct pci_dev *pdev, u8 __iomem *hw_addr);$
WARNING:AVOID_EXTERNS: externs should be avoided in .c files
#37: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:176:
+ extern int ixgbevf_uio_release(struct pci_dev *pdev, u8 __iomem *hw_addr);
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#38: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:177:
+ int ret;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#39: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:178:
+ struct rte_uio_pci_dev *udev = info->priv;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#40: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:179:
+ ret = ixgbevf_uio_release(udev->pdev, info->mem[0].internal_addr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#41: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:180:
+ return 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#51: FILE: lib/librte_eal/linuxapp/igb_uio/igb_uio.c:381:
+ udev->info.release = igbuio_pci_release;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#70: FILE: src/ixgbevf_main.c:3007:
+ int err;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#71: FILE: src/ixgbevf_main.c:3008:
+ struct ixgbe_hw __hw;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#72: FILE: src/ixgbevf_main.c:3009:
+ struct ixgbe_hw *hw = &__hw;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#74: FILE: src/ixgbevf_main.c:3011:
+ if (!hw_addr) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 15)
#74: FILE: src/ixgbevf_main.c:3011:
+ if (!hw_addr) {
+ dev_warn(&pdev->dev, "ixgbevf_uio_release: no HW addr. Bailing out
");
WARNING:BRACES: braces {} are not necessary for single statement blocks
#74: FILE: src/ixgbevf_main.c:3011:
+ if (!hw_addr) {
+ dev_warn(&pdev->dev, "ixgbevf_uio_release: no HW addr. Bailing out
");
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#75: FILE: src/ixgbevf_main.c:3012:
+ dev_warn(&pdev->dev, "ixgbevf_uio_release: no HW addr. Bailing out
");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#75: FILE: src/ixgbevf_main.c:3012:
+ dev_warn(&pdev->dev, "ixgbevf_uio_release: no HW addr. Bailing out
");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#76: FILE: src/ixgbevf_main.c:3013:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#78: FILE: src/ixgbevf_main.c:3015:
+ memset(hw, 0, sizeof(*hw));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#79: FILE: src/ixgbevf_main.c:3016:
+ hw->hw_addr = hw_addr;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#82: FILE: src/ixgbevf_main.c:3019:
+ hw->vendor_id = pdev->vendor;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#83: FILE: src/ixgbevf_main.c:3020:
+ hw->device_id = pdev->device;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#84: FILE: src/ixgbevf_main.c:3021:
+ pci_read_config_byte(pdev, PCI_REVISION_ID, &hw->revision_id);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#85: FILE: src/ixgbevf_main.c:3022:
+ hw->subsystem_vendor_id = pdev->subsystem_vendor;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#86: FILE: src/ixgbevf_main.c:3023:
+ hw->subsystem_device_id = pdev->subsystem_device;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#88: FILE: src/ixgbevf_main.c:3025:
+ ixgbe_init_ops_vf(hw);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#89: FILE: src/ixgbevf_main.c:3026:
+ hw->mbx.ops.init_params(hw);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#92: FILE: src/ixgbevf_main.c:3029:
+ hw->mac.max_tx_queues = 2;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#93: FILE: src/ixgbevf_main.c:3030:
+ hw->mac.max_rx_queues = 2;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#95: FILE: src/ixgbevf_main.c:3032:
+ err = hw->mac.ops.stop_adapter(hw);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#96: FILE: src/ixgbevf_main.c:3033:
+ dev_info(&pdev->dev, "ixgbevf_uio_release: UIO adapter stopped
");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#97: FILE: src/ixgbevf_main.c:3034:
+ return err;$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 2 errors, 30 warnings, 62 lines checked
parent reply other threads:[~2016-12-14 22:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <3355891.l3I590SjcV@polaris>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161214225909.1C512316B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gregory@weka.io \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).