automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-test-report] |WARNING| pw17960 [PATCH 2/2] hyperv: VMBUS support infrastucture
Date: Thu, 15 Dec 2016 01:00:03 +0100 (CET)	[thread overview]
Message-ID: <20161215000003.22E024AC7@dpdk.org> (raw)
In-Reply-To: <20161214235920.12877-3-sthemmin@microsoft.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17960

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#203: FILE: lib/librte_eal/common/eal_internal_cfg.h:72:
+					   * instead of native TSC */

ERROR:TRAILING_WHITESPACE: trailing whitespace
#350: FILE: lib/librte_eal/common/include/rte_vmbus.h:71:
+^I$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#472: FILE: lib/librte_eal/common/include/rte_vmbus.h:193:
+ * ^IThe VMBUS device uuid.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#487: FILE: lib/librte_eal/common/include/rte_vmbus.h:208:
+ * ^IThe VMBUS device uuid.$

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#688: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:96:
+	if (buf[0] == '{' && (cp = strchr(buf, '}')))

ERROR:CODE_INDENT: code indent should use tabs where possible
#1082: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:490:
+ ^I^I^I^Ivmbus_unmap_resource(uio_res->maps[i].addr,$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1082: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:490:
+ ^I^I^I^Ivmbus_unmap_resource(uio_res->maps[i].addr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1082: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:490:
+ ^I^I^I^Ivmbus_unmap_resource(uio_res->maps[i].addr,$

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1249: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:657:
+			return 0;
+		else {

total: 3 errors, 6 warnings, 1492 lines checked

           reply	other threads:[~2016-12-15  0:00 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20161214235920.12877-3-sthemmin@microsoft.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161215000003.22E024AC7@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).