From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 22E024AC7; Thu, 15 Dec 2016 01:00:03 +0100 (CET)
In-Reply-To: <20161214235920.12877-3-sthemmin@microsoft.com>
References: <20161214235920.12877-3-sthemmin@microsoft.com>
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20161215000003.22E024AC7@dpdk.org>
Date: Thu, 15 Dec 2016 01:00:03 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw17960 [PATCH 2/2] hyperv: VMBUS
	support infrastucture
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 15 Dec 2016 00:00:03 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/17960

_coding style issues_


WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#203: FILE: lib/librte_eal/common/eal_internal_cfg.h:72:
+					   * instead of native TSC */

ERROR:TRAILING_WHITESPACE: trailing whitespace
#350: FILE: lib/librte_eal/common/include/rte_vmbus.h:71:
+^I$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#472: FILE: lib/librte_eal/common/include/rte_vmbus.h:193:
+ * ^IThe VMBUS device uuid.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#487: FILE: lib/librte_eal/common/include/rte_vmbus.h:208:
+ * ^IThe VMBUS device uuid.$

ERROR:ASSIGN_IN_IF: do not use assignment in if condition
#688: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:96:
+	if (buf[0] == '{' && (cp = strchr(buf, '}')))

ERROR:CODE_INDENT: code indent should use tabs where possible
#1082: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:490:
+ ^I^I^I^Ivmbus_unmap_resource(uio_res->maps[i].addr,$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#1082: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:490:
+ ^I^I^I^Ivmbus_unmap_resource(uio_res->maps[i].addr,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1082: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:490:
+ ^I^I^I^Ivmbus_unmap_resource(uio_res->maps[i].addr,$

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1249: FILE: lib/librte_eal/linuxapp/eal/eal_vmbus.c:657:
+			return 0;
+		else {

total: 3 errors, 6 warnings, 1492 lines checked