From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 81F1510C36; Wed, 21 Dec 2016 10:52:33 +0100 (CET)
In-Reply-To: <1482313694-31602-16-git-send-email-wei.dai@intel.com>
References: <1482313694-31602-16-git-send-email-wei.dai@intel.com>
To: test-report@dpdk.org
Cc: Wei Dai <wei.dai@intel.com>
Message-Id: <20161221095233.81F1510C36@dpdk.org>
Date: Wed, 21 Dec 2016 10:52:33 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw18335 [PATCH v2 15/30]
	net/ixgbe/base: support FW commands to control some PHYs
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Dec 2016 09:52:34 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18335

_coding style issues_


WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ixgbe_hw *' should also have an identifier name
#62: FILE: drivers/net/ixgbe/base/ixgbe_common.h:164:
+s32 ixgbe_shutdown_fw_phy(struct ixgbe_hw *);

WARNING:FUNCTION_ARGUMENTS: function definition argument 'struct ixgbe_hw *' should also have an identifier name
#63: FILE: drivers/net/ixgbe/base/ixgbe_common.h:165:
+s32 ixgbe_fw_phy_activity(struct ixgbe_hw *, u16 activity,

WARNING:FUNCTION_ARGUMENTS: function definition argument 'u32' should also have an identifier name
#63: FILE: drivers/net/ixgbe/base/ixgbe_common.h:165:
+s32 ixgbe_fw_phy_activity(struct ixgbe_hw *, u16 activity,

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(ixgbe_fw_map)
#264: FILE: drivers/net/ixgbe/base/ixgbe_x550.c:548:
+	for (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) {

WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(ixgbe_fw_map)
#375: FILE: drivers/net/ixgbe/base/ixgbe_x550.c:800:
+	for (i = 0; i < sizeof(ixgbe_fw_map) / sizeof(ixgbe_fw_map[0]); ++i) {

total: 0 errors, 5 warnings, 0 checks, 367 lines checked