From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <checkpatch@dpdk.org>
Received: by dpdk.org (Postfix, from userid 1017)
 id 7EC05F91C; Tue, 27 Dec 2016 07:27:58 +0100 (CET)
In-Reply-To: <1482819984-14120-8-git-send-email-beilei.xing@intel.com>
References: <1482819984-14120-8-git-send-email-beilei.xing@intel.com>
To: test-report@dpdk.org
Cc: Beilei Xing <beilei.xing@intel.com>
Message-Id: <20161227062758.7EC05F91C@dpdk.org>
Date: Tue, 27 Dec 2016 07:27:58 +0100 (CET)
From: checkpatch@dpdk.org
Subject: [dpdk-test-report] |WARNING| pw18551 [PATCH v2 07/17] net/i40e: add
	flow validate function
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Dec 2016 06:27:58 -0000

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/18551

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv4>
#243: FILE: drivers/net/i40e/i40e_flow.c:110:
+	if (ethertype_filter->ether_type == ETHER_TYPE_IPv4 ||

CHECK:CAMELCASE: Avoid CamelCase: <ETHER_TYPE_IPv6>
#244: FILE: drivers/net/i40e/i40e_flow.c:111:
+	    ethertype_filter->ether_type == ETHER_TYPE_IPv6) {

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'act' - possible side-effects?
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'actions' - possible side-effects?
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'actions' may be better as '(actions)' to avoid precedence issues
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'index' may be better as '(index)' to avoid precedence issues
#263: FILE: drivers/net/i40e/i40e_flow.c:130:
+#define NEXT_ITEM_OF_ACTION(act, actions, index)                        \
+	do {                                                            \
+		act = actions + index;                                  \
+		while (act->type == RTE_FLOW_ACTION_TYPE_VOID) {        \
+			index++;                                        \
+			act = actions + index;                          \
+		}                                                       \
+	} while (0)

total: 0 errors, 0 warnings, 7 checks, 485 lines checked